)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fceb9e9d701183b00e637d0b71db6cc349f3876c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Every in tree driver that implements RPC send uses jsonutils.dumps to"},{"line_number":10,"context_line":"serialize the message, except FakeDriver. FakeDriver uses json.dumps."},{"line_number":11,"context_line":"However json.dumps a lot more strict than jsonutils. This caused nova to"},{"line_number":12,"context_line":"introduce test specific changes in the rpc handling [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes sure that each driver uses the same json serialization."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_10a910de","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":56},"updated":"2019-09-20 17:55:40.000000000","message":"You forgot to link for this.","commit_id":"dda18a45bd64a0ea13748c20b3c51df20d046b71"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"615828035b1672c016d6be03216c1a3a55c3a0b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Every in tree driver that implements RPC send uses jsonutils.dumps to"},{"line_number":10,"context_line":"serialize the message, except FakeDriver. FakeDriver uses json.dumps."},{"line_number":11,"context_line":"However json.dumps a lot more strict than jsonutils. This caused nova to"},{"line_number":12,"context_line":"introduce test specific changes in the rpc handling [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes sure that each driver uses the same json serialization."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7772b313","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":56},"in_reply_to":"3fa7e38b_10a910de","updated":"2019-09-21 13:07:19.000000000","message":"Done","commit_id":"dda18a45bd64a0ea13748c20b3c51df20d046b71"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"004b14c0e2a27e03870b88a2b4381d504d1599b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I\u0027ve tried to dig in to the history of the strictness of the"},{"line_number":17,"context_line":"FakeDriver. That driver with the json.dumps() call was added back in"},{"line_number":18,"context_line":"2013 with e2b74cc9e6605156dfd6e36cdfd1b5136161d526. (I cannot link to"},{"line_number":19,"context_line":"that commit in any online way but it is in my local git clone.)"},{"line_number":20,"context_line":"Checking out that commit I don\u0027t see any other drivers present in the"},{"line_number":21,"context_line":"repo but the code does mention drivers like RabbitDriver and ZmqDriver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f75f836f","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":51},"updated":"2019-09-21 13:10:47.000000000","message":"Note: If you click this then it brings you back to my current commit. Poor gerrit, got confused. (Before this patch set gerrit said this commit hash does not exists)","commit_id":"d8980bfed8621eadce36c6a56944ca23245187a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1dce57c992d136b2bcf9ce665795f1463e6ecd17","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I\u0027ve tried to dig in to the history of the strictness of the"},{"line_number":17,"context_line":"FakeDriver. That driver with the json.dumps() call was added back in"},{"line_number":18,"context_line":"2013 with e2b74cc9e6605156dfd6e36cdfd1b5136161d526. (I cannot link to"},{"line_number":19,"context_line":"that commit in any online way but it is in my local git clone.)"},{"line_number":20,"context_line":"Checking out that commit I don\u0027t see any other drivers present in the"},{"line_number":21,"context_line":"repo but the code does mention drivers like RabbitDriver and ZmqDriver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_77f9534b","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":51},"in_reply_to":"3fa7e38b_f75f836f","updated":"2019-09-21 13:44:56.000000000","message":"My guess it was in nova and then sync\u0027ed to oslo.messaging as part of an oslo-incubator sync or extracted when oslo.messaging was created.","commit_id":"d8980bfed8621eadce36c6a56944ca23245187a6"}],"oslo_messaging/_drivers/impl_fake.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fceb9e9d701183b00e637d0b71db6cc349f3876c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    def _check_serialize(message):"},{"line_number":181,"context_line":"        \"\"\"Make sure a message intended for rpc can be serialized."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        We specifically want to use json, not our own jsonutils because"},{"line_number":184,"context_line":"        jsonutils has some extra logic to automatically convert objects to"},{"line_number":185,"context_line":"        primitive types so that they can be serialized.  We want to catch all"},{"line_number":186,"context_line":"        cases where non-primitive types make it into this code and treat it as"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d0aa98d0","side":"PARENT","line":183,"updated":"2019-09-20 17:55:40.000000000","message":"So obviously json.dumps was used on purpose.","commit_id":"440357d74027650701d74a82437921fe946fa347"}]}