)]}'
{"id":"openstack%2Foslo.messaging~691913","triplet_id":"openstack%2Foslo.messaging~master~I8f3a22d2af3f34b368bae3465bf8433fe2d3e22b","project":"openstack/oslo.messaging","branch":"master","topic":"bug/1850470","hashtags":[],"change_id":"I8f3a22d2af3f34b368bae3465bf8433fe2d3e22b","subject":"Removed unused variable pools","status":"MERGED","created":"2019-10-29 16:36:55.000000000","updated":"2019-12-18 15:36:04.000000000","submitted":"2019-12-18 15:33:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"691913-1576683215893-71032318","meta_rev_id":"48e3de89068fb2284471510e9475c641cceab283","_number":691913,"virtual_id_number":691913,"owner":{"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-18 15:33:35.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2019-12-18 11:06:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2019-12-18 11:06:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-31 08:14:50.000000000","updated_by":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"reviewer":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"state":"REVIEWER"},{"updated":"2019-11-04 16:14:08.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2019-12-18 11:06:47.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-12-18 15:33:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"da60c8c333b7700071f55e7fa1390e9ce4aebd31","author":{"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},"date":"2019-10-29 16:36:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dbb09b0a295c105b8a547ec6977f25dd47557526","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-29 20:11:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/16c88e71a5664d7da7ab8f506986b4e8 : SUCCESS in 1h 37m 53s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/67e98fc4f10f48038a0056f162adf74b : SUCCESS in 1h 36m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5f9afff09b1449609c62c7d28ad546d5 : SUCCESS in 7m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7f35b6abdd364872b62c58aa008ef82e : SUCCESS in 5m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84faf7982e96449db0341f417d791464 : SUCCESS in 3m 15s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/dc0be67cc07243a39572a3a3f540ec6f : SUCCESS in 6m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9ae9fb3609ad42518621f9a427c540c0 : SUCCESS in 5m 40s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c11a4a09dea040c49e077e9fcb4bf655 : SUCCESS in 6m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1877b3bc15a348b1864d2ded86699007 : SUCCESS in 5m 21s\n- oslo.messaging-tox-py27-func-rabbit https://zuul.opendev.org/t/openstack/build/b1580a270c5543c38dcfdf01960b011b : SUCCESS in 5m 56s\n- oslo.messaging-tox-py27-func-amqp1 https://zuul.opendev.org/t/openstack/build/7addbca3ffd447749e501d228128d902 : FAILURE in 12m 08s (non-voting)\n- oslo.messaging-tox-py27-func-kafka https://zuul.opendev.org/t/openstack/build/7095eb24e6464547a6d41af846988fc7 : FAILURE in 6m 12s (non-voting)\n- oslo.messaging-tox-py36-func-rabbit https://zuul.opendev.org/t/openstack/build/e43ba66c62144a9b9bca527157ca2d2f : SUCCESS in 8m 33s (non-voting)\n- oslo.messaging-tox-py36-func-amqp1 https://zuul.opendev.org/t/openstack/build/7205dcc05d484b5c91fd6e44a74a7c5f : FAILURE in 11m 59s (non-voting)\n- oslo.messaging-tox-py36-func-kafka https://zuul.opendev.org/t/openstack/build/9fb4eca72a1742ac80f6f5b5fdda14ee : SUCCESS in 5m 11s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/6c324a93b3384e838e9ef458d80ac9c6 : SUCCESS in 1h 36m 51s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/9ee3d845d81a47cba6ff9144f5a945cb : SUCCESS in 1h 46m 33s (non-voting)\n- oslo.messaging-src-dsvm-full-amqp1-centos-7 https://zuul.opendev.org/t/openstack/build/2777ee7298254a489df9729d25f84eac : SUCCESS in 2h 22m 43s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/f9c7f4454f7e4f45943b958af3cd1c05 : SUCCESS in 1h 56m 33s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-centos-7 https://zuul.opendev.org/t/openstack/build/b9c57066928e4a2582ebcee33c88a893 : SUCCESS in 1h 50m 03s (non-voting)\n- oslo.messaging-src-grenade-dsvm https://zuul.opendev.org/t/openstack/build/36b9d9be9d5e4f4eae330d58307b10e2 : SUCCESS in 1h 12m 29s (non-voting)\n- oslo.messaging-src-grenade-dsvm-multinode https://zuul.opendev.org/t/openstack/build/a73dfef5a06f4b02a46b6c49b7f60ba4 : SUCCESS in 1h 22m 13s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-rabbit https://zuul.opendev.org/t/openstack/build/6ca477a5f6084f16b5c45d73a37d94e9 : FAILURE in 49m 10s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-amqp1 https://zuul.opendev.org/t/openstack/build/0166c82f4cc04fd19f9b420135df6ed2 : FAILURE in 52m 32s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-kafka https://zuul.opendev.org/t/openstack/build/b1d0882b5b3c4d9c8967806bc884a5c5 : FAILURE in 48m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5f390889b155966d8b000eae949a172091b1cd52","author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"date":"2019-10-31 08:14:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"286f5c5d8dce42d7bd2eb8957bc36bb984028fce","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-11-04 16:14:08.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nHello,\n\nThanks for these changes.\n\nFirst, I don\u0027t think we can consider this as a bug (cf. https://bugs.launchpad.net/oslo.messaging/+bug/1850470), you don\u0027t speak about related issue or things like that. I put a -1 there related to this, see my comment inline, else these changes seems ok.\n\nAs you saied this variable was added by https://opendev.org/openstack/oslo.messaging/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4\n\nThe same variable existed also on the qpid driver but this driver was deleted:\n \nhttps://opendev.org/openstack/oslo.messaging/src/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4/oslo/messaging/_drivers/impl_qpid.py#L453\n\nInitialy this variable made sense:\n\nhttps://opendev.org/openstack/oslo.messaging/src/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4/oslo/messaging/_drivers/amqp.py#L95\n\nbut now the mechanismes under the hood seems to have evolued and the connection pools seems managed through the `connection_cls` by:\n\nhttps://github.com/openstack/oslo.messaging/blob/044e6f20e65084f3c4ecc554672d3271b2a2acd3/oslo_messaging/_drivers/pool.py#L127\n\nFor all these reasons I think we can remove this variable.","accounts_in_message":[],"_revision_number":1},{"id":"ff14b18713ab6b027bc5d3494d4795342e32c87e","author":{"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},"date":"2019-11-18 13:46:10.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e Hello,\n \u003e \n \u003e Thanks for these changes.\n \u003e \n \u003e First, I don\u0027t think we can consider this as a bug (cf.\n \u003e https://bugs.launchpad.net/oslo.messaging/+bug/1850470), you don\u0027t\n \u003e speak about related issue or things like that. I put a -1 there\n \u003e related to this, see my comment inline, else these changes seems\n \u003e ok.\n \u003e \n \u003e As you saied this variable was added by https://opendev.org/openstack/oslo.messaging/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4\n \u003e \n \u003e The same variable existed also on the qpid driver but this driver\n \u003e was deleted:\n \u003e \n \u003e https://opendev.org/openstack/oslo.messaging/src/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4/oslo/messaging/_drivers/impl_qpid.py#L453\n \u003e \n \u003e Initialy this variable made sense:\n \u003e \n \u003e https://opendev.org/openstack/oslo.messaging/src/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4/oslo/messaging/_drivers/amqp.py#L95\n \u003e \n \u003e but now the mechanismes under the hood seems to have evolued and\n \u003e the connection pools seems managed through the `connection_cls` by:\n \u003e \n \u003e https://github.com/openstack/oslo.messaging/blob/044e6f20e65084f3c4ecc554672d3271b2a2acd3/oslo_messaging/_drivers/pool.py#L127\n \u003e \n \u003e For all these reasons I think we can remove this variable.\n\nHi Herve,\n\nthanks for the review. Sorry for my late reply. I was at OpenInfra Summit 2 weeks ago.\n\nBasically I didn\u0027t face any problem with this unused variable. When I read the code, I found this variable with running \u0027vulture\u0027 tool by accident. \n\nThis variable is a Class Variable. So normally it doesn\u0027t have any negative effects even when it\u0027s not used. However to locate an unused Class Variable is not so easy.\n\nDo you want to remove the \u0027Closes-Bug\u0027 link from the commit? I don\u0027t have problem to do so.","accounts_in_message":[],"_revision_number":1},{"id":"a142ee35496caaa73bec4daebe62ab6277e46e9e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 11:06:19.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"7191fe9e58016b968a9512c0107dc9747af9b189","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 11:06:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nAgreed, this isn\u0027t a bug. Have removed the bug link and closed the bug itself. Going to fast approve now since it\u0027s trivial.","accounts_in_message":[],"_revision_number":2},{"id":"2b59baf95404f5f510580f75e59c91a504e9bab0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 13:29:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/e59fed051466411596998510432aa9ba : SUCCESS in 1h 43m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9c078f8297d644f7a370c23d07d9d402 : SUCCESS in 1h 24m 10s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ba7457330c104c7e85e2e7b101d9d63f : SUCCESS in 7m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7806588b0fb740eea8179ae95ec75a91 : SUCCESS in 7m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8323e3c84a4f423ca073fcc31b475f62 : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/70d22389f8534838a6a5cfe6812ba71a : SUCCESS in 8m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8fb0ba90cdb049bda01f455e986053d3 : SUCCESS in 5m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/22cbbd3613ab4c0c9763aa0cd61c75e4 : SUCCESS in 6m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59002444144a4349bb69a8e2d33592b6 : SUCCESS in 4m 14s\n- oslo.messaging-tox-py27-func-rabbit https://zuul.opendev.org/t/openstack/build/b7cca441015949a9acbb6b09a99b2163 : SUCCESS in 6m 38s\n- oslo.messaging-tox-py27-func-amqp1 https://zuul.opendev.org/t/openstack/build/e7d7b6652e21468794aa8dc00dcf0fb0 : FAILURE in 14m 41s (non-voting)\n- oslo.messaging-tox-py27-func-kafka https://zuul.opendev.org/t/openstack/build/6def6b4e8c75475aa834db23a0355955 : FAILURE in 6m 40s (non-voting)\n- oslo.messaging-tox-py36-func-rabbit https://zuul.opendev.org/t/openstack/build/cae6964ce33140c4aca737e0ff33fea4 : SUCCESS in 6m 04s (non-voting)\n- oslo.messaging-tox-py36-func-amqp1 https://zuul.opendev.org/t/openstack/build/8724838f626547a29b0ce354ef008a68 : FAILURE in 13m 04s (non-voting)\n- oslo.messaging-tox-py36-func-kafka https://zuul.opendev.org/t/openstack/build/142d96ec7da84a589e49859b6dbe56bd : FAILURE in 6m 48s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/8cb4106163ef4b5588d5597eac780102 : SUCCESS in 1h 32m 02s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/d19bd674b2ea4e08bf569d474eb36dc5 : SUCCESS in 1h 28m 47s (non-voting)\n- oslo.messaging-src-dsvm-full-amqp1-centos-7 https://zuul.opendev.org/t/openstack/build/580637859dd24f18bbbbe6232271449f : FAILURE in 7m 31s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/f21086b109494585999b1c79b4864d19 : SUCCESS in 1h 35m 03s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-centos-7 https://zuul.opendev.org/t/openstack/build/cf4babe8d9f446f497f89e2315222fb3 : FAILURE in 8m 30s (non-voting)\n- oslo.messaging-src-grenade-dsvm https://zuul.opendev.org/t/openstack/build/62b314d92e5a4fdc9ca7ab7e20d62524 : SUCCESS in 1h 01m 53s (non-voting)\n- oslo.messaging-src-grenade-dsvm-multinode https://zuul.opendev.org/t/openstack/build/b158cfc202cb4493946756fbd6812631 : FAILURE in 1h 01m 58s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-rabbit https://zuul.opendev.org/t/openstack/build/a6cbd63c7199401182fdb79c72bffa88 : FAILURE in 35m 40s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-amqp1 https://zuul.opendev.org/t/openstack/build/0547179fda21487988063442edded44c : FAILURE in 39m 35s (non-voting)\n- oslo.messaging-telemetry-dsvm-integration-kafka https://zuul.opendev.org/t/openstack/build/f76e55159f374f20a4d977c181538573 : FAILURE in 39m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f39f10e79cd313e64e51b3318b3b711327671681","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 13:29:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5c24635cf9ab3dd2446219291523011138499d73","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 15:33:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"204637cce19f221e6da258db9605f0d8e36d8be9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 15:33:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/8f21f972df594def84e63f09ae94933b : SUCCESS in 1h 45m 55s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6d043798cf23477cb5a8aeb9ccc0ed8e : SUCCESS in 1h 30m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d0d9f82399a14cb589097405c175721d : SUCCESS in 8m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba1d35fff51740be98d2deccff57a768 : SUCCESS in 4m 58s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a6c245806cd944e19afe70361bb019ea : SUCCESS in 6m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/10cd6b5e6fe844e28b7a35e1f08d34ac : SUCCESS in 7m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e2ebee3d4e624335a86082949d0a3d56 : SUCCESS in 9m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/771d9f5325c84eb9abb3dbe0615007bd : SUCCESS in 5m 01s\n- oslo.messaging-tox-py27-func-rabbit https://zuul.opendev.org/t/openstack/build/dca5b5caeaf34533a9d3c6cfc5b298f1 : SUCCESS in 11m 39s\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/05da1553ebbe416f89a902231d601d45 : SUCCESS in 2h 01m 05s","accounts_in_message":[],"_revision_number":2},{"id":"15f9ac61a3d7e8e3d90e1db9da205569bd6807f9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 15:36:04.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de613754ff6f45ae882e6dc89261ca71 : SUCCESS in 1m 48s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2b0613b2080ad71eb2838a35ecf3bc2f423c1396","revisions":{"ae0d8456ff25e454c22aeeeccf21b1c95d211aa2":{"kind":"REWORK","_number":1,"created":"2019-10-29 16:36:55.000000000","uploader":{"_account_id":25591,"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","username":"cshen"},"ref":"refs/changes/13/691913/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/13/691913/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/1"}}},"commit":{"parents":[{"commit":"c01b03e87c66e964100d3d56d91b0f5f045e6190","subject":"Merge \"Update master for stable/train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/c01b03e87c66e964100d3d56d91b0f5f045e6190"}]}],"author":{"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","date":"2019-10-29 16:35:23.000000000","tz":60},"committer":{"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","date":"2019-10-29 16:35:23.000000000","tz":60},"subject":"Removed unused variable pools","message":"Removed unused variable pools\n\nChange-Id: I8f3a22d2af3f34b368bae3465bf8433fe2d3e22b\nCloses-Bug: 1850470\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/ae0d8456ff25e454c22aeeeccf21b1c95d211aa2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/ae0d8456ff25e454c22aeeeccf21b1c95d211aa2"}]},"branch":"refs/heads/master"},"2b0613b2080ad71eb2838a35ecf3bc2f423c1396":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-12-18 11:06:19.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/13/691913/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/13/691913/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/13/691913/2"}}},"commit":{"parents":[{"commit":"c01b03e87c66e964100d3d56d91b0f5f045e6190","subject":"Merge \"Update master for stable/train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/c01b03e87c66e964100d3d56d91b0f5f045e6190"}]}],"author":{"name":"Chenjun Shen","email":"chenjun.shen@gmail.com","date":"2019-10-29 16:35:23.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-12-18 11:06:17.000000000","tz":0},"subject":"Removed unused variable pools","message":"Removed unused variable pools\n\nChange-Id: I8f3a22d2af3f34b368bae3465bf8433fe2d3e22b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/2b0613b2080ad71eb2838a35ecf3bc2f423c1396"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/2b0613b2080ad71eb2838a35ecf3bc2f423c1396"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}