)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"5f7b45563a4fa2f726d2645e2f79c522e5cbeb35","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            if self.incoming:"},{"line_number":310,"context_line":"                LOG.debug(\"Batch poll the incoming message with \""},{"line_number":311,"context_line":"                          \"unique_id (%uid): %(message)\","},{"line_number":312,"context_line":"                          {\u0027uid\u0027: self.incoming[0].unique_id,"},{"line_number":313,"context_line":"                           \u0027message\u0027: self.incoming[0].message})"},{"line_number":314,"context_line":"                return self.incoming.pop(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_de5dfe54","line":311,"updated":"2019-12-17 20:39:37.000000000","message":"I think the formatting here is wrong.  Shouldn\u0027t it be:\n\n%(uid)s    and   %(message)s","commit_id":"31c69015507bc47f6030cf532b1a1b2b0d3805a8"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"5f7b45563a4fa2f726d2645e2f79c522e5cbeb35","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                LOG.debug(\"Batch poll the incoming message with \""},{"line_number":311,"context_line":"                          \"unique_id (%uid): %(message)\","},{"line_number":312,"context_line":"                          {\u0027uid\u0027: self.incoming[0].unique_id,"},{"line_number":313,"context_line":"                           \u0027message\u0027: self.incoming[0].message})"},{"line_number":314,"context_line":"                return self.incoming.pop(0)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            left \u003d stopwatch.leftover(return_none\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5e1fce70","line":313,"updated":"2019-12-17 20:39:37.000000000","message":"You may want to limit the amount of message data you log here since message sizes can be very large.\n\nAlso I wonder if this would risk putting sensitive information into the debug log...","commit_id":"31c69015507bc47f6030cf532b1a1b2b0d3805a8"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"5f7b45563a4fa2f726d2645e2f79c522e5cbeb35","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        self._message_operations_handler.process()"},{"line_number":336,"context_line":"        if self.incoming:"},{"line_number":337,"context_line":"            LOG.debug(\"Batch poll the incoming message with \""},{"line_number":338,"context_line":"                      \"unique_id (%uid): %(message)\","},{"line_number":339,"context_line":"                      {\u0027uid\u0027: self.incoming[0].unique_id,"},{"line_number":340,"context_line":"                       \u0027message\u0027: self.incoming[0].message})"},{"line_number":341,"context_line":"            return self.incoming.pop(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_be6cc207","line":338,"updated":"2019-12-17 20:39:37.000000000","message":"Same questions here too","commit_id":"31c69015507bc47f6030cf532b1a1b2b0d3805a8"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"47390d1a047873594e373b301513347c7aca7399","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                LOG.debug(\"AMQPListener connection consume\")"},{"line_number":322,"context_line":"                self.conn.consume(timeout\u003dmin(self._current_timeout, left))"},{"line_number":323,"context_line":"            except rpc_common.Timeout:"},{"line_number":324,"context_line":"                LOG.debug(\"AMQPListener rpc connection timeout\")"},{"line_number":325,"context_line":"                self._current_timeout \u003d max(self._current_timeout * 2,"},{"line_number":326,"context_line":"                                            ACK_REQUEUE_EVERY_SECONDS_MAX)"},{"line_number":327,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_722f36a6","line":324,"updated":"2019-12-19 18:49:27.000000000","message":"I just noticed this log is issued for both RPC and Notifications.  In the notification case the \"rpc\" text is misleading.\n\nOtherwise this patch looks good.","commit_id":"2985ad6f14e9a195152979846a196a720b5af735"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f73fd242a3364214ec39b3120eca89a358c1e6b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                LOG.debug(\"AMQPListener connection consume\")"},{"line_number":322,"context_line":"                self.conn.consume(timeout\u003dmin(self._current_timeout, left))"},{"line_number":323,"context_line":"            except rpc_common.Timeout:"},{"line_number":324,"context_line":"                LOG.debug(\"AMQPListener rpc connection timeout\")"},{"line_number":325,"context_line":"                self._current_timeout \u003d max(self._current_timeout * 2,"},{"line_number":326,"context_line":"                                            ACK_REQUEUE_EVERY_SECONDS_MAX)"},{"line_number":327,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f14d9d3c","line":324,"in_reply_to":"3fa7e38b_722f36a6","updated":"2020-01-14 11:57:32.000000000","message":"I\u0027ll fix this","commit_id":"2985ad6f14e9a195152979846a196a720b5af735"}]}