)]}'
{"oslo_messaging/rpc/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6fbedf2f6b1b896b3c007d9c6709d4dcc86959b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        except rpc_dispatcher.NoSuchMethod as e:"},{"line_number":170,"context_line":"            # current sys.exc_info() content can be overridden"},{"line_number":171,"context_line":"            # by another exception raised by a log handler during"},{"line_number":172,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":173,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":174,"context_line":"            if not e.method.endswith(\u0027_ignore_errors\u0027):"},{"line_number":175,"context_line":"                LOG.exception(\u0027Exception during message handling\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_454b3ab0","line":172,"updated":"2019-12-23 12:42:45.000000000","message":"Can you move this comment above the previous \u0027sys.exc_info\u0027 since it\u0027s in a rather odd place now","commit_id":"79bf507877b67e19dd77bd7a796aadd86c45dcf7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0012cfdf840712ac080485551b9b4c3b041c069b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        except rpc_dispatcher.NoSuchMethod as e:"},{"line_number":170,"context_line":"            # current sys.exc_info() content can be overridden"},{"line_number":171,"context_line":"            # by another exception raised by a log handler during"},{"line_number":172,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":173,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":174,"context_line":"            if not e.method.endswith(\u0027_ignore_errors\u0027):"},{"line_number":175,"context_line":"                LOG.exception(\u0027Exception during message handling\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_25bdde66","line":172,"in_reply_to":"3fa7e38b_454b3ab0","updated":"2019-12-23 12:48:22.000000000","message":"you mean before #167?","commit_id":"79bf507877b67e19dd77bd7a796aadd86c45dcf7"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9c8ee111c27516151ef90ecc3a2374e8218c091c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        except rpc_dispatcher.NoSuchMethod as e:"},{"line_number":173,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":174,"context_line":"            if not e.method.endswith(\u0027_ignore_errors\u0027):"},{"line_number":175,"context_line":"                LOG.exception(\u0027Exception during message handling\u0027)"},{"line_number":176,"context_line":"        except Exception:"},{"line_number":177,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":178,"context_line":"            LOG.exception(\u0027Exception during message handling\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c35b7b52","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":66},"updated":"2020-01-22 11:56:47.000000000","message":"I\u0027d probably still logged smth on debug level for such \u0027*_ignore_errors\u0027 methods","commit_id":"5d5b537a5bedc998e058d495bfa32d40fdf433aa"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ca1f66ab5cd5017d1af38c728d76cefa9d728761","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        except rpc_dispatcher.NoSuchMethod as e:"},{"line_number":173,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":174,"context_line":"            if not e.method.endswith(\u0027_ignore_errors\u0027):"},{"line_number":175,"context_line":"                LOG.exception(\u0027Exception during message handling\u0027)"},{"line_number":176,"context_line":"        except Exception:"},{"line_number":177,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":178,"context_line":"            LOG.exception(\u0027Exception during message handling\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1390ef95","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":66},"in_reply_to":"3fa7e38b_c35b7b52","updated":"2020-01-23 11:38:12.000000000","message":"Done","commit_id":"5d5b537a5bedc998e058d495bfa32d40fdf433aa"}]}
