)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e73335ba03b11f99fef95acc0c3c7c3832246a7c","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            sock.settimeout(timeout)"},{"line_number":928,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":929,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":930,"context_line":"                TCP_USER_TIMEOUT \u003d 18"},{"line_number":931,"context_line":"                try:"},{"line_number":932,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":933,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_46973a3b","line":930,"updated":"2020-06-03 15:15:06.000000000","message":"Can\u0027t we just get this from the socket module now? It was added in 3.6 and we don\u0027t support anything lower than that now.","commit_id":"de751c667f865dbfc2878d613ada34960cae47bb"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1c2beb9bf8fc65e281cb091ba132d5c7b746a8e3","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            sock.settimeout(timeout)"},{"line_number":928,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":929,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":930,"context_line":"                TCP_USER_TIMEOUT \u003d 18"},{"line_number":931,"context_line":"                try:"},{"line_number":932,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":933,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e5957641","line":930,"in_reply_to":"ff570b3c_1fdf2066","updated":"2020-06-05 16:02:40.000000000","message":"I\u0027m not sure it matters. This code block is excluded on Windows and OSX, so we don\u0027t care if it\u0027s supported. All I\u0027m suggesting is that we stop defining this constant ourselves and use it from the socket module instead.\n\nIf someone wants to enable this on Windows/OSX then they\u0027re welcome to propose that change.","commit_id":"de751c667f865dbfc2878d613ada34960cae47bb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c6b33dfae40738abb73746834ab4384cd777177d","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            sock.settimeout(timeout)"},{"line_number":928,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":929,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":930,"context_line":"                TCP_USER_TIMEOUT \u003d 18"},{"line_number":931,"context_line":"                try:"},{"line_number":932,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":933,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_1fdf2066","line":930,"in_reply_to":"ff570b3c_46973a3b","updated":"2020-06-05 11:49:01.000000000","message":"This is what I was thinking about in the first time I implemented these changes but I wondering if OSX and windows support it... I guess yes since this is part of the stdlib now. I mean the documentation isn\u0027t clear to me on this point [1] and I\u0027m not sure if the support is global or just restricted to unix platforms.\n\nThoughts?\n\n[1] https://docs.python.org/3.8/library/socket.html#constants","commit_id":"de751c667f865dbfc2878d613ada34960cae47bb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"121cf2d790ace6ce391ca2f4189cb2452070eb12","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            sock.settimeout(timeout)"},{"line_number":928,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":929,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":930,"context_line":"                TCP_USER_TIMEOUT \u003d 18"},{"line_number":931,"context_line":"                try:"},{"line_number":932,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":933,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d0a3d29c","line":930,"in_reply_to":"ff570b3c_e5957641","updated":"2020-06-05 17:07:06.000000000","message":"Ack make sense, thanks Ben","commit_id":"de751c667f865dbfc2878d613ada34960cae47bb"}]}