)]}'
{"oslo_messaging/conffixture.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c3e9f627c3e97ca1235e02f834f108261c18b914","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                     \u0027amqp1_opts\u0027, \u0027oslo_messaging_amqp\u0027)"},{"line_number":62,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.rpc.client\u0027, \u0027_client_opts\u0027)"},{"line_number":63,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.transport\u0027, \u0027_transport_opts\u0027)"},{"line_number":64,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.rpc.dispatcher\u0027, \u0027_dispatcher_opts\u0027)"},{"line_number":65,"context_line":"        _import_opts(self.conf,"},{"line_number":66,"context_line":"                     \u0027oslo_messaging.notify.notifier\u0027,"},{"line_number":67,"context_line":"                     \u0027_notifier_opts\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_269718ee","line":64,"range":{"start_line":64,"start_character":80,"end_line":64,"end_character":84},"updated":"2020-07-06 16:19:00.000000000","message":"This is going to cause a pep8 failure.","commit_id":"2f82334a6f410836a58913a54146e2e5eb8ce2c8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7bacf7401222dcd7e57e3b89087e5e45d486022c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                     \u0027amqp1_opts\u0027, \u0027oslo_messaging_amqp\u0027)"},{"line_number":62,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.rpc.client\u0027, \u0027_client_opts\u0027)"},{"line_number":63,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.transport\u0027, \u0027_transport_opts\u0027)"},{"line_number":64,"context_line":"        _import_opts(self.conf, \u0027oslo_messaging.rpc.dispatcher\u0027, \u0027_dispatcher_opts\u0027)"},{"line_number":65,"context_line":"        _import_opts(self.conf,"},{"line_number":66,"context_line":"                     \u0027oslo_messaging.notify.notifier\u0027,"},{"line_number":67,"context_line":"                     \u0027_notifier_opts\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a1667254","line":64,"updated":"2020-07-06 16:47:13.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"2f82334a6f410836a58913a54146e2e5eb8ce2c8"}],"oslo_messaging/rpc/dispatcher.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3d32dbc9d12e7e61bcf15f69cf78cce752a693c4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_messaging import serializer as msg_serializer"},{"line_number":30,"context_line":"from oslo_messaging import server as msg_server"},{"line_number":31,"context_line":"from oslo_messaging import target as msg_target"},{"line_number":32,"context_line":"from oslo_config import cfg"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_dispatcher_opts \u003d ["},{"line_number":35,"context_line":"    cfg.BoolOpt(\u0027rpc_ping_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c4d446ec","line":32,"updated":"2020-06-12 20:47:08.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_messaging.target, oslo_config.cfg)","commit_id":"5780b6107c5186179cdbb48cb189bb875e478d45"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"83974ef6e191799af20b0bb20ec9a1fa883d3777","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Add ping endpoint if enabled in config"},{"line_number":183,"context_line":"        if cfg.CONF.rpc_ping_enabled:"},{"line_number":184,"context_line":"            self.endpoints +\u003d [PingEndpoint()]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.serializer \u003d serializer or msg_serializer.NoOpSerializer()"},{"line_number":187,"context_line":"        self._default_target \u003d msg_target.Target()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_2a0cafa3","line":184,"updated":"2020-06-23 11:28:40.000000000","message":".extends() or simply .append()","commit_id":"2eec739bddad20bb0599c393033aba9eada5c832"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"e6fd653e1b25442039b4085701832b5662d52b3a","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Add ping endpoint if enabled in config"},{"line_number":183,"context_line":"        if cfg.CONF.rpc_ping_enabled:"},{"line_number":184,"context_line":"            self.endpoints +\u003d [PingEndpoint()]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.serializer \u003d serializer or msg_serializer.NoOpSerializer()"},{"line_number":187,"context_line":"        self._default_target \u003d msg_target.Target()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_c61da0be","line":184,"in_reply_to":"bf51134e_2a0cafa3","updated":"2020-07-02 15:32:22.000000000","message":"done","commit_id":"2eec739bddad20bb0599c393033aba9eada5c832"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"88842e68c6dacac5d7039899f6891c648d00412f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_messaging import serializer as msg_serializer"},{"line_number":30,"context_line":"from oslo_messaging import server as msg_server"},{"line_number":31,"context_line":"from oslo_messaging import target as msg_target"},{"line_number":32,"context_line":"from oslo_config import cfg"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_dispatcher_opts \u003d ["},{"line_number":35,"context_line":"    cfg.BoolOpt(\u0027rpc_ping_enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_0cf4d95a","line":32,"updated":"2020-07-02 17:20:19.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_messaging.target, oslo_config.cfg)","commit_id":"1905255fbbbbf77511c56543be9cc7ec2543f554"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c3e9f627c3e97ca1235e02f834f108261c18b914","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import threading"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo_utils import eventletutils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_messaging import _utils as utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a68208a4","line":26,"updated":"2020-07-06 16:19:00.000000000","message":"Extra line break should be removed.","commit_id":"2f82334a6f410836a58913a54146e2e5eb8ce2c8"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"81db3827d1bcac7f94a2a5d70ea0b1feeac5ed90","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class PingEndpoint(object):"},{"line_number":56,"context_line":"    def ping(self, ctxt, **kwargs):"},{"line_number":57,"context_line":"        return \u0027pong\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d22a5d2a","line":56,"updated":"2020-08-17 20:03:40.000000000","message":"As noted by the Nova folks, the endpoint method name \"ping\" will collide with their own version of \"ping\".\n\n\"ping\" is a good name, but it\u0027s so good that it\u0027s probably in use for other projects as well.\n\nLet\u0027s reserve endpoint method names that start with \"oslo_\" and see if anyone yelps.\n\nI\u0027d recommend re-naming this to \"oslo_rpc_server_ping\".  Yeah a bit wordy but less likely to collide with existing applications.","commit_id":"4f52bca1e0b2fc12e3c1b625d00bc5b18b206a92"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"34600ef9392af6f32474f2a7d90fe84acc0c7f96","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class PingEndpoint(object):"},{"line_number":56,"context_line":"    def ping(self, ctxt, **kwargs):"},{"line_number":57,"context_line":"        return \u0027pong\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b05997ff","line":56,"in_reply_to":"9f560f44_d22a5d2a","updated":"2020-08-18 13:07:09.000000000","message":"Done","commit_id":"4f52bca1e0b2fc12e3c1b625d00bc5b18b206a92"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"81db3827d1bcac7f94a2a5d70ea0b1feeac5ed90","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        cfg.CONF.register_opts(_dispatcher_opts)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        for ep in endpoints:"},{"line_number":171,"context_line":"            target \u003d getattr(ep, \u0027target\u0027, None)"},{"line_number":172,"context_line":"            if target and not isinstance(target, msg_target.Target):"},{"line_number":173,"context_line":"                errmsg \u003d \"\u0027target\u0027 is a reserved Endpoint attribute used\" + \\"},{"line_number":174,"context_line":"                         \" for namespace and version filtering.  It must\" + \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_52ebedda","line":171,"updated":"2020-08-17 20:03:40.000000000","message":"Add an additional check in this loop for the new \"oslo_rpc_server_ping\" method.  If it exists log an error indicating that method names starting with \"oslo_\" are reserved and force CONF.rpc_ping_enabled to False.\n\nProbably overkill but better to be safe than have stuff fail silently.","commit_id":"4f52bca1e0b2fc12e3c1b625d00bc5b18b206a92"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"34600ef9392af6f32474f2a7d90fe84acc0c7f96","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        cfg.CONF.register_opts(_dispatcher_opts)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        for ep in endpoints:"},{"line_number":171,"context_line":"            target \u003d getattr(ep, \u0027target\u0027, None)"},{"line_number":172,"context_line":"            if target and not isinstance(target, msg_target.Target):"},{"line_number":173,"context_line":"                errmsg \u003d \"\u0027target\u0027 is a reserved Endpoint attribute used\" + \\"},{"line_number":174,"context_line":"                         \" for namespace and version filtering.  It must\" + \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f072ef7b","line":171,"in_reply_to":"9f560f44_52ebedda","updated":"2020-08-18 13:07:09.000000000","message":"Done","commit_id":"4f52bca1e0b2fc12e3c1b625d00bc5b18b206a92"}],"oslo_messaging/tests/rpc/test_dispatcher.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c3e9f627c3e97ca1235e02f834f108261c18b914","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                             client_timeout\u003d0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        res \u003d dispatcher.dispatch(incoming)"},{"line_number":228,"context_line":"        self.assertEqual(res, \u0027pong\u0027)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class TestSerializer(test_utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_46bdec66","line":228,"range":{"start_line":228,"start_character":25,"end_line":228,"end_character":36},"updated":"2020-07-06 16:19:00.000000000","message":"assertEqual arguments should actually be in the order (EXPECTED, ACTUAL).","commit_id":"2f82334a6f410836a58913a54146e2e5eb8ce2c8"}]}