)]}'
{"requirements.txt":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2f23c9a0d0cf75e6381743799b9fee1f857f888f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_085be12d","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"updated":"2020-06-19 16:12:26.000000000","message":"I\u0027m still a bit hesitant to add this restriction to openstack/requirements repository, as kombu is used in other projects, too, but I don\u0027t see broken tests elsewhere.\n\nMeanwhile I\u0027ve identified the patch that causing the issue [1], which is partly reverted in unreleased part of kombu, and I tested oslo.messaging with that and unfortunately the tests are still broken with that as well.\n\n[1] https://github.com/celery/kombu/pull/1193/commits/398aa5b8cd1fe1fc189ab35a2cb0bececf51bf37","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0984bc6b36768a852172398df6782e3f78d2c578","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_0039dca2","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"in_reply_to":"bf51134e_00eb9c12","updated":"2020-06-22 15:48:45.000000000","message":"+1","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ae6c05becc96f01a0756633a1fba5be4a6266165","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_63c42292","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"in_reply_to":"bf51134e_00eb9c12","updated":"2020-06-22 16:28:52.000000000","message":"Done","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b248b5c861c402d7a22f84d845edadd65375fc13","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_40cab4a0","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"in_reply_to":"bf51134e_085be12d","updated":"2020-06-22 15:47:48.000000000","message":"Can you add few words and the link above to the commit message to bring the current context into the git history.","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9c165b6de3992dd52a3dc1dc5656e694ca5cd1af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_00eb9c12","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"in_reply_to":"bf51134e_085be12d","updated":"2020-06-22 15:46:43.000000000","message":"Sure, but given how widely used oslo.messaging is if it doesn\u0027t work with a given version of kombu chances are deployers don\u0027t want to be using that version anyway. I think this is fair to add to global-requirements until there is a fix in kombu.","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"ae6c05becc96f01a0756633a1fba5be4a6266165","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# rabbit driver is the default"},{"line_number":25,"context_line":"# we set the amqp version to ensure heartbeat works"},{"line_number":26,"context_line":"amqp\u003e\u003d2.5.2 # BSD"},{"line_number":27,"context_line":"kombu\u003c\u003d4.6.8,\u003e\u003d4.6.6 # BSD"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# middleware"},{"line_number":30,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bf51134e_c3bd2e03","line":27,"range":{"start_line":27,"start_character":5,"end_line":27,"end_character":12},"in_reply_to":"bf51134e_40cab4a0","updated":"2020-06-22 16:28:52.000000000","message":"Done","commit_id":"82a9e98e31e821e2179245ed655cf729a91c6a0c"}]}