)]}'
{".zuul.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b3e7bfbfdc3039064c6a9442c8e5151c0a95cfd","unresolved":true,"context_lines":[{"line_number":227,"context_line":"      - release-notes-jobs-python3"},{"line_number":228,"context_line":"    check:"},{"line_number":229,"context_line":"      jobs:"},{"line_number":230,"context_line":"        - oslo.messaging-tox-py27-func-rabbit"},{"line_number":231,"context_line":"        - oslo.messaging-tox-py27-func-amqp1:"},{"line_number":232,"context_line":"            voting: false"},{"line_number":233,"context_line":"        - oslo.messaging-tox-py27-func-kafka:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b1c234e1_c73546d1","line":230,"updated":"2021-03-15 10:50:39.000000000","message":"This wasn\u0027t in the original and it\u0027s not clear to me why you added it here. Was this intentional?","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ed45297ced0a93d7a8c207cd08d29448340cf47","unresolved":true,"context_lines":[{"line_number":227,"context_line":"      - release-notes-jobs-python3"},{"line_number":228,"context_line":"    check:"},{"line_number":229,"context_line":"      jobs:"},{"line_number":230,"context_line":"        - oslo.messaging-tox-py27-func-rabbit"},{"line_number":231,"context_line":"        - oslo.messaging-tox-py27-func-amqp1:"},{"line_number":232,"context_line":"            voting: false"},{"line_number":233,"context_line":"        - oslo.messaging-tox-py27-func-kafka:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"32832bde_736e09b7","line":230,"in_reply_to":"2427b961_49e01996","updated":"2021-03-15 11:51:23.000000000","message":"Cool. Can you undo this please?","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e089d607ea03e93fd858c72b14d80607dca330f0","unresolved":true,"context_lines":[{"line_number":227,"context_line":"      - release-notes-jobs-python3"},{"line_number":228,"context_line":"    check:"},{"line_number":229,"context_line":"      jobs:"},{"line_number":230,"context_line":"        - oslo.messaging-tox-py27-func-rabbit"},{"line_number":231,"context_line":"        - oslo.messaging-tox-py27-func-amqp1:"},{"line_number":232,"context_line":"            voting: false"},{"line_number":233,"context_line":"        - oslo.messaging-tox-py27-func-kafka:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2427b961_49e01996","line":230,"in_reply_to":"b1c234e1_c73546d1","updated":"2021-03-15 11:45:49.000000000","message":"Good catch my bad, I rebased things during previous PS I surely made a mistake during my rebase.","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"}],"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"05f167cfc64a5adaa9a0a15c5cda75d968bce763","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I2ae53340783e4044dab58035bc0992dc08145b53"},{"line_number":29,"context_line":"Related-bug: #1789177"},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/#/c/753239"},{"line_number":31,"context_line":"(cherry picked from commit 196fa877a90d7eb0f82ec9e1c194eef3f98fc0b1)"},{"line_number":32,"context_line":"(cherry picked from commit 0a432c7fb107d04f7a41199fe9a8c4fbd344d009)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_60587ff8","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":49},"updated":"2020-10-09 10:32:49.000000000","message":"Should be removed else these changes couldn\u0027t be merged","commit_id":"d912cd4c35678d864e2b803813dccd2e63714764"}],"oslo_messaging/tests/functional/test_rabbitmq.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b3e7bfbfdc3039064c6a9442c8e5151c0a95cfd","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self._test_failover_scenario()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_failover_scenario_enable_cancel_on_failover(self):"},{"line_number":45,"context_line":"        self.skipTest(\"Skipping failover tests on stable/train\")"},{"line_number":46,"context_line":"        self._test_failover_scenario(enable_cancel_on_failover\u003dTrue)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _test_failover_scenario(self, enable_cancel_on_failover\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"609eb988_d08cbbbd","line":45,"updated":"2021-03-15 10:50:39.000000000","message":"This isn\u0027t in the original either.\n\nLater: Oh, I see you called it out in the commit message but you haven\u0027t explained why. Shouldn\u0027t this work on stable/train also?","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e089d607ea03e93fd858c72b14d80607dca330f0","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self._test_failover_scenario()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_failover_scenario_enable_cancel_on_failover(self):"},{"line_number":45,"context_line":"        self.skipTest(\"Skipping failover tests on stable/train\")"},{"line_number":46,"context_line":"        self._test_failover_scenario(enable_cancel_on_failover\u003dTrue)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _test_failover_scenario(self, enable_cancel_on_failover\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"acccc5ad_b5db8359","line":45,"in_reply_to":"609eb988_d08cbbbd","updated":"2021-03-15 11:45:49.000000000","message":"Yes the pifpaf version used on train have issue with sigterm. This problem broken our gates.\n\nI already signaled this problem several months ago on openstack/requirements [1] however I didn\u0027t get real answer about this topic and this is stuck since...\n\nI also brought this topic many times during our meetings this cycle and we agreed (ken and myself) to skip this functional test to avoid to fall into the sigterm problem.\n\nI\u0027ll update the commit message to properly reflect that point\n\n[1] https://review.opendev.org/c/openstack/requirements/+/753239","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ed45297ced0a93d7a8c207cd08d29448340cf47","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self._test_failover_scenario()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_failover_scenario_enable_cancel_on_failover(self):"},{"line_number":45,"context_line":"        self.skipTest(\"Skipping failover tests on stable/train\")"},{"line_number":46,"context_line":"        self._test_failover_scenario(enable_cancel_on_failover\u003dTrue)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _test_failover_scenario(self, enable_cancel_on_failover\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"c76962ae_45e142f1","line":45,"in_reply_to":"acccc5ad_b5db8359","updated":"2021-03-15 11:51:23.000000000","message":"Ah, great. Can you note this in the commit message? Something like the below will do just fine\n\n  Changes:\n    oslo_messaging/tests/functional/test_rabbitmq.py\n\n  NOTE(hberaud): The new functional tests are disable due to issues with the version\n  of pifpaf used here, as discussed at https://github.com/jd/pifpaf/pull/124.","commit_id":"67ff1e402d77ace007b5caf37d516003296f4f88"}]}