)]}'
{"oslo_messaging/exceptions.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3e6a23b7193cfea5adc902a727b148c2a2d55ce7","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"253fafa4_bd656295","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"updated":"2021-05-19 09:50:33.000000000","message":"Why not doing the same that was did in the original patch and import amqp.exceptions directly in oslo_messaging/_drivers/impl_rabbit.py?","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"6e8b2bc88d4395a355d19174183d1b2cfac317a2","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"f29ffc5d_1af1d0e7","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"253fafa4_bd656295","updated":"2021-08-04 07:16:14.000000000","message":"sorry for the very late reply... (seems I have missed the email..)\nthe reason to do this is that the originally patch does not work for python2... so I have to do  work around it...","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a404e9feb494d6247735ecb9ae23d9cb1646cf","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2906fa6_eef9bdcd","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"3f017647_acaa27e3","updated":"2021-08-10 12:08:36.000000000","message":"Sure.\n\nYou just have to run the `tox` command without arguments.\n\nNotice that this is a flaky test, sometime it pass, sometime it fail...\nI\u0027m not able to reproduce it all the time.\n\nAll my latest tries were successful.\n\nLet me know if you face the same problem.","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"38a2ff93c8c2115b87441a894d36818b3e35282d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcbe5057_2bde5cf8","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"794d9b0a_94a36a70","updated":"2021-08-11 07:04:28.000000000","message":"Yes, I test this patch (`git review -d 757424 \u0026\u0026 tox`).","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"9f935d40cf028c0e341c32f748fa45fa2a2223c5","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"794d9b0a_94a36a70","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"a2906fa6_eef9bdcd","updated":"2021-08-10 13:27:48.000000000","message":"Are you testing this branch?","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"5d95968665f8424bab4914507ce0a9be3e0ef42b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f017647_acaa27e3","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"f1197555_abcad642","updated":"2021-08-10 11:33:12.000000000","message":"hmm.. could you please tell me how to reproduce this ? I may be able to test it locally..","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9b1a8ea19e329486e453911705b763459d52e9a6","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        self.message \u003d message"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ConnectionForced \u003d amqp.ConnectionForced"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1197555_abcad642","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":40},"in_reply_to":"f29ffc5d_1af1d0e7","updated":"2021-08-05 07:56:16.000000000","message":"Thank you.\n\nYes now I remember the other patch and I see the problem, however I don\u0027t understand why it failed to import this module with tox and it successed within a python interpreter...\n\nHowever, locally I still face issue even with this patch. When I run tox at a moment I\u0027m facing a flaky CI. Indeed either it stay stuck with a socket connection problem or it finish with the traceback below. This one seems related to these changes.\n\nI need to do more tests before approving this patch.\n\nDid you experienced similar errors locally?\n\n```\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"oslo_messaging/tests/drivers/test_impl_rabbit.py\", line 89, in test_test_heartbeat_sent_connection_fail\n        info\u003d\u0027A recoverable connection/channel error occurred, \u0027\n      File \"/home/hberaud/dev/redhat/upstream/openstack/oslo/oslo.messaging/.tox/py27/lib/python2.7/site-packages/mock/mock.py\", line 1330, in patched\n        return func(*args, **keywargs)\n      File \"oslo_messaging/tests/drivers/test_impl_rabbit.py\", line 77, in _do_test_heartbeat_sent\n        self.assertEqual(2, fake_ensure_connection.call_count)\n      File \"/home/hberaud/dev/redhat/upstream/openstack/oslo/oslo.messaging/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual\n        self.assertThat(observed, matcher, message)\n      File \"/home/hberaud/dev/redhat/upstream/openstack/oslo/oslo.messaging/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat\n        raise mismatch_error\n    testtools.matchers._impl.MismatchError: 2 !\u003d 1\n```","commit_id":"efa71ef78adbaea61532499b1dc6dcc8f82c8102"}]}