)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"170599df2d5d5f145b16f69252599a6f8faa6add","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"        min_size \u003d conf.oslo_messaging_rabbit.conn_pool_min_size"},{"line_number":1373,"context_line":"        if max_size \u003c min_size:"},{"line_number":1374,"context_line":"            raise RuntimeError("},{"line_number":1375,"context_line":"                f\"rpc_conn_pool_size: {max_size} must be greater than \""},{"line_number":1376,"context_line":"                f\"or equal to conn_pool_min_size: {min_size}\")"},{"line_number":1377,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"},{"line_number":1378,"context_line":""},{"line_number":1379,"context_line":"        connection_pool \u003d pool.ConnectionPool("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_35f92380","line":1376,"range":{"start_line":1375,"start_character":0,"end_line":1376,"end_character":62},"updated":"2020-10-23 12:16:35.000000000","message":"fstring should be avoided on train, we still support py2.7 and py3.5 who aren\u0027t compatible with this syntaxe.","commit_id":"d7f9d8d42d98964ef8cee4424dfa26d83aa5ad1f"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"410ccc0d8ba353bf0f5fb6affe67cc7af940fe4e","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"        min_size \u003d conf.oslo_messaging_rabbit.conn_pool_min_size"},{"line_number":1373,"context_line":"        if max_size \u003c min_size:"},{"line_number":1374,"context_line":"            raise RuntimeError("},{"line_number":1375,"context_line":"                f\"rpc_conn_pool_size: {max_size} must be greater than \""},{"line_number":1376,"context_line":"                f\"or equal to conn_pool_min_size: {min_size}\")"},{"line_number":1377,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"},{"line_number":1378,"context_line":""},{"line_number":1379,"context_line":"        connection_pool \u003d pool.ConnectionPool("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_3503e344","line":1376,"range":{"start_line":1375,"start_character":0,"end_line":1376,"end_character":62},"in_reply_to":"3f65232a_35f92380","updated":"2020-10-23 12:32:50.000000000","message":"Yes sorry you\u0027re right. I forget to do that. I will fix it.","commit_id":"d7f9d8d42d98964ef8cee4424dfa26d83aa5ad1f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f2f47387efc53cb0193e51b3395850be5dfbd536","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"        # the pool configuration properties"},{"line_number":1371,"context_line":"        max_size \u003d conf.oslo_messaging_rabbit.rpc_conn_pool_size"},{"line_number":1372,"context_line":"        min_size \u003d conf.oslo_messaging_rabbit.conn_pool_min_size"},{"line_number":1373,"context_line":"        text \u003d \u0027rpc_conn_pool_size: {max_size} must be greater than\u0027 \\"},{"line_number":1374,"context_line":"               \u0027 or equal to conn_pool_min_size: {min_size}\u0027.format("},{"line_number":1375,"context_line":"                    max_size\u003dmax_size, min_size\u003dmin_size)"},{"line_number":1376,"context_line":"        if max_size \u003c min_size:"},{"line_number":1377,"context_line":"            raise RuntimeError(text)"},{"line_number":1378,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_45b85f75","line":1375,"range":{"start_line":1373,"start_character":8,"end_line":1375,"end_character":57},"updated":"2020-10-26 10:26:19.000000000","message":"Can\u0027t we keep that under the following condition?\n\nIt\u0027s only used there.","commit_id":"658f4e639e9a6c0e555fd98f71f51ec605f5e8bb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cc411c48886259b662b998bc0f8195b74543cf3e","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"        min_size \u003d conf.oslo_messaging_rabbit.conn_pool_min_size"},{"line_number":1373,"context_line":"        if max_size \u003c min_size:"},{"line_number":1374,"context_line":"            text \u003d \u0027rpc_conn_pool_size: {max_size} must be greater than\u0027 \\"},{"line_number":1375,"context_line":"                   \u0027 or equal to conn_pool_min_size: {min_size}\u0027.format("},{"line_number":1376,"context_line":"                        max_size\u003dmax_size, min_size\u003dmin_size)"},{"line_number":1377,"context_line":"            raise RuntimeError(text)"},{"line_number":1378,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"},{"line_number":1379,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_a08fa1ca","line":1376,"range":{"start_line":1375,"start_character":72,"end_line":1376,"end_character":61},"updated":"2020-10-26 12:05:47.000000000","message":"pep8 issue:\n\n```\n2020-10-26 10:42:16.699109 | ubuntu-bionic | ./oslo_messaging/_drivers/impl_rabbit.py:1376:25: E126 continuation line over-indented for hanging indent\n2020-10-26 10:42:16.699219 | ubuntu-bionic |                         max_size\u003dmax_size, min_size\u003dmin_size)\n```\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_132/759410/3/check/openstack-tox-pep8/132f962/job-output.txt","commit_id":"d8ebaf459ec707a03131aa829259ce34f14684a3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f7a6f880dfa9298a856daa8d8bd902cb492ec1e9","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"        if max_size \u003c min_size:"},{"line_number":1374,"context_line":"            text \u003d \u0027rpc_conn_pool_size: {max_size} must be greater than\u0027 \\"},{"line_number":1375,"context_line":"                   \u0027 or equal to conn_pool_min_size: {min_size}\u0027.format("},{"line_number":1376,"context_line":"                        max_size\u003dmax_size, min_size\u003dmin_size)"},{"line_number":1377,"context_line":"            raise RuntimeError(text)"},{"line_number":1378,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"},{"line_number":1379,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_9b19367b","line":1376,"updated":"2020-10-26 12:24:35.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"d8ebaf459ec707a03131aa829259ce34f14684a3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4696d60ecaf84fefbda793b38bbb9864201a9ddf","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"        if max_size \u003c min_size:"},{"line_number":1374,"context_line":"            text \u003d \u0027rpc_conn_pool_size: {max_size} must be greater than\u0027 \\"},{"line_number":1375,"context_line":"                   \u0027 or equal to conn_pool_min_size: {min_size}\u0027.format("},{"line_number":1376,"context_line":"                   max_size\u003dmax_size, min_size\u003dmin_size)"},{"line_number":1377,"context_line":"            raise RuntimeError(text)"},{"line_number":1378,"context_line":"        ttl \u003d conf.oslo_messaging_rabbit.conn_pool_ttl"},{"line_number":1379,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_f9d98f22","line":1376,"range":{"start_line":1376,"start_character":19,"end_line":1376,"end_character":56},"updated":"2020-10-28 09:26:36.000000000","message":"pep8 still fails:\n\n```\n2020-10-28 09:25:01.985156 | ubuntu-bionic | ./oslo_messaging/_drivers/impl_rabbit.py:1376:20: E122 continuation line missing indentation or outdented\n2020-10-28 09:25:01.985250 | ubuntu-bionic |                    max_size\u003dmax_size, min_size\u003dmin_size)\n```","commit_id":"9721af8f6883834f017b41bedd6c98728d31c67d"}]}
