)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"238d0ea45463d724e205824cb3db0f97e8b8eeaa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027kombu_connection_timeout\u0027 config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"kombu_connection_timeout is used during connection initializaion."},{"line_number":10,"context_line":"It\u0027s useful if RabbitMQ is unavailable and we don\u0027t want to wait"},{"line_number":11,"context_line":"until RabbitMQ will be available."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I04f1c9ee1239eaf7d4ad5c0fb7939160458c4656"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_64a8bd76","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"updated":"2020-11-06 08:28:42.000000000","message":"Could be useful to add this sentence in the helping message that you added.","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"17ab891950c94d4338844af005b017e01bea0d16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87dc95b0_6ebe3aaf","updated":"2024-01-22 10:13:14.000000000","message":"Any update here?","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"37cdf82260f852b96b09c3235995b729f7001dac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96da152c_0a79673d","updated":"2022-02-08 13:50:21.000000000","message":"Any update?","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6989ce9ca46602a67fcccc15f0cbefb4c9c558e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f87c7fc_9ddea146","updated":"2024-01-28 09:29:08.000000000","message":"This chage has impact on client and we have to make sure all clients properly handle the case where ensure_connection fails. So I think it\u0027s a bit risky and I doubt the immediate benefit of the config option.\n\nOn the other hand, we may have to set the timeout appropriately according to timeout passed to send. I\u0027m still digging the code path but I guess we don\u0027t pass the given timeout properly for connection establishment ?","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"8b38cf42b68678f1bb0f5ec77afc4648f8c55453","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                      \u0027AMQP consumer cancel notification.\u0027),"},{"line_number":106,"context_line":"    cfg.IntOpt(\u0027kombu_connection_timeout\u0027,"},{"line_number":107,"context_line":"               default\u003dNone,"},{"line_number":108,"context_line":"               help\u003d\u0027AMPQ connection timeout for new connections.\u0027),"},{"line_number":109,"context_line":"    cfg.StrOpt(\u0027kombu_compression\u0027,"},{"line_number":110,"context_line":"               help\u003d\"EXPERIMENTAL: Possible values are: gzip, bz2. If not \""},{"line_number":111,"context_line":"                    \"set compression will not be used. This option may not \""}],"source_content_type":"text/x-python","patch_set":2,"id":"35dc2944_66976879","line":108,"updated":"2021-04-26 16:51:06.000000000","message":"spelling nit: \"AMQP\"","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"8b38cf42b68678f1bb0f5ec77afc4648f8c55453","unresolved":true,"context_lines":[{"line_number":479,"context_line":"            driver_conf.heartbeat_timeout_threshold"},{"line_number":480,"context_line":"        self.heartbeat_rate \u003d driver_conf.heartbeat_rate"},{"line_number":481,"context_line":"        self.kombu_reconnect_delay \u003d driver_conf.kombu_reconnect_delay"},{"line_number":482,"context_line":"        self.timeout \u003d driver_conf.kombu_connection_timeout"},{"line_number":483,"context_line":"        self.amqp_durable_queues \u003d driver_conf.amqp_durable_queues"},{"line_number":484,"context_line":"        self.amqp_auto_delete \u003d driver_conf.amqp_auto_delete"},{"line_number":485,"context_line":"        self.ssl \u003d driver_conf.ssl"}],"source_content_type":"text/x-python","patch_set":2,"id":"f7344830_55eed2fd","line":482,"updated":"2021-04-26 16:51:06.000000000","message":"we\u0027ve got a few timeout values in the rabbit driver.  It would be great to give this attribute a more specific name, like \"kombu_connect_timeout\" or something similar.","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"8b38cf42b68678f1bb0f5ec77afc4648f8c55453","unresolved":true,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        self._set_current_channel(None)"},{"line_number":741,"context_line":"        self.connection.ensure_connection(errback\u003don_error,"},{"line_number":742,"context_line":"                                          timeout\u003dself.timeout)"},{"line_number":743,"context_line":"        self._set_current_channel(self.connection.channel())"},{"line_number":744,"context_line":"        self.set_transport_socket_timeout()"},{"line_number":745,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f37f0817_68eda088","line":742,"updated":"2021-04-26 16:51:06.000000000","message":"How does this behave when the timeout occurs?\n\nDoes the on_error() callback get invoked, or is an exception propagated?\n\nWe want to be sure that any logging that occurs or any exceptions that are thrown are well understood by anyone using the API.","commit_id":"5c9b55807a9d13fd18f0b0460a307f93e03bb655"}]}