)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"1519443b6a719b8b85b8c6a0e524dbf8c9c59201","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"295500b0_2c6bdbfc","updated":"2022-09-26 07:16:25.000000000","message":"recheck","commit_id":"9b038807c572f8d0d2ba90ebf8ba7b9d8618ef4c"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"7dc76b9134a604d0793f59251d42f81111aba5d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2fc9838_c181f244","updated":"2022-09-26 07:19:44.000000000","message":"recheck","commit_id":"9b038807c572f8d0d2ba90ebf8ba7b9d8618ef4c"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"e0ed3b47477782245afe14f72e4276f51055f39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31e5866d_5820e011","in_reply_to":"295500b0_2c6bdbfc","updated":"2022-10-09 09:08:34.000000000","message":"Done","commit_id":"9b038807c572f8d0d2ba90ebf8ba7b9d8618ef4c"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"728ba1d476448ef8f58eb7bedecb41ada1f7895f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab345e27_814f8962","updated":"2022-10-09 05:02:10.000000000","message":"Changes are updated","commit_id":"900ca87470dce194a2af39e810b50608e4079f05"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"4f07f47c0d092849752965fc2b200bf0f8817358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4425fdb6_36fa8389","updated":"2022-10-09 05:34:31.000000000","message":"recheck","commit_id":"900ca87470dce194a2af39e810b50608e4079f05"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4e1850d9b3bd7b258e0c707da69e924ef2c8dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8382bdda_58ea9eac","updated":"2022-10-11 08:19:54.000000000","message":"Almost there!","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7b2b9b7ec8f0ee312ba868c9637e3a76080a17d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bab8545c_a25e2b83","updated":"2022-10-11 14:34:51.000000000","message":"Please can you add related unit tests.\nI made some local tests with the scenario you described in your launchpad bug I face issues with the parse method of the `oslo_messaging/transport.py` module [1].\n\nIndeed, with or without your changes I face the following issue:\n\n```\nTraceback (most recent call last):                                                                                                                                                                                                         \n                                                                                                                                                                                                                                               \n      File \"/home/openstack/oslo/oslo.messaging/oslo_messaging/tests/drivers/test_impl_kafka.py\", line 79, in test_transport_url                                                                                   \n    transport \u003d oslo_messaging.get_notification_transport(self.conf,                                                                                                                                                                           \n                                                                                                                                                                                                                                               \n      File \"/home/openstack/oslo/oslo.messaging/oslo_messaging/notify/notifier.py\", line 169, in get_notification_transport\n    return msg_transport._get_transport(\n\n      File \"/home/openstack/oslo/oslo.messaging/oslo_messaging/transport.py\", line 199, in _get_transport\n    url \u003d TransportURL.parse(conf, url)\n\n      File \"/home/openstack/oslo/oslo.messaging/oslo_messaging/transport.py\", line 519, in parse\n    port \u003d int(port)\n\n    ValueError: invalid literal for int() with base 10: \u0027db8::\u0027\n```\n\nDuring my test I tried to pass `kafka://2001:db8::` as transport_url and I face the previous issue.\n\nThe error disappear if I pass this transport url `kafka://[2001:db8::]`.\n\nIf I\u0027m right, the issue that I face means that your changes are not even reached during the execution workflow described here.\n\nAdding some unit tests could ensure that your changes are well used.\n\nThanks.\n\n[1] https://opendev.org/openstack/oslo.messaging/src/branch/master/oslo_messaging/transport.py#L421","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"11f03e9ad6511f127a9df9b0f5cdba2ef5ace8f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5086c02d_d078b8cf","updated":"2023-04-10 02:32:09.000000000","message":"The comments by Radosław as still valid. I\u0027ll leave -1 to highlight these.","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"69e0147d2b693c8cc5b0d999ae2523e0ab317b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3e693344_e17e3369","updated":"2022-10-10 11:58:27.000000000","message":"recheck","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"a9e00ba5e003fe362fb55144556a8ffedc50e0a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a422e827_2f3fdaec","updated":"2022-10-09 08:41:44.000000000","message":"recheck","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"}],"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ef91f8bd3c47e65979919cdb36f786badb8d661a","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            if host.hostname:"},{"line_number":128,"context_line":"                # fix: to support both ipv4 and ipv6 address"},{"line_number":129,"context_line":"                self.hostaddrs.append(\"[%s]:%s\" % (host.hostname, host.port)"},{"line_number":130,"context_line":"                                      if \u0027:\u0027 in host.hostname"},{"line_number":131,"context_line":"                                      else \"%s:%s\" % (host.hostname,"},{"line_number":132,"context_line":"                                                      host.port))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5bc46eb1_4dcdfdc8","line":129,"updated":"2022-09-26 07:25:42.000000000","message":"A cleaner logic would be to wrap the hostname part in [] if it contains \":\" rather than conditioning the entire pattern on it (as it duplicates code). E.g., introduce a new variable hostname and set it to either clean or []-wrapped form and then use the new variable in the pattern.","commit_id":"9b038807c572f8d0d2ba90ebf8ba7b9d8618ef4c"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"728ba1d476448ef8f58eb7bedecb41ada1f7895f","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            if host.hostname:"},{"line_number":128,"context_line":"                # fix: to support both ipv4 and ipv6 address"},{"line_number":129,"context_line":"                self.hostaddrs.append(\"[%s]:%s\" % (host.hostname, host.port)"},{"line_number":130,"context_line":"                                      if \u0027:\u0027 in host.hostname"},{"line_number":131,"context_line":"                                      else \"%s:%s\" % (host.hostname,"},{"line_number":132,"context_line":"                                                      host.port))"}],"source_content_type":"text/x-python","patch_set":2,"id":"21e842c5_38851a49","line":129,"in_reply_to":"5bc46eb1_4dcdfdc8","updated":"2022-10-09 05:02:10.000000000","message":"Ack","commit_id":"9b038807c572f8d0d2ba90ebf8ba7b9d8618ef4c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4e1850d9b3bd7b258e0c707da69e924ef2c8dba","unresolved":true,"context_lines":[{"line_number":125,"context_line":"                    LOG.warning(\"Different transport usernames detected\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            if host.hostname:"},{"line_number":128,"context_line":"                # fix: to support both ipv4 and ipv6 address"},{"line_number":129,"context_line":"                if \u0027:\u0027 in host.hostname:"},{"line_number":130,"context_line":"                    _hostname \u003d [host.hostname]"},{"line_number":131,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"0023f378_3e0b6dc4","line":128,"range":{"start_line":128,"start_character":18,"end_line":128,"end_character":21},"updated":"2022-10-11 08:19:54.000000000","message":"make it \"NOTE(dharmalingam):\"","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4e1850d9b3bd7b258e0c707da69e924ef2c8dba","unresolved":true,"context_lines":[{"line_number":127,"context_line":"            if host.hostname:"},{"line_number":128,"context_line":"                # fix: to support both ipv4 and ipv6 address"},{"line_number":129,"context_line":"                if \u0027:\u0027 in host.hostname:"},{"line_number":130,"context_line":"                    _hostname \u003d [host.hostname]"},{"line_number":131,"context_line":"                else:"},{"line_number":132,"context_line":"                    _hostname \u003d host.hostname"},{"line_number":133,"context_line":"                self.hostaddrs.append(\"%s:%s\" % (_hostname, host.port))"}],"source_content_type":"text/x-python","patch_set":5,"id":"48274bfe_e55c2ed6","line":130,"range":{"start_line":130,"start_character":32,"end_line":130,"end_character":47},"updated":"2022-10-11 08:19:54.000000000","message":"This must not be a list, this should be a string enclosed with [ ] so:\n\n    f\"[{host.hostname}]\"","commit_id":"ea48f280f0e66e4aadd9cf9ac76dcf4dbfb6b383"}]}