)]}'
{"id":"openstack%2Foslo.messaging~778019","triplet_id":"openstack%2Foslo.messaging~stable%2Fussuri~Id5cddbefbe24ef100f1cc522f44430df77d217cb","project":"openstack/oslo.messaging","branch":"stable/ussuri","topic":"backport-mandatory-to-ussuri","hashtags":[],"change_id":"Id5cddbefbe24ef100f1cc522f44430df77d217cb","subject":"Correctly handle missing RabbitMQ queues","status":"MERGED","created":"2021-03-01 15:56:43.000000000","updated":"2021-03-08 15:09:03.000000000","submitted":"2021-03-08 15:05:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"778019-backport-mandatory-to-ussuri","meta_rev_id":"bc39af18898da6571f9959c6ea6fdb9ce2f4b9f6","_number":778019,"virtual_id_number":778019,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-08 15:04:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2021-03-08 13:16:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-03-08 13:24:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-01 17:44:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-02 10:35:52.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"0088b3a347b0f022c68db9e6dc44e9bb7bf2f660","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-03-01 15:56:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"383683d54b8c6929f14fbf745ac2485cfabce378","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-01 17:44:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b260bda9252b4cb8bde15168af18c38b : SUCCESS in 1h 26m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f63299e635dc4aeab3d83028a1ad7c26 : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dd8b6cde5b4f46a8ba9a06907f3ad205 : SUCCESS in 4m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a719a5d178e48eba943f3e76c2e3c1e : SUCCESS in 5m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1433633f39df45f193cec338be345514 : SUCCESS in 8m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8a75573188c641dfa62438388c861ccf : SUCCESS in 5m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/57dbff73b61d43b595dd2ad78a37db70 : SUCCESS in 5m 11s\n- oslo.messaging-tox-py36-func-scenario01 https://zuul.opendev.org/t/openstack/build/bb152912a9b448f9bc3a5b998808b549 : SUCCESS in 6m 00s\n- oslo.messaging-tox-py36-func-scenario02 https://zuul.opendev.org/t/openstack/build/ae0a5622e8a2409f8d593a6a6dcea2ed : SUCCESS in 11m 29s (non-voting)\n- oslo.messaging-tox-py36-func-scenario03 https://zuul.opendev.org/t/openstack/build/fc8fc3e0a824404293dd9bd70785c23d : SUCCESS in 5m 49s (non-voting)\n- oslo.messaging-tox-py36-func-scenario04 https://zuul.opendev.org/t/openstack/build/548237eff0614f03b7303593ed761845 : SUCCESS in 10m 16s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/01b5a3133cec442790a5eb4504bacbce : SUCCESS in 1h 32m 08s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/9942109e267841c39518b04c7385f034 : SUCCESS in 1h 39m 51s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/72292aa478a24bec84320e51c67cb267 : SUCCESS in 1h 28m 11s (non-voting)\n- oslo.messaging-src-grenade-dsvm https://zuul.opendev.org/t/openstack/build/0a341fdc948d4b32a5bb15a4551e8150 : SUCCESS in 1h 03m 05s (non-voting)\n- oslo.messaging-src-grenade-dsvm-multinode https://zuul.opendev.org/t/openstack/build/9d8bcdec84ff4879b41de0ed2d2d67d8 : FAILURE in 24m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"68ece756731c6ae7eda94fc711b643c037a8adfd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-03-02 06:26:16.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"8382bccd65d9730b67b1192589b9a957772f71aa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-02 08:16:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cf323ce4d2cc442b8cc2a50c80dab1c8 : SUCCESS in 1h 37m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8c023bfa05d0447db2dbdf3284554b7d : SUCCESS in 9m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ca16897d989a4aafb5d72b45ba3fd2d4 : SUCCESS in 10m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/adc40a561bc7482fa69275b7add796e7 : SUCCESS in 10m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f0777e9343f8471ba1648717e52dd09c : SUCCESS in 11m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d3661eb52f834601b00aad8c5e6a07f2 : SUCCESS in 7m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/98f24f33c6214e06bf344964fd1a44b0 : SUCCESS in 5m 45s\n- oslo.messaging-tox-py36-func-scenario01 https://zuul.opendev.org/t/openstack/build/8862c2c697634211a78d14acfe002f64 : SUCCESS in 8m 33s\n- oslo.messaging-tox-py36-func-scenario02 https://zuul.opendev.org/t/openstack/build/91b49221e7914f208019be0d00bd24af : SUCCESS in 15m 11s (non-voting)\n- oslo.messaging-tox-py36-func-scenario03 https://zuul.opendev.org/t/openstack/build/7c69d8feb52d4b43bae1c3e7411b737d : SUCCESS in 13m 44s (non-voting)\n- oslo.messaging-tox-py36-func-scenario04 https://zuul.opendev.org/t/openstack/build/bb6a094d33614da5bba88288dbd5f4ad : FAILURE in 14m 13s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/4fa75b07d45d4d6e9185b9b57c0b1b1a : SUCCESS in 1h 31m 17s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/945d960e4a6f476c8e0873db708ed321 : SUCCESS in 1h 38m 07s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/22b70bb664094d4db9654e4e20d6ca25 : SUCCESS in 1h 44m 55s (non-voting)\n- oslo.messaging-src-grenade-dsvm https://zuul.opendev.org/t/openstack/build/68d2e0b3d3164c1097d740b67a61fa18 : SUCCESS in 1h 03m 45s (non-voting)\n- oslo.messaging-src-grenade-dsvm-multinode https://zuul.opendev.org/t/openstack/build/e748c505c8d34bf8ac6342457380fa19 : FAILURE in 31m 31s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ce22cc275311f1ebfb7ac537afbf6b8a4d6d1197","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-02 10:35:52.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nCommit message is good. Thanks for that. However, I think we can make the conflicts go away entirely by simply doing some additional cherry picks that would benefit us anyway. Let me know if you disagree.","accounts_in_message":[],"_revision_number":2},{"id":"edd4fe1474608ea8b9281f8babca97d6e22546ba","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-03-02 10:56:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"14fde206fcccfc063d99e25497364a1e3b6baa67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-03-02 10:59:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cf272d83475ecc5b727031cd97e2233c29849196","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-02 12:56:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/da82eae05dcd456e932d49ca22c83b63 : SUCCESS in 1h 23m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/65861f3529a142aa86c90e28a8fbab4c : SUCCESS in 7m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9a2adcdebc5a4bffa0f82b1e567ba6eb : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/148c5f88cb594da6afc1a8c6a3b964ab : SUCCESS in 11m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/09e9f430f0b24eee9e5dc1d8b06d1f0e : SUCCESS in 7m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd149365ef304caea25aa1de7f5dc225 : SUCCESS in 6m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cb9edfe004184acd93fdf74c0334ceb4 : SUCCESS in 5m 34s\n- oslo.messaging-tox-py36-func-scenario01 https://zuul.opendev.org/t/openstack/build/3605c527ff904ddb80f9129a3e683291 : SUCCESS in 15m 36s\n- oslo.messaging-tox-py36-func-scenario02 https://zuul.opendev.org/t/openstack/build/72cdbbad54fb41808b511dc786c6f686 : FAILURE in 17m 10s (non-voting)\n- oslo.messaging-tox-py36-func-scenario03 https://zuul.opendev.org/t/openstack/build/3e3250c71dd641aa82a0fce3274abc86 : SUCCESS in 6m 21s (non-voting)\n- oslo.messaging-tox-py36-func-scenario04 https://zuul.opendev.org/t/openstack/build/8670156a4cbb47f796723348ad0ecfc2 : SUCCESS in 15m 12s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/8502b29aef414da2ae4b27cb378cf6ac : SUCCESS in 1h 42m 36s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/4cb4f3a72ea34b5399ddab5a299124b1 : SUCCESS in 1h 24m 05s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/641918eba69f4abba3e4a9145a614b31 : SUCCESS in 1h 37m 13s (non-voting)\n- oslo.messaging-src-grenade-dsvm https://zuul.opendev.org/t/openstack/build/d0919e1d7753410cae01abb326cc2b1d : SUCCESS in 1h 23m 28s (non-voting)\n- oslo.messaging-src-grenade-dsvm-multinode https://zuul.opendev.org/t/openstack/build/254f63e8440f41a29a98d77134267767 : FAILURE in 27m 50s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"09f41f1237bf7cbb27b2e10f1d8432bcf256ef67","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-08 13:16:34.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"51475984e8ecbddf9e0c3699085257ec605615b7","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-03-08 13:24:04.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"5f75d35845781faf796a19f36d17f1c76cdb655d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-08 13:28:08.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"22b83c9e8cc863e46592897cdfec6e3c675d7d0e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-08 15:04:54.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/28c0e7431974461fb7125911ff60304f : SUCCESS in 1h 34m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ad614e6f2ea548e09227c99fc865c2e9 : SUCCESS in 6m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5a8a43940e924ec399d5c3a9c9bccec8 : SUCCESS in 9m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c1ac1aa1718248a88feb68028fc1d1aa : SUCCESS in 9m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f29738a42a424b469efde4e056a6ad11 : SUCCESS in 4m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fef7dbd1bd9545da8cf450476ba7225c : SUCCESS in 4m 22s\n- oslo.messaging-tox-py36-func-scenario01 https://zuul.opendev.org/t/openstack/build/566818e2491a44efb12addfb8a7c1808 : SUCCESS in 6m 12s\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/057b17e54f12471d8d35472c8776fbf5 : SUCCESS in 1h 10m 12s","accounts_in_message":[],"_revision_number":3},{"id":"7925304e4a302b3271ce640391ec59bc25c2eabf","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-08 15:05:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"bc39af18898da6571f9959c6ea6fdb9ce2f4b9f6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-08 15:09:03.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5bd28dee822c45f58f4294aad9f4c884 : SUCCESS in 1m 23s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3950da36e418426e823f9c74ec36cd12 : SUCCESS in 1m 54s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"36b5e06c92337cd04d1c8ae4840dbc224faeaa9f","revisions":{"8229a14933bbe384372406da50d46f11a634bf96":{"kind":"REWORK","_number":1,"created":"2021-03-01 15:56:43.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/19/778019/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/19/778019/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/1"}}},"commit":{"parents":[{"commit":"3bf9ba550454719f1d56dbbf8bccbabab11a16f6","subject":"Fix type of direct_mandatory_flag opt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/3bf9ba550454719f1d56dbbf8bccbabab11a16f6"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-01-08 14:54:54.000000000","tz":60},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-03-01 15:49:51.000000000","tz":60},"subject":"Correctly handle missing RabbitMQ queues","message":"Correctly handle missing RabbitMQ queues\n\nCurrently, setting the \u0027[oslo_messaging] direct_mandatory_flag\u0027 config\noption to \u0027True\u0027 (the default) will result in a \u0027MessageUndeliverable\u0027\nexception being raised when sending a reply if a RabbitMQ queue is\nmissing [1]. It was the responsibility of the application to handle\nthis exception, however, many applications are not doing so. This has\nresulted in a number of bug reports.\n\nStart handling this error condition, using a retry loop to attempt to\nresend the message and work around any temporary glitches. Since\nattempting to send a reply will will no longer raise an exception,\nthere is little benefit in retaining the \u0027[oslo_messaging]\ndirect_mandatory_flag\u0027 config option: users setting this to False will\nsimply not benefit from the retry logic and improved logging added\nhere. This option is already deprecated though and will be fully\nremoved in a future release.\n\n[1] https://www.rabbitmq.com/channels.html\n\nConflicts:\n- oslo_messaging/_drivers/amqpdriver.py\n- oslo_messaging/_drivers/impl_rabbit.py\n\nChange-Id: Id5cddbefbe24ef100f1cc522f44430df77d217cb\nCloses-Bug: #1905965\n(cherry picked from commit 4937949dffecdf8863a7876e5a6b0b18e811c3ac)\n(cherry picked from commit 391ce7fc69adc8d713d8ca64e76d901eb3e65df1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/8229a14933bbe384372406da50d46f11a634bf96"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/8229a14933bbe384372406da50d46f11a634bf96"}]},"branch":"refs/heads/stable/ussuri"},"6a97bd33ae85c37498dab30fddc9e2fc20c5aad5":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-02 06:26:16.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/19/778019/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/19/778019/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/2"}}},"commit":{"parents":[{"commit":"3bf9ba550454719f1d56dbbf8bccbabab11a16f6","subject":"Fix type of direct_mandatory_flag opt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/3bf9ba550454719f1d56dbbf8bccbabab11a16f6"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-01-08 14:54:54.000000000","tz":60},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-03-02 06:23:28.000000000","tz":60},"subject":"Correctly handle missing RabbitMQ queues","message":"Correctly handle missing RabbitMQ queues\n\nCurrently, setting the \u0027[oslo_messaging] direct_mandatory_flag\u0027 config\noption to \u0027True\u0027 (the default) will result in a \u0027MessageUndeliverable\u0027\nexception being raised when sending a reply if a RabbitMQ queue is\nmissing [1]. It was the responsibility of the application to handle\nthis exception, however, many applications are not doing so. This has\nresulted in a number of bug reports.\n\nStart handling this error condition, using a retry loop to attempt to\nresend the message and work around any temporary glitches. Since\nattempting to send a reply will will no longer raise an exception,\nthere is little benefit in retaining the \u0027[oslo_messaging]\ndirect_mandatory_flag\u0027 config option: users setting this to False will\nsimply not benefit from the retry logic and improved logging added\nhere. This option is already deprecated though and will be fully\nremoved in a future release.\n\n[1] https://www.rabbitmq.com/channels.html\n\nConflicts:\n- oslo_messaging/_drivers/amqpdriver.py\n- oslo_messaging/_drivers/impl_rabbit.py\n\nNOTE(hberaud): Conflicts are due to different log levels and option help\n\nChange-Id: Id5cddbefbe24ef100f1cc522f44430df77d217cb\nCloses-Bug: #1905965\n(cherry picked from commit 4937949dffecdf8863a7876e5a6b0b18e811c3ac)\n(cherry picked from commit 391ce7fc69adc8d713d8ca64e76d901eb3e65df1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/6a97bd33ae85c37498dab30fddc9e2fc20c5aad5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/6a97bd33ae85c37498dab30fddc9e2fc20c5aad5"}]},"branch":"refs/heads/stable/ussuri"},"36b5e06c92337cd04d1c8ae4840dbc224faeaa9f":{"kind":"REWORK","_number":3,"created":"2021-03-02 10:59:07.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/19/778019/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/19/778019/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/19/778019/3"}}},"commit":{"parents":[{"commit":"5f2a4f21d0a9988e4a939f2092a523956b4d4583","subject":"Deprecate the mandatory flag","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/5f2a4f21d0a9988e4a939f2092a523956b4d4583"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-01-08 14:54:54.000000000","tz":60},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2021-03-02 10:52:49.000000000","tz":60},"subject":"Correctly handle missing RabbitMQ queues","message":"Correctly handle missing RabbitMQ queues\n\nCurrently, setting the \u0027[oslo_messaging] direct_mandatory_flag\u0027 config\noption to \u0027True\u0027 (the default) will result in a \u0027MessageUndeliverable\u0027\nexception being raised when sending a reply if a RabbitMQ queue is\nmissing [1]. It was the responsibility of the application to handle\nthis exception, however, many applications are not doing so. This has\nresulted in a number of bug reports.\n\nStart handling this error condition, using a retry loop to attempt to\nresend the message and work around any temporary glitches. Since\nattempting to send a reply will will no longer raise an exception,\nthere is little benefit in retaining the \u0027[oslo_messaging]\ndirect_mandatory_flag\u0027 config option: users setting this to False will\nsimply not benefit from the retry logic and improved logging added\nhere. This option is already deprecated though and will be fully\nremoved in a future release.\n\n[1] https://www.rabbitmq.com/channels.html\n\nChange-Id: Id5cddbefbe24ef100f1cc522f44430df77d217cb\nCloses-Bug: #1905965\n(cherry picked from commit 4937949dffecdf8863a7876e5a6b0b18e811c3ac)\n(cherry picked from commit 391ce7fc69adc8d713d8ca64e76d901eb3e65df1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/36b5e06c92337cd04d1c8ae4840dbc224faeaa9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/36b5e06c92337cd04d1c8ae4840dbc224faeaa9f"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}