)]}'
{"oslo/messaging/_drivers/impl_qpid.py":[{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"3aa9f5425533e00fbc5c91cd9c47e5e6c95d6b1d","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"                params \u003d {"},{"line_number":472,"context_line":"                    \u0027host\u0027: \u0027%s:%d\u0027 % (host.hostname, port),"},{"line_number":473,"context_line":"                    \u0027username\u0027: host.username or \u0027\u0027,"},{"line_number":474,"context_line":"                    \u0027password\u0027: host.password or \u0027\u0027,"},{"line_number":475,"context_line":"                }"},{"line_number":476,"context_line":"                self.brokers_params.append(params)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2Fq9U%3D","line":473,"updated":"2014-04-14 10:33:23.000000000","message":"Its odd that if the url doesn\u0027t specify a port, then the config file value is used as a default, but if the url doesn\u0027t specify a username, the config file value is not used. Would be more intuitive to follow the same approach in each case. Personally I would simply use the values from the url as is, if specified, rather than try to combine them with the config values.\n\n(Very minor issue, but nicer in my view to not add the entry at all if there is no username, rather than add in an empty string).","commit_id":"53fe7dcaffc5a72e85ceaec83624308ced6723e6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f30b7b3d34bc00565e83485aa4f32eb8d004c147","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"                params \u003d {"},{"line_number":472,"context_line":"                    \u0027host\u0027: \u0027%s:%d\u0027 % (host.hostname, port),"},{"line_number":473,"context_line":"                    \u0027username\u0027: host.username or \u0027\u0027,"},{"line_number":474,"context_line":"                    \u0027password\u0027: host.password or \u0027\u0027,"},{"line_number":475,"context_line":"                }"},{"line_number":476,"context_line":"                self.brokers_params.append(params)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2F9%2F0%3D","line":473,"in_reply_to":"AAAAW3%2F%2Fq9U%3D","updated":"2014-04-16 08:24:26.000000000","message":"You right, I have fixed it and make the same change in the rabbitmq driver too.","commit_id":"53fe7dcaffc5a72e85ceaec83624308ced6723e6"},{"author":{"_account_id":8784,"name":"Gordon Sim","email":"gsim@redhat.com","username":"gordonsim"},"change_message_id":"3aa9f5425533e00fbc5c91cd9c47e5e6c95d6b1d","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            # Old configuration format"},{"line_number":479,"context_line":"            for adr in self.conf.qpid_hosts:"},{"line_number":480,"context_line":"                hostname, port \u003d network_utils.parse_host_port("},{"line_number":481,"context_line":"                    adr, default_port\u003dself.conf.qpid_port)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"                params \u003d {"},{"line_number":484,"context_line":"                    \u0027host\u0027: \u0027%s:%d\u0027 % (hostname, port),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAW3%2F%2Fq28%3D","line":481,"updated":"2014-04-14 10:33:23.000000000","message":"This seems like a somewhat orthogonal change in behaviour. Ie. if the address doesn\u0027t specify a port, use the default from the config file rather than the default for AMQP. Unlikely to be an issue in practice, but equally why change it?","commit_id":"53fe7dcaffc5a72e85ceaec83624308ced6723e6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f30b7b3d34bc00565e83485aa4f32eb8d004c147","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            # Old configuration format"},{"line_number":479,"context_line":"            for adr in self.conf.qpid_hosts:"},{"line_number":480,"context_line":"                hostname, port \u003d network_utils.parse_host_port("},{"line_number":481,"context_line":"                    adr, default_port\u003dself.conf.qpid_port)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"                params \u003d {"},{"line_number":484,"context_line":"                    \u0027host\u0027: \u0027%s:%d\u0027 % (hostname, port),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXH%2F%2F9%2F4%3D","line":481,"in_reply_to":"AAAAW3%2F%2Fq28%3D","updated":"2014-04-16 08:24:26.000000000","message":"I have restored the previous behavior.\n\nThis change came from rabbitmq driver, it have a different implementation, I don\u0027t really like that both amqp drivers have different behavior. But this is a separate concern. This patch should not change that.","commit_id":"53fe7dcaffc5a72e85ceaec83624308ced6723e6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"3d456e412be5b7d5c4491cb99cbd6fdd606f7ffa","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                    params[\u0027host\u0027] \u003d \u0027%s:%d\u0027 % (host.hostname, host.port)"},{"line_number":473,"context_line":"                else:"},{"line_number":474,"context_line":"                    params[\u0027host\u0027] \u003d host.hostname"},{"line_number":475,"context_line":"                self.brokers_params.append(params)"},{"line_number":476,"context_line":"        else:"},{"line_number":477,"context_line":"            # Old configuration format"},{"line_number":478,"context_line":"            for adr in self.conf.qpid_hosts:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad9bd40_dd3aa3cc","line":475,"updated":"2014-05-02 08:08:39.000000000","message":"Hmm, what would have worked before is if a URL didn\u0027t contain the username and password, but qpid_username/password was set\n\nThat\u0027s probably sufficiently obscure and confusing to not be worth worrying about though","commit_id":"53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"3d456e412be5b7d5c4491cb99cbd6fdd606f7ffa","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        else:"},{"line_number":477,"context_line":"            # Old configuration format"},{"line_number":478,"context_line":"            for adr in self.conf.qpid_hosts:"},{"line_number":479,"context_line":"                hostname, port \u003d network_utils.parse_host_port("},{"line_number":480,"context_line":"                    adr, default_port\u003d5672)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"                params \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad9bd40_3d19cf79","line":479,"range":{"start_line":479,"start_character":47,"end_line":479,"end_character":62},"updated":"2014-05-02 08:08:39.000000000","message":"The use of parse_host() is new here but makes sense and mirrors what the rabbit driver does","commit_id":"53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"750cb442255932900365b81a39f6ef176f2a2a78","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            # Old configuration format"},{"line_number":478,"context_line":"            for adr in self.conf.qpid_hosts:"},{"line_number":479,"context_line":"                hostname, port \u003d network_utils.parse_host_port("},{"line_number":480,"context_line":"                    adr, default_port\u003d5672)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"                params \u003d {"},{"line_number":483,"context_line":"                    \u0027host\u0027: \u0027%s:%d\u0027 % (hostname, port),"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAXX%2F%2Ftjo%3D","line":480,"updated":"2014-04-28 14:46:22.000000000","message":"is it worth storing the default port in a variable somewhere since we use it in impl_rabbit and tests?","commit_id":"53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"3d456e412be5b7d5c4491cb99cbd6fdd606f7ffa","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                self.connection.open()"},{"line_number":532,"context_line":"            except qpid_exceptions.MessagingError as e:"},{"line_number":533,"context_line":"                msg_dict \u003d dict(e\u003de, delay\u003ddelay, broker\u003dbroker[\u0027host\u0027])"},{"line_number":534,"context_line":"                msg \u003d _(\"Unable to connect to AMQP server on %(broker)s: \""},{"line_number":535,"context_line":"                        \"%(e)s. Sleeping %(delay)s seconds\") % msg_dict"},{"line_number":536,"context_line":"                LOG.error(msg)"},{"line_number":537,"context_line":"                time.sleep(delay)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad9bd40_fd35a7db","line":534,"updated":"2014-05-02 08:08:39.000000000","message":"This change is strictly unrelated but ok","commit_id":"53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4"}]}