)]}'
{"tests/test_qpid.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c6ebed06fadec777d28fe8b3a49a97456f1023b4","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            # reached"},{"line_number":523,"context_line":"            for _ in range(brokers_count):"},{"line_number":524,"context_line":"                connection.reconnect()"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        connection.close()"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FWJg%3D","line":525,"updated":"2014-03-18 13:41:51.000000000","message":"You needs to check you have reached the right number of attempt to ensure connection_create have been called 5 times. Otherwise the test can succeed if connection_create is never called.","commit_id":"25c54fd2ca000607f279f12d6664329c81719b4f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"40098bd152eaeff69abccfaa373a0011df1b2264","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            # reached"},{"line_number":523,"context_line":"            for _ in range(brokers_count):"},{"line_number":524,"context_line":"                connection.reconnect()"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        connection.close()"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FVgo%3D","line":525,"in_reply_to":"AAAAWH%2F%2FWJg%3D","updated":"2014-03-18 14:54:12.000000000","message":"Done","commit_id":"25c54fd2ca000607f279f12d6664329c81719b4f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"849ea0b83dd4670c84ef431ce4564625946d87e4","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        info \u003d {\u0027attempt\u0027: 0}"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        class MyConnection(qpid_driver.Connection):"},{"line_number":496,"context_line":"            def connection_create(myself, broker):"},{"line_number":497,"context_line":"                super(MyConnection, myself).connection_create(broker)"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FUBc%3D","line":495,"updated":"2014-03-18 17:27:01.000000000","message":"I think if you mock out the method of the connection class in the driver you can use the \"mock_calls\" attribute to test that they are called in the expected order with the expected value, without tracking all of that yourself.\n\nhttp://www.voidspace.org.uk/python/mock/examples.html#tracking-order-of-calls-and-less-verbose-call-assertions","commit_id":"2afc193c5da38f67e72dd71faa7beac41014bad3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2512a418cbde17eb68c1599c1b9731268b4db43c","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        info \u003d {\u0027attempt\u0027: 0}"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        class MyConnection(qpid_driver.Connection):"},{"line_number":496,"context_line":"            def connection_create(myself, broker):"},{"line_number":497,"context_line":"                super(MyConnection, myself).connection_create(broker)"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FOh4%3D","line":495,"in_reply_to":"AAAAWH%2F%2FUBc%3D","updated":"2014-03-19 09:42:45.000000000","message":"Done","commit_id":"2afc193c5da38f67e72dd71faa7beac41014bad3"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"b787dffbbda2542bb1ffc028d51017273f265c58","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                         mock.call().open(),"},{"line_number":427,"context_line":"                         mock.call().session(),"},{"line_number":428,"context_line":"                         mock.call().close()])"},{"line_number":429,"context_line":"        self.assertEqual(conn_mock.mock_calls, expected)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def synchronized(func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FFpc%3D","line":429,"updated":"2014-03-20 11:11:52.000000000","message":"See I7eb3d095f7a1ff9a4abc9e027193d4918d0cda6c\n\nPlease use:\n\n  conn_mock.assert_has_calls(expected)","commit_id":"5a025b5d08a64ab253768e102fef5584e8a3a9e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6765f2b8da2707406270113b54e8224809fcba68","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                         mock.call().open(),"},{"line_number":427,"context_line":"                         mock.call().session(),"},{"line_number":428,"context_line":"                         mock.call().close()])"},{"line_number":429,"context_line":"        self.assertEqual(conn_mock.mock_calls, expected)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def synchronized(func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FEnM%3D","line":429,"in_reply_to":"AAAAWH%2F%2FFpc%3D","updated":"2014-03-20 13:38:23.000000000","message":"Done","commit_id":"5a025b5d08a64ab253768e102fef5584e8a3a9e7"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"792453e0c6d9d351675eeec6f88854adf555160d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"import random"},{"line_number":17,"context_line":"import thread"},{"line_number":18,"context_line":"import threading"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2B3xY%3D","line":15,"updated":"2014-03-22 07:40:27.000000000","message":"mock should be grouped into third party now , though  it was available as unittest.mock in Python 3.3 onward.","commit_id":"03b7de872b5712e873807f7ea762a0f48f578d6b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"792453e0c6d9d351675eeec6f88854adf555160d","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    \"\"\""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_reconnect_order(self):"},{"line_number":398,"context_line":"        brokers \u003d (\u0027host1\u0027, \u0027host2\u0027, \u0027host3\u0027, \u0027host4\u0027, \u0027host5\u0027)"},{"line_number":399,"context_line":"        brokers_count \u003d len(brokers)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.messaging_conf.conf.qpid_hosts \u003d brokers"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2B3ww%3D","line":398,"updated":"2014-03-22 07:40:27.000000000","message":"According to  https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L46 ,  should be \u0027[\u0027, not\u0027(\u0027 ?","commit_id":"03b7de872b5712e873807f7ea762a0f48f578d6b"}]}
