)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6888cb2cd556d8465685403498f20706ee8bfc76","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available one in order now. The order depends on what we set in"},{"line_number":11,"context_line":"configuration file. That means all the connections will flock"},{"line_number":12,"context_line":"to same message broker and that may lead out performance issue."},{"line_number":13,"context_line":"This patch randomizes the order of chooing message broker for"},{"line_number":14,"context_line":"each connection to leverage broker cluster."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib5098e574d4ef81428065885e2295d0f87aba715"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2BNn0%3D","line":13,"updated":"2014-03-28 11:25:38.000000000","message":"s/chooing/choosing","commit_id":"f27489f29d8af75e505bb31bf83ebc2720049bdb"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"b5f87e3b5643bf1113e6018c72b2dbd157c1050e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"available one in order now. The order depends on what we set in"},{"line_number":11,"context_line":"configuration file. That means all the connections will flock"},{"line_number":12,"context_line":"to same message broker and that may lead out performance issue."},{"line_number":13,"context_line":"This patch randomizes the order of chooing message broker for"},{"line_number":14,"context_line":"each connection to leverage broker cluster."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib5098e574d4ef81428065885e2295d0f87aba715"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2BIEY%3D","line":13,"in_reply_to":"AAAAWH%2F%2BNn0%3D","updated":"2014-03-29 01:48:11.000000000","message":"Done","commit_id":"f27489f29d8af75e505bb31bf83ebc2720049bdb"}],"oslo/messaging/_drivers/impl_qpid.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"481158bbfd39be3852d5e48c2a44b09adff3222d","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        }"},{"line_number":475,"context_line":"        params.update(server_params or {})"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        random.shuffle(params[\u0027qpid_hosts\u0027])"},{"line_number":478,"context_line":"        self.brokers \u003d itertools.cycle(params[\u0027qpid_hosts\u0027])"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        self.username \u003d params[\u0027username\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FszM%3D","line":477,"updated":"2014-04-11 02:13:55.000000000","message":"Won\u0027t this shuffle someone elses qpid_hosts, aka the self.conf is likely expecting that it owns the list and this shuffle will now mess with someone elses list. Maybe instead u should shuffle a copy (and put that copy into params) to avoid this. Seems wrong to mess with self.conf\u0027s qpid_hosts (especially if a unit test is expecting the order to be retained).","commit_id":"8be038d0cec624cc8e42640b44a0bbc309e72faa"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"1e2ff0c48274fd8ea3c4bc215a5760a8746249be","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        }"},{"line_number":475,"context_line":"        params.update(server_params or {})"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        random.shuffle(params[\u0027qpid_hosts\u0027])"},{"line_number":478,"context_line":"        self.brokers \u003d itertools.cycle(params[\u0027qpid_hosts\u0027])"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        self.username \u003d params[\u0027username\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2Fsv8%3D","line":477,"in_reply_to":"AAAAW3%2F%2FszM%3D","updated":"2014-04-11 02:32:27.000000000","message":"nice catch , done","commit_id":"8be038d0cec624cc8e42640b44a0bbc309e72faa"}],"tests/test_qpid.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"247e651e619aa7e86c72dcdc5ff70579462a0b56","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                             mock.call().close()])"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # the last one was closed with close(), not reconnect()"},{"line_number":425,"context_line":"        expected.extend([mock.call(brokers[0]),"},{"line_number":426,"context_line":"                         mock.call().open(),"},{"line_number":427,"context_line":"                         mock.call().session(),"},{"line_number":428,"context_line":"                         mock.call().close()])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FkgQ%3D","side":"PARENT","line":425,"updated":"2014-04-12 09:22:41.000000000","message":"we can\u0027t decide which broker was used in connection.close(), just remove it to pass unit test.","commit_id":"c90581937c54c6abbeb2d5446440a6fb5913b0b3"}]}