)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add quorum queue control configurations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the quorum queue type add features that did not exist before"},{"line_number":10,"context_line":"or not handled in rabbitmq the following link shows some of them"},{"line_number":11,"context_line":"https://blog.rabbitmq.com/posts/2020/04/rabbitmq-gets-an-ha-upgrade/"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"12a581a0_fc56a10f","line":9,"updated":"2022-03-30 10:14:08.000000000","message":"nit: please wrap commit messages at \u003c\u003d 72 characters where possible","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add quorum queue control configurations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the quorum queue type add features that did not exist before"},{"line_number":10,"context_line":"or not handled in rabbitmq the following link shows some of them"},{"line_number":11,"context_line":"https://blog.rabbitmq.com/posts/2020/04/rabbitmq-gets-an-ha-upgrade/"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"772d6239_2d8b3e0d","line":9,"in_reply_to":"12a581a0_fc56a10f","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"or not handled in rabbitmq the following link shows some of them"},{"line_number":11,"context_line":"https://blog.rabbitmq.com/posts/2020/04/rabbitmq-gets-an-ha-upgrade/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"the options below control the quorum queue and insure the stability of"},{"line_number":14,"context_line":"the quorum system"},{"line_number":15,"context_line":"x-max-in-memory-length"},{"line_number":16,"context_line":"x-max-in-memory-bytes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"8b656c75_cd998912","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":53},"updated":"2022-03-30 10:14:08.000000000","message":"ensure (insure \u003d insurance)","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"or not handled in rabbitmq the following link shows some of them"},{"line_number":11,"context_line":"https://blog.rabbitmq.com/posts/2020/04/rabbitmq-gets-an-ha-upgrade/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"the options below control the quorum queue and insure the stability of"},{"line_number":14,"context_line":"the quorum system"},{"line_number":15,"context_line":"x-max-in-memory-length"},{"line_number":16,"context_line":"x-max-in-memory-bytes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"2e23f85f_8e747bda","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":53},"in_reply_to":"8b656c75_cd998912","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"fa5f4b84fb713c89601c21b48f314dafd177f49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f70f2bc4_c7cf53b3","updated":"2022-02-26 03:57:47.000000000","message":"recheck ","commit_id":"a92fe33e40dcd04113e9e18b3002498967e5d409"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"5c6286d3d47a80f35fcc6669e09fd8d6be029098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"55390a45_d79379e3","updated":"2022-02-26 06:47:39.000000000","message":"recheck","commit_id":"2879ab34efdf0698cf85e502ca34b27238f8ea66"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"9392cfd8151f590bc9a2af4798604a4a08972d5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3ad815ec_7aac1bda","updated":"2022-02-26 06:54:22.000000000","message":"recheck","commit_id":"dfaa15e2c6c210c81663a4762ea96e789fae9592"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"6f42c890a9a888fe40d830727bda28a3dc364f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"faf371e7_63dbe50c","updated":"2022-02-27 21:13:39.000000000","message":"recheck","commit_id":"dfaa15e2c6c210c81663a4762ea96e789fae9592"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"45b83adaa9c7409223529de7b878329f03058453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f58c5722_8d92f3a8","updated":"2022-03-02 23:17:16.000000000","message":"OK I think this should be fine.","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3a193e70_73ba238c","updated":"2022-03-30 10:14:08.000000000","message":"This seems fine. Got a couple of doc nits and I also question the use of a dict to store options. If you can address these, I\u0027m happy","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"41d0e6f5165d3965178106678ad935c4e06925fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"16f0809e_6f43f3b8","updated":"2022-03-31 19:24:54.000000000","message":"recheck","commit_id":"69fab060774a23d5b891667a5216a9cd7445f186"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"229d58ba25c30265573756d762bf05edc8f31e04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b40ece99_3fef237a","updated":"2022-03-31 20:00:27.000000000","message":"recheck","commit_id":"0c80e468d52027384bb5af5358de6ced375eb608"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"97acf340c7f4920243fe8707b62f0144c296425e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"8801d18e_097d476f","updated":"2022-04-01 17:08:54.000000000","message":"i dont know if the failure related to my change\nis it?","commit_id":"23466e658afe184ef5213178566e6a5dc230b56f"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"c64c98619e82f5dd68cc1bd7e45b0e574ca1e077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"78e8b8ef_14c3d7bf","updated":"2022-04-01 01:39:00.000000000","message":"recheck","commit_id":"23466e658afe184ef5213178566e6a5dc230b56f"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"7fc12ae1eb26bfd52a260b5ac3a7a008a2514d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9d3942a7_e11f824e","updated":"2022-04-06 16:32:53.000000000","message":"recheck","commit_id":"23466e658afe184ef5213178566e6a5dc230b56f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c2f215f9f29793bad138e9f2606dbedc74e3d825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"98b973d9_8c2735ef","in_reply_to":"8801d18e_097d476f","updated":"2022-04-21 13:49:58.000000000","message":"Hello,\n\nThe failure doesn\u0027t seems related to your changes. \nSee my test, the error is there too:\nhttps://review.opendev.org/c/openstack/oslo.messaging/+/838842","commit_id":"23466e658afe184ef5213178566e6a5dc230b56f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"aab211a85774dab3c29b7fc77a61e65df292587a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d6048570_6132ca9e","in_reply_to":"98b973d9_8c2735ef","updated":"2022-04-21 15:01:39.000000000","message":"Well I proposed a patch to fix this issue.\nThe problem was due to latest released version of py-amqp 5.1.1 who changed how the connections are managed.\nMy fix propose to move py3.6 and py3.8 to the version 5.1.1 of py-amqp and adapt the tests to fix the errors.\n\nFor further details please take a look to https://review.opendev.org/c/openstack/oslo.messaging/+/838914","commit_id":"23466e658afe184ef5213178566e6a5dc230b56f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"348415cc4b81d07d83485b2ebb08bc84f0826ac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ea44c383_15c6be99","updated":"2022-04-22 08:52:22.000000000","message":"I missed that Stephen already submitted a patch to fix the CI problem\n\nhttps://review.opendev.org/c/openstack/oslo.messaging/+/838914","commit_id":"8932ad237bea44e42297ea7acbbd67f6664fa005"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"31499258962d73ef39ea8f729b814d90825712a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"14267e58_2a63f2bb","updated":"2022-06-06 20:47:50.000000000","message":"So, is this good to merge?","commit_id":"8932ad237bea44e42297ea7acbbd67f6664fa005"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"4479fa276f76c55840c2dfaa0ff78c506c6b34b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3779339c_acec02dd","updated":"2022-04-27 13:33:07.000000000","message":"Thanks a lot.","commit_id":"8932ad237bea44e42297ea7acbbd67f6664fa005"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"aad96f44ddb6f8937cafb8ad57c61766d3c1f620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7eeb7139_1ebf91c1","updated":"2022-04-26 18:40:07.000000000","message":"recheck","commit_id":"8932ad237bea44e42297ea7acbbd67f6664fa005"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    \u0027of messages in the quorum queue. \u0027"},{"line_number":164,"context_line":"                    \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":165,"context_line":"                    \u0027Default 0 which means dont set a value.\u0027"},{"line_number":166,"context_line":"              ),"},{"line_number":167,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_bytes\u0027,"},{"line_number":168,"context_line":"               default\u003d0,"},{"line_number":169,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"76226ddd_9842e55f","line":166,"in_reply_to":"3c411ea8_689b47f9","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E124 closing bracket does not match visual indentation\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                    \u0027of memory bytes used by the quorum queue. \u0027"},{"line_number":173,"context_line":"                    \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":174,"context_line":"                    \u0027Default 0 which means dont set a value.\u0027"},{"line_number":175,"context_line":"              ),"},{"line_number":176,"context_line":"    cfg.IntOpt(\u0027rabbit_transient_queues_ttl\u0027,"},{"line_number":177,"context_line":"               min\u003d1,"},{"line_number":178,"context_line":"               default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":6,"id":"29a4b956_3f543b07","line":175,"in_reply_to":"46077c24_a2e005c3","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E124 closing bracket does not match visual indentation\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            raise RuntimeError(\"Invalid SSL version : %s\" % version)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    def _get_quorum_configurations(self, driver_conf):"},{"line_number":760,"context_line":"        \"\"\" Get the quorum queue configurations \"\"\""},{"line_number":761,"context_line":"        quorum_config \u003d {}"},{"line_number":762,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":763,"context_line":"           if driver_conf.rabbit_quorum_delivery_limit:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b66f318_ddd34186","line":760,"in_reply_to":"5abcf7bf_2e9e4b93","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: H401: docstring should not start with a space\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":760,"context_line":"        \"\"\" Get the quorum queue configurations \"\"\""},{"line_number":761,"context_line":"        quorum_config \u003d {}"},{"line_number":762,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":763,"context_line":"           if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":764,"context_line":"               quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":765,"context_line":"                   driver_conf.rabbit_quorum_delivery_limit"},{"line_number":766,"context_line":"           if driver_conf.rabbit_quroum_max_memory_lenght:"}],"source_content_type":"text/x-python","patch_set":6,"id":"efe1b6f0_73386bd9","line":763,"in_reply_to":"c93d1ceb_830902ce","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E111 indentation is not a multiple of four\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        quorum_config \u003d {}"},{"line_number":762,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":763,"context_line":"           if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":764,"context_line":"               quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":765,"context_line":"                   driver_conf.rabbit_quorum_delivery_limit"},{"line_number":766,"context_line":"           if driver_conf.rabbit_quroum_max_memory_lenght:"},{"line_number":767,"context_line":"               quorum_config[\u0027max_memory_lenght\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"facd30c0_2087a9a0","line":764,"in_reply_to":"47ee004c_1859b667","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E111 indentation is not a multiple of four\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":763,"context_line":"           if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":764,"context_line":"               quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":765,"context_line":"                   driver_conf.rabbit_quorum_delivery_limit"},{"line_number":766,"context_line":"           if driver_conf.rabbit_quroum_max_memory_lenght:"},{"line_number":767,"context_line":"               quorum_config[\u0027max_memory_lenght\u0027] \u003d \\"},{"line_number":768,"context_line":"                   driver_conf.rabbit_quroum_max_memory_lenght"},{"line_number":769,"context_line":"           if driver_conf.rabbit_quroum_max_memory_bytes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0eded510_4ba78918","line":766,"in_reply_to":"54099aeb_85fd9132","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E111 indentation is not a multiple of four\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":766,"context_line":"           if driver_conf.rabbit_quroum_max_memory_lenght:"},{"line_number":767,"context_line":"               quorum_config[\u0027max_memory_lenght\u0027] \u003d \\"},{"line_number":768,"context_line":"                   driver_conf.rabbit_quroum_max_memory_lenght"},{"line_number":769,"context_line":"           if driver_conf.rabbit_quroum_max_memory_bytes:"},{"line_number":770,"context_line":"               quorum_config[\u0027max_memory_bytes\u0027] \u003d \\"},{"line_number":771,"context_line":"                   driver_conf.rabbit_quroum_max_memory_bytes"},{"line_number":772,"context_line":"        return quorum_config"}],"source_content_type":"text/x-python","patch_set":6,"id":"16a63ed2_17d0aaeb","line":769,"in_reply_to":"5b3966f8_9a9ed030","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E111 indentation is not a multiple of four\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"b469f0718f818344046a44df71371249b67ea8f8","unresolved":false,"context_lines":[{"line_number":767,"context_line":"               quorum_config[\u0027max_memory_lenght\u0027] \u003d \\"},{"line_number":768,"context_line":"                   driver_conf.rabbit_quroum_max_memory_lenght"},{"line_number":769,"context_line":"           if driver_conf.rabbit_quroum_max_memory_bytes:"},{"line_number":770,"context_line":"               quorum_config[\u0027max_memory_bytes\u0027] \u003d \\"},{"line_number":771,"context_line":"                   driver_conf.rabbit_quroum_max_memory_bytes"},{"line_number":772,"context_line":"        return quorum_config"},{"line_number":773,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f1ab2f96_b1fccce1","line":770,"in_reply_to":"5f31c2a9_d6eab4a5","updated":"2022-02-26 00:47:49.000000000","message":"\u003e pep8: E111 indentation is not a multiple of four\n\nPlease fix.","commit_id":"d34f969098029b3f401caeaa7569bee89b61e8cf"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e4d7768501d059923e3685549bcfb8c630302e96","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                \u0027queues durable by default so the amqp_durable_queues \u0027"},{"line_number":149,"context_line":"                \u0027opion is ignored when this option enabled.\u0027),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027rabbit_quorum_delivery_limit\u0027,"},{"line_number":151,"context_line":"               default\u003d0,"},{"line_number":152,"context_line":"               help\u003d\u0027Each time a message is redelivered to a consumer, \u0027"},{"line_number":153,"context_line":"               \u0027a counter is incremented. Once the redelivery count \u0027"},{"line_number":154,"context_line":"               \u0027exceeds the delivery limit the message gets dropped \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f666350_36b3e588","line":151,"updated":"2022-03-02 21:28:41.000000000","message":"See below -- not sure if 0 makes sense here when None would be more logically obvious.","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"f6d7e44ab38c529c0deeb0d1cc9cde4b1ec632dd","unresolved":true,"context_lines":[{"line_number":148,"context_line":"                \u0027queues durable by default so the amqp_durable_queues \u0027"},{"line_number":149,"context_line":"                \u0027opion is ignored when this option enabled.\u0027),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027rabbit_quorum_delivery_limit\u0027,"},{"line_number":151,"context_line":"               default\u003d0,"},{"line_number":152,"context_line":"               help\u003d\u0027Each time a message is redelivered to a consumer, \u0027"},{"line_number":153,"context_line":"               \u0027a counter is incremented. Once the redelivery count \u0027"},{"line_number":154,"context_line":"               \u0027exceeds the delivery limit the message gets dropped \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"e7e4c8da_bb02a20e","line":151,"in_reply_to":"1f666350_36b3e588","updated":"2022-03-02 22:00:09.000000000","message":"because its an cfg.IntOpt thats why zero is used","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ea33f8e2bd9859b1fcf9f5aa75826883a826e165","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                \u0027queues durable by default so the amqp_durable_queues \u0027"},{"line_number":149,"context_line":"                \u0027opion is ignored when this option enabled.\u0027),"},{"line_number":150,"context_line":"    cfg.IntOpt(\u0027rabbit_quorum_delivery_limit\u0027,"},{"line_number":151,"context_line":"               default\u003d0,"},{"line_number":152,"context_line":"               help\u003d\u0027Each time a message is redelivered to a consumer, \u0027"},{"line_number":153,"context_line":"               \u0027a counter is incremented. Once the redelivery count \u0027"},{"line_number":154,"context_line":"               \u0027exceeds the delivery limit the message gets dropped \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"26dc5bfa_abb0d6bf","line":151,"in_reply_to":"e7e4c8da_bb02a20e","updated":"2022-03-02 22:40:44.000000000","message":"Ack","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e4d7768501d059923e3685549bcfb8c630302e96","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def _get_queue_arguments(rabbit_ha_queues, rabbit_queue_ttl,"},{"line_number":217,"context_line":"                         rabbit_quorum_queue,"},{"line_number":218,"context_line":"                         rabbit_quorum_queue_config):"},{"line_number":219,"context_line":"    \"\"\"Construct the arguments for declaring a queue."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    If the rabbit_ha_queues option is set, we try to declare a mirrored queue"}],"source_content_type":"text/x-python","patch_set":10,"id":"73426dcc_577ea0f1","line":218,"updated":"2022-03-02 21:28:41.000000000","message":"I don\u0027t totally understand why this has to be a separate thing, is the first `rabbit_quorum_queue` a single value and then this is a dict? It just seems unlike the rest of how this is used? Though maybe this is fine.","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"f6d7e44ab38c529c0deeb0d1cc9cde4b1ec632dd","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def _get_queue_arguments(rabbit_ha_queues, rabbit_queue_ttl,"},{"line_number":217,"context_line":"                         rabbit_quorum_queue,"},{"line_number":218,"context_line":"                         rabbit_quorum_queue_config):"},{"line_number":219,"context_line":"    \"\"\"Construct the arguments for declaring a queue."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    If the rabbit_ha_queues option is set, we try to declare a mirrored queue"}],"source_content_type":"text/x-python","patch_set":10,"id":"a6f5760e_2ddd2fce","line":218,"in_reply_to":"73426dcc_577ea0f1","updated":"2022-03-02 22:00:09.000000000","message":"the rabbit_quorum_queue is boolean and i dont wan those to be separate variables\nwhich make the functions have too may parameters","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ea33f8e2bd9859b1fcf9f5aa75826883a826e165","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def _get_queue_arguments(rabbit_ha_queues, rabbit_queue_ttl,"},{"line_number":217,"context_line":"                         rabbit_quorum_queue,"},{"line_number":218,"context_line":"                         rabbit_quorum_queue_config):"},{"line_number":219,"context_line":"    \"\"\"Construct the arguments for declaring a queue."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    If the rabbit_ha_queues option is set, we try to declare a mirrored queue"}],"source_content_type":"text/x-python","patch_set":10,"id":"de47fd53_2067a55f","line":218,"in_reply_to":"a6f5760e_2ddd2fce","updated":"2022-03-02 22:40:44.000000000","message":"Ack","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e4d7768501d059923e3685549bcfb8c630302e96","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                 exchange_auto_delete, queue_auto_delete, callback,"},{"line_number":310,"context_line":"                 nowait\u003dFalse, rabbit_ha_queues\u003dNone, rabbit_queue_ttl\u003d0,"},{"line_number":311,"context_line":"                 enable_cancel_on_failover\u003dFalse, rabbit_quorum_queue\u003dFalse,"},{"line_number":312,"context_line":"                 rabbit_quorum_queue_config\u003d{}):"},{"line_number":313,"context_line":"        \"\"\"Init the Consumer class with the exchange_name, routing_key,"},{"line_number":314,"context_line":"        type, durable auto_delete"},{"line_number":315,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"4e408c04_37f8689e","line":312,"updated":"2022-03-02 21:28:41.000000000","message":"Maybe don\u0027t use a mutable type as the default here -- I\u0027m not SURE if it will cause problems here, but it\u0027s just bad practice unless you\u0027re trying to make a singleton or something...","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"f6d7e44ab38c529c0deeb0d1cc9cde4b1ec632dd","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                 exchange_auto_delete, queue_auto_delete, callback,"},{"line_number":310,"context_line":"                 nowait\u003dFalse, rabbit_ha_queues\u003dNone, rabbit_queue_ttl\u003d0,"},{"line_number":311,"context_line":"                 enable_cancel_on_failover\u003dFalse, rabbit_quorum_queue\u003dFalse,"},{"line_number":312,"context_line":"                 rabbit_quorum_queue_config\u003d{}):"},{"line_number":313,"context_line":"        \"\"\"Init the Consumer class with the exchange_name, routing_key,"},{"line_number":314,"context_line":"        type, durable auto_delete"},{"line_number":315,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8d6775_5ae317a8","line":312,"in_reply_to":"4e408c04_37f8689e","updated":"2022-03-02 22:00:09.000000000","message":"because we always check it with `in`","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"be2ea41c5b4877d7203fecd349bfbc06cd6334ee","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                 exchange_auto_delete, queue_auto_delete, callback,"},{"line_number":310,"context_line":"                 nowait\u003dFalse, rabbit_ha_queues\u003dNone, rabbit_queue_ttl\u003d0,"},{"line_number":311,"context_line":"                 enable_cancel_on_failover\u003dFalse, rabbit_quorum_queue\u003dFalse,"},{"line_number":312,"context_line":"                 rabbit_quorum_queue_config\u003d{}):"},{"line_number":313,"context_line":"        \"\"\"Init the Consumer class with the exchange_name, routing_key,"},{"line_number":314,"context_line":"        type, durable auto_delete"},{"line_number":315,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"c53d70a0_e3925df3","line":312,"in_reply_to":"8e772864_2acd37e0","updated":"2022-03-03 02:09:32.000000000","message":"Done","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ea33f8e2bd9859b1fcf9f5aa75826883a826e165","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                 exchange_auto_delete, queue_auto_delete, callback,"},{"line_number":310,"context_line":"                 nowait\u003dFalse, rabbit_ha_queues\u003dNone, rabbit_queue_ttl\u003d0,"},{"line_number":311,"context_line":"                 enable_cancel_on_failover\u003dFalse, rabbit_quorum_queue\u003dFalse,"},{"line_number":312,"context_line":"                 rabbit_quorum_queue_config\u003d{}):"},{"line_number":313,"context_line":"        \"\"\"Init the Consumer class with the exchange_name, routing_key,"},{"line_number":314,"context_line":"        type, durable auto_delete"},{"line_number":315,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"8e772864_2acd37e0","line":312,"in_reply_to":"ba8d6775_5ae317a8","updated":"2022-03-02 22:40:44.000000000","message":"Not really what I meant but you got it I think","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e4d7768501d059923e3685549bcfb8c630302e96","unresolved":true,"context_lines":[{"line_number":758,"context_line":"        \"\"\"Get the quorum queue configurations\"\"\""},{"line_number":759,"context_line":"        quorum_config \u003d {}"},{"line_number":760,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":761,"context_line":"            if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":762,"context_line":"                quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":763,"context_line":"                    driver_conf.rabbit_quorum_delivery_limit"},{"line_number":764,"context_line":"            if driver_conf.rabbit_quroum_max_memory_length:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a1f97fc_194b3f76","line":761,"updated":"2022-03-02 21:28:41.000000000","message":"Given this is how you\u0027re checking, wouldn\u0027t \"None\" be a better default than 0?","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ea33f8e2bd9859b1fcf9f5aa75826883a826e165","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        \"\"\"Get the quorum queue configurations\"\"\""},{"line_number":759,"context_line":"        quorum_config \u003d {}"},{"line_number":760,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":761,"context_line":"            if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":762,"context_line":"                quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":763,"context_line":"                    driver_conf.rabbit_quorum_delivery_limit"},{"line_number":764,"context_line":"            if driver_conf.rabbit_quroum_max_memory_length:"}],"source_content_type":"text/x-python","patch_set":10,"id":"db86d017_6799bbe3","line":761,"in_reply_to":"762e7eac_73b9e335","updated":"2022-03-02 22:40:44.000000000","message":"Ack","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"f6d7e44ab38c529c0deeb0d1cc9cde4b1ec632dd","unresolved":true,"context_lines":[{"line_number":758,"context_line":"        \"\"\"Get the quorum queue configurations\"\"\""},{"line_number":759,"context_line":"        quorum_config \u003d {}"},{"line_number":760,"context_line":"        if driver_conf.rabbit_quorum_queue:"},{"line_number":761,"context_line":"            if driver_conf.rabbit_quorum_delivery_limit:"},{"line_number":762,"context_line":"                quorum_config[\u0027delivery_limit\u0027] \u003d \\"},{"line_number":763,"context_line":"                    driver_conf.rabbit_quorum_delivery_limit"},{"line_number":764,"context_line":"            if driver_conf.rabbit_quroum_max_memory_length:"}],"source_content_type":"text/x-python","patch_set":10,"id":"762e7eac_73b9e335","line":761,"in_reply_to":"9a1f97fc_194b3f76","updated":"2022-03-02 22:00:09.000000000","message":"explained before","commit_id":"0ec8fecf366adfa955a3f79c32bca54a926913f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":154,"context_line":"               \u0027exceeds the delivery limit the message gets dropped \u0027"},{"line_number":155,"context_line":"               \u0027or dead-lettered (if a DLX exchange has been configured) \u0027"},{"line_number":156,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":157,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_length\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"40f27247_3824d5f9","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":54},"updated":"2022-03-30 10:14:08.000000000","message":"don\u0027t set a limit ?","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"               \u0027exceeds the delivery limit the message gets dropped \u0027"},{"line_number":155,"context_line":"               \u0027or dead-lettered (if a DLX exchange has been configured) \u0027"},{"line_number":156,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":157,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_length\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"e7e31461_b069aa95","line":157,"range":{"start_line":157,"start_character":38,"end_line":157,"end_character":54},"in_reply_to":"40f27247_3824d5f9","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":157,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_length\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":161,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"a3d91897_cb67a115","line":160,"range":{"start_line":160,"start_character":69,"end_line":160,"end_character":76},"updated":"2022-03-30 10:14:08.000000000","message":"Drop this.\n\n  ...maintained in memory. If a quorum queue...","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":158,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_length\u0027,"},{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":161,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"a55995b9_501d317a","line":160,"range":{"start_line":160,"start_character":69,"end_line":160,"end_character":76},"in_reply_to":"a3d91897_cb67a115","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":161,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"},{"line_number":164,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9da48657_10c55c74","line":162,"range":{"start_line":162,"start_character":39,"end_line":162,"end_character":43},"updated":"2022-03-30 10:14:08.000000000","message":"This","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":159,"context_line":"               default\u003d0,"},{"line_number":160,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":161,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"},{"line_number":164,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"a369bd98_932be5e4","line":162,"range":{"start_line":162,"start_character":39,"end_line":162,"end_character":43},"in_reply_to":"9da48657_10c55c74","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"},{"line_number":164,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":166,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_bytes\u0027,"},{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"c1e371a0_f2025d8f","line":165,"range":{"start_line":165,"start_character":38,"end_line":165,"end_character":54},"updated":"2022-03-30 10:14:08.000000000","message":"don\u0027t set a limit ?","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":163,"context_line":"               \u0027of messages in the quorum queue. \u0027"},{"line_number":164,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":166,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_bytes\u0027,"},{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"042db832_de1a92f0","line":165,"range":{"start_line":165,"start_character":38,"end_line":165,"end_character":54},"in_reply_to":"c1e371a0_f2025d8f","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":166,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_bytes\u0027,"},{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":169,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"287ff512_424fd0ed","line":168,"range":{"start_line":168,"start_character":69,"end_line":168,"end_character":77},"updated":"2022-03-30 10:14:08.000000000","message":"Drop this.\n\n  ...maintained in memory. If a quorum queue...","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":165,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":166,"context_line":"    cfg.IntOpt(\u0027rabbit_quroum_max_memory_bytes\u0027,"},{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":169,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"24ff243e_0c7479fa","line":168,"range":{"start_line":168,"start_character":69,"end_line":168,"end_character":77},"in_reply_to":"287ff512_424fd0ed","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":169,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"},{"line_number":172,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":173,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"33b13500_9b3a5754","line":170,"range":{"start_line":170,"start_character":39,"end_line":170,"end_character":43},"updated":"2022-03-30 10:14:08.000000000","message":"This","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"               default\u003d0,"},{"line_number":168,"context_line":"               help\u003d\u0027By default all messages are maintained in memory and so \u0027"},{"line_number":169,"context_line":"               \u0027if a quorum queue grows in length it can put memory \u0027"},{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"},{"line_number":172,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":173,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"cec7c790_963294aa","line":170,"range":{"start_line":170,"start_character":39,"end_line":170,"end_character":43},"in_reply_to":"33b13500_9b3a5754","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"},{"line_number":172,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":173,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":174,"context_line":"    cfg.IntOpt(\u0027rabbit_transient_queues_ttl\u0027,"},{"line_number":175,"context_line":"               min\u003d1,"},{"line_number":176,"context_line":"               default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":11,"id":"43fe5fc8_151e3239","line":173,"range":{"start_line":173,"start_character":39,"end_line":173,"end_character":55},"updated":"2022-03-30 10:14:08.000000000","message":"don\u0027t set a limit ?","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               \u0027pressure on a cluster. this option can limit the number \u0027"},{"line_number":171,"context_line":"               \u0027of memory bytes used by the quorum queue. \u0027"},{"line_number":172,"context_line":"               \u0027Used only when rabbit_quorum_queue is enabled, \u0027"},{"line_number":173,"context_line":"               \u0027Default 0 which means dont set a value.\u0027),"},{"line_number":174,"context_line":"    cfg.IntOpt(\u0027rabbit_transient_queues_ttl\u0027,"},{"line_number":175,"context_line":"               min\u003d1,"},{"line_number":176,"context_line":"               default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":11,"id":"504b15e6_ef21a587","line":173,"range":{"start_line":173,"start_character":39,"end_line":173,"end_character":55},"in_reply_to":"43fe5fc8_151e3239","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def _get_queue_arguments(rabbit_ha_queues, rabbit_queue_ttl,"},{"line_number":217,"context_line":"                         rabbit_quorum_queue,"},{"line_number":218,"context_line":"                         rabbit_quorum_queue_config):"},{"line_number":219,"context_line":"    \"\"\"Construct the arguments for declaring a queue."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    If the rabbit_ha_queues option is set, we try to declare a mirrored queue"}],"source_content_type":"text/x-python","patch_set":11,"id":"848a5564_ad16445c","line":218,"range":{"start_line":218,"start_character":25,"end_line":218,"end_character":51},"updated":"2022-03-30 10:14:08.000000000","message":"Why pass through a dict? Could you just pass through the raw options? It would certainly be easier to understand (at least IMO). If you want to use a container, at least use a named tuple please","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def _get_queue_arguments(rabbit_ha_queues, rabbit_queue_ttl,"},{"line_number":217,"context_line":"                         rabbit_quorum_queue,"},{"line_number":218,"context_line":"                         rabbit_quorum_queue_config):"},{"line_number":219,"context_line":"    \"\"\"Construct the arguments for declaring a queue."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    If the rabbit_ha_queues option is set, we try to declare a mirrored queue"}],"source_content_type":"text/x-python","patch_set":11,"id":"1765ad6c_1ec145bd","line":218,"range":{"start_line":218,"start_character":25,"end_line":218,"end_character":51},"in_reply_to":"848a5564_ad16445c","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"}],"releasenotes/notes/add-quorum-control-configurations-beed79811ff97ba2.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8aedece7c610c37945c21a7792ab1e183a86f1b7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add quorum configuration x-max-in-memory-length, x-max-in-memory-bytes,"},{"line_number":5,"context_line":"    x-delivery-limit which control the quorum queue memory usage and handle"},{"line_number":6,"context_line":"    the message poisoning problem"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6fbae362_d9f19501","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":51},"updated":"2022-03-30 10:14:08.000000000","message":"nit: ``x-max-in-memory-length``\n\nDitto for the other three. Also, can you wrap at \u003c\u003d 79 characters?","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"},{"author":{"_account_id":31039,"name":"hamza","email":"hamalq@verizonmedia.com","username":"hamalq"},"change_message_id":"068dad86bc97a8fb545b6a26fcfac17e82fe88a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add quorum configuration x-max-in-memory-length, x-max-in-memory-bytes,"},{"line_number":5,"context_line":"    x-delivery-limit which control the quorum queue memory usage and handle"},{"line_number":6,"context_line":"    the message poisoning problem"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"352fed25_8c7cc09e","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":51},"in_reply_to":"6fbae362_d9f19501","updated":"2022-03-31 18:51:48.000000000","message":"Done","commit_id":"4956b4f72b8b1ced127cb74b6705fea25024793d"}]}