)]}'
{"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f530171a0523018b496c52ddf3517f5c1e02b775","unresolved":true,"context_lines":[{"line_number":1008,"context_line":"        self.assertRaises(oslo_messaging.MessageDeliveryFailure,"},{"line_number":1009,"context_line":"                          self.connection.ensure, mock_callback,"},{"line_number":1010,"context_line":"                          retry\u003d4)"},{"line_number":1011,"context_line":"        # TODO(stephenfin): Remove when we drop support for kombu \u003c 5.2.4"},{"line_number":1012,"context_line":"        expected \u003d 5"},{"line_number":1013,"context_line":"        if kombu.VERSION \u003c (5, 2, 4):"},{"line_number":1014,"context_line":"            expected \u003d 6"},{"line_number":1015,"context_line":"        self.assertEqual(expected, mock_callback.call_count)"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    def test_ensure_one_retry(self):"},{"line_number":1018,"context_line":"        mock_callback \u003d mock.Mock(side_effect\u003dIOError)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4aeb695_bcb32b45","line":1015,"range":{"start_line":1011,"start_character":7,"end_line":1015,"end_character":60},"updated":"2022-04-06 07:17:31.000000000","message":"Zed\u0027s UC support kombu 5.2.4. Can\u0027t we simply pin the kombu version to 5.2.4 in our requirements rather than checking the version in tests?\n\nAlso I suppose we want to backport this fix so maybe the version of the code given by this patch set could fit well with stable branches, thoughts?\n\nhttps://opendev.org/openstack/requirements/src/branch/master/upper-constraints.txt#L502\nhttps://opendev.org/openstack/oslo.messaging/src/branch/master/requirements.txt#L27","commit_id":"723513a9d95b6d7678cc851afdfafba41120693c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e33bf75b0a1f26441865782b81a0e5286ab3dba","unresolved":true,"context_lines":[{"line_number":1008,"context_line":"        self.assertRaises(oslo_messaging.MessageDeliveryFailure,"},{"line_number":1009,"context_line":"                          self.connection.ensure, mock_callback,"},{"line_number":1010,"context_line":"                          retry\u003d4)"},{"line_number":1011,"context_line":"        # TODO(stephenfin): Remove when we drop support for kombu \u003c 5.2.4"},{"line_number":1012,"context_line":"        expected \u003d 5"},{"line_number":1013,"context_line":"        if kombu.VERSION \u003c (5, 2, 4):"},{"line_number":1014,"context_line":"            expected \u003d 6"},{"line_number":1015,"context_line":"        self.assertEqual(expected, mock_callback.call_count)"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    def test_ensure_one_retry(self):"},{"line_number":1018,"context_line":"        mock_callback \u003d mock.Mock(side_effect\u003dIOError)"}],"source_content_type":"text/x-python","patch_set":1,"id":"79c38bdc_d67f2893","line":1015,"range":{"start_line":1011,"start_character":7,"end_line":1015,"end_character":60},"in_reply_to":"c4aeb695_bcb32b45","updated":"2022-04-22 09:20:06.000000000","message":"Yeah, it\u0027s easier to do this for now. We can always bump the minimum at a later date","commit_id":"723513a9d95b6d7678cc851afdfafba41120693c"}]}