)]}'
{"id":"openstack%2Foslo.messaging~839530","triplet_id":"openstack%2Foslo.messaging~stable%2Fwallaby~Ife62a7d76022908f0dc6a77f1ad607cb2fbd3e8f","project":"openstack/oslo.messaging","branch":"stable/wallaby","topic":"amqp1-reset-race-stable/xena-stable/wallaby","attention_set":{},"removed_from_attention_set":{"28522":{"account":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"last_update":"2024-01-15 17:48:53.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ife62a7d76022908f0dc6a77f1ad607cb2fbd3e8f","subject":"amqp1: fix race when reconnecting","status":"ABANDONED","created":"2022-04-27 11:45:11.000000000","updated":"2024-01-15 17:48:53.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":821764,"cherry_pick_of_patch_set":1,"meta_rev_id":"9322e570bfd3f699726404d97aa7bdbafa899cca","_number":839530,"virtual_id_number":839530,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-04-27 15:08:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"all":[{"value":1,"date":"2022-06-28 23:30:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-06-13 15:23:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}],"CC":[{"_account_id":9257,"name":"John Eckersberg","email":"jeckersb@redhat.com","username":"jeckersb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-04-27 11:45:11.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":9257,"name":"John Eckersberg","email":"jeckersb@redhat.com","username":"jeckersb"},"state":"CC"},{"updated":"2022-04-27 13:18:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-04-27 13:33:23.000000000","updated_by":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"reviewer":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"state":"CC"},{"updated":"2022-06-13 15:23:01.000000000","updated_by":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"reviewer":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"state":"REVIEWER"},{"updated":"2022-06-28 23:30:59.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"}],"messages":[{"id":"fcf6b2f91a2767633e6222c4de60afc3ebdb2a94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2022-04-27 11:45:11.000000000","message":"Patch Set 1: Cherry Picked from branch stable/xena.","accounts_in_message":[],"_revision_number":1},{"id":"1de0a653116a51e128a45326097efa1491524b80","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2022-04-27 11:46:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1f26edd1129fa8cc6606ef1d345b3770f864772f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-27 13:18:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/79c2eb9cd0a44b5da4031348fcd2222b : SUCCESS in 1h 15m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a13fa55b612a49fc9a5ef348837dd5fa : SUCCESS in 5m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/290e82b62cf44702bca998794d6594ef : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/804fbdae29b24576b94d7c605cd6d30c : TIMED_OUT in 41m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fa8435286cea49ba889a94f6c691210d : SUCCESS in 6m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d07cc3f210bd4b0a858628120e0f9bfc : SUCCESS in 5m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8e2e26a0259841519e7f1da9fb423e26 : SUCCESS in 4m 27s\n- oslo.messaging-tox-py38-func-scenario01 https://zuul.opendev.org/t/openstack/build/d9471cdc5bc1467190b0c167c8b671a3 : SUCCESS in 5m 29s\n- oslo.messaging-tox-py38-func-scenario02 https://zuul.opendev.org/t/openstack/build/a75279f9ba0b4c398eb45f4a63945c69 : FAILURE in 6m 24s (non-voting)\n- oslo.messaging-tox-py38-func-scenario03 https://zuul.opendev.org/t/openstack/build/f41ae15654ef4480bd49286daddbc7ff : FAILURE in 5m 56s (non-voting)\n- oslo.messaging-tox-py38-func-scenario04 https://zuul.opendev.org/t/openstack/build/0e9da79a93784d7887f1630f67b52ab9 : FAILURE in 4m 40s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/822b921b6bdb496f910602361119c817 : SUCCESS in 1h 13m 31s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/e5706ff5f8c6472698f0fc89e7eb7506 : SUCCESS in 1h 19m 20s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/76d3d93a746e463c90ecc4aa059f49d7 : SUCCESS in 1h 12m 33s (non-voting)\n- oslo.messaging-grenade https://zuul.opendev.org/t/openstack/build/bfbe2efe779a4158b982d2dc31c39991 : SUCCESS in 58m 42s (non-voting)\n- oslo.messaging-grenade-multinode https://zuul.opendev.org/t/openstack/build/1a66017aa2074b7b892cd00d35f6aa92 : SUCCESS in 1h 12m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"58a41828660952774251b2ca6163330b70e668d6","author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"date":"2022-04-27 13:33:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8b2af86bbf127fa190ef6fb04e60a5d6ad7d81ea","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-27 15:08:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b8c11bb849544f33875e583602f70251 : SUCCESS in 1h 28m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e7d89b2bc6a24b398319c869da314a53 : SUCCESS in 6m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba27ae538fd645e98dee9778a1462b29 : SUCCESS in 4m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6ea5d032a6e24b4a86617551de2d3859 : SUCCESS in 5m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9c3c2af1d31f44c39a8091accd64d243 : SUCCESS in 6m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8dbed6d2ad0a48b183d9fb52954b5bde : SUCCESS in 7m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7014a9d0c8f14e149565bbc563ac9843 : SUCCESS in 4m 38s\n- oslo.messaging-tox-py38-func-scenario01 https://zuul.opendev.org/t/openstack/build/eac98e6d3c6c4e518dda067af354c54f : SUCCESS in 5m 49s\n- oslo.messaging-tox-py38-func-scenario02 https://zuul.opendev.org/t/openstack/build/334dec013ba54fb68e7a4cfcbbb3ccff : FAILURE in 7m 12s (non-voting)\n- oslo.messaging-tox-py38-func-scenario03 https://zuul.opendev.org/t/openstack/build/80c9377e22604ecd90c657ca37c856bc : FAILURE in 5m 39s (non-voting)\n- oslo.messaging-tox-py38-func-scenario04 https://zuul.opendev.org/t/openstack/build/3319f9228c6c44c38bdf0be7b40020fe : FAILURE in 5m 49s (non-voting)\n- oslo.messaging-src-dsvm-full-rabbit https://zuul.opendev.org/t/openstack/build/5d6f96a383264fdfb781dfbb5fe7f371 : SUCCESS in 1h 24m 09s\n- oslo.messaging-src-dsvm-full-amqp1-hybrid https://zuul.opendev.org/t/openstack/build/1d0b0ff778e748dfb3a9a3abb620655d : SUCCESS in 1h 27m 06s (non-voting)\n- oslo.messaging-src-dsvm-full-kafka-hybrid https://zuul.opendev.org/t/openstack/build/cc16a8918242430bad9fcbd07d76f26e : SUCCESS in 1h 27m 28s (non-voting)\n- oslo.messaging-grenade https://zuul.opendev.org/t/openstack/build/dce8c9c7a1f84243aa615935baacb1c3 : SUCCESS in 1h 02m 41s (non-voting)\n- oslo.messaging-grenade-multinode https://zuul.opendev.org/t/openstack/build/52f9c661416145b6b09218515e7f0918 : SUCCESS in 1h 13m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"aceb1312724ceecbd321b90459973040368e367a","author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"date":"2022-06-13 15:23:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"331ce9c38928975a17bdcd5b5a141c062542cb52","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-06-28 23:30:59.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9322e570bfd3f699726404d97aa7bdbafa899cca","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"date":"2024-01-15 17:48:53.000000000","message":"Abandoned\n\nThe wallaby release is not anymore maintain so we can abandon that patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fa9fdfd1c90fe303f642be8cb1a55a7d3670d2e3","revisions":{"fa9fdfd1c90fe303f642be8cb1a55a7d3670d2e3":{"kind":"REWORK","_number":1,"created":"2022-04-27 11:45:11.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/30/839530/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.messaging","ref":"refs/changes/30/839530/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/30/839530/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/30/839530/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.messaging refs/changes/30/839530/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.messaging refs/changes/30/839530/1"}}},"commit":{"parents":[{"commit":"5d6fd1a176a47ffdc55223b990c466917ded9449","subject":"[rabbit] use retry parameters during notification sending","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/5d6fd1a176a47ffdc55223b990c466917ded9449"}]}],"author":{"name":"John Eckersberg","email":"jeckersb@redhat.com","date":"2021-11-08 20:19:45.000000000","tz":-300},"committer":{"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","date":"2022-04-27 11:45:11.000000000","tz":0},"subject":"amqp1: fix race when reconnecting","message":"amqp1: fix race when reconnecting\n\nCurrently this is how reconnect works:\n\n- pyngus detects failure and invokes callback\n  Controller.connection_failed() which in turn calls\n  Controller._handle_connection_loss()\n\n- The first thing that _handle_connection_loss does is to set\n  self.addresser to None (important later)\n\n- Then it defers _do_reconnect after a delay (normally 1 second)\n\n- (1 second passes)\n\n- _do_reconnect calls _hard_reset which resets the controller state\n\nHowever, there is a race here.  This can happen:\n\n- The above, up until it defers and waits for 1 second\n\n- Controller.send() is invoked on a task\n\n- A new Sender is created, and critically because self.reply_link\n  still exists and is active, we call sender.attach and pass in\n  self.addresser.  Remember _handle_connection_loss sets\n  self.addresser to None.\n\n- Eventually Sender.attach throws an AttributeError because it\n  attempts to call addresser.resolve() but addresser is None\n\nThe reason this happens is because although the connection is dead,\nthe controller state is still half-alive because _hard_reset hasn\u0027t\nbeen called yet since it\u0027s deferred one second in _do_reconnect.\n\nThe fix here is to move _hard_reset out of _do_reconnect and directly\ninto _handle_connection_loss.  The eventloop is woken up immediately\nto process _hard_reset but _do_reconnect is still deferred as before\nso as to retain the desired reconnect backoff behavior.\n\nCloses-Bug: #1941652\nChange-Id: Ife62a7d76022908f0dc6a77f1ad607cb2fbd3e8f\n(cherry picked from commit 02a38f507d8f0c377a2ef468e3497b5e897f1b09)\n(cherry picked from commit d57eccd862c1a008f9b1f868c0832e938a75415e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/fa9fdfd1c90fe303f642be8cb1a55a7d3670d2e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.messaging/commit/fa9fdfd1c90fe303f642be8cb1a55a7d3670d2e3"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}