)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"39403cc0687f2458c60984279af3a4a1097bc0aa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"should be send to, we use Target object to create"},{"line_number":15,"context_line":"queues. Then, message can be send to the \u0027real\u0027 node"},{"line_number":16,"context_line":"which shoule received it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If63235640e0b8e6ec8690a4edaefa1b303705ac6"},{"line_number":19,"context_line":"Closes-bug: #1301723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa98f980_8cefb8b0","line":17,"updated":"2014-09-11 09:07:33.000000000","message":"Suggested rewrite of this:\n\nzmq: Send message to correct endpoint for directed messages\n\nIf set the zmq driver needs to use the topic.server attribute\nto ensure that messages directed to a specific endpoint are\nsent to the correct server rather than being randomly sent\nto endpoints advertising the required topic.","commit_id":"d4a83ceb9058335a5e85df67278b66565339b7e8"}],"oslo/messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"52bea9785cb20115e6e670984b3dea1e1bd8e03e","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        if target.fanout:"},{"line_number":941,"context_line":"            # NOTE(ewindisch): fanout~ is used because it avoid splitting on"},{"line_number":942,"context_line":"            # and acts as a non-subtle hint to the matchmaker and ZmqProxy."},{"line_number":943,"context_line":"            topic \u003d \u0027fanout~\u0027 + topic"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        if target.server:"},{"line_number":946,"context_line":"            target.topic \u003d \u0027.\u0027.join([topic, target.server])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_0098cd1a","line":943,"updated":"2014-05-06 11:45:34.000000000","message":"all you should need is\n\n  elif target.server:\n      topic \u003d \u0027%s.%s\u0027 % (topic, target.server)","commit_id":"a3855ffbb9cdb546283bd76672ac4480fbe56917"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"eee9312a20a6433ac522db0d86af5a0c472edf99","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        if target.fanout:"},{"line_number":941,"context_line":"            # NOTE(ewindisch): fanout~ is used because it avoid splitting on"},{"line_number":942,"context_line":"            # and acts as a non-subtle hint to the matchmaker and ZmqProxy."},{"line_number":943,"context_line":"            topic \u003d \u0027fanout~\u0027 + topic"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        if target.server:"},{"line_number":946,"context_line":"            target.topic \u003d \u0027.\u0027.join([topic, target.server])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_0f66a051","line":943,"in_reply_to":"9ad9bd40_0098cd1a","updated":"2014-05-28 11:24:23.000000000","message":"I really think this is where the bug is\n\nIn oslo-incubator, a call to rpc.cast() or rpc.call() for a specific node will be passed topic\u003d\u0027topic.server\u0027 and we pass that string onto multi_send()\n\nIn oslo.messaging the target object contains the topic and server attributes, so we need to concatenate them into a string before passing them to multi_send()","commit_id":"a3855ffbb9cdb546283bd76672ac4480fbe56917"}]}
