)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"37cc6f72b74dc149908b130450f399b259dee2ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f23049d1_8f912c43","updated":"2022-08-03 07:10:56.000000000","message":"Looks sensible.\nCan you add tests and a release note?","commit_id":"1efdc7a8e4ae4fa1972d735364537c532cf34f86"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ffe6f9ed52834e3f45b84d121543105c1d0329c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0567051b_6498a1ed","in_reply_to":"d53214db_8ae6ea8d","updated":"2022-08-03 14:32:29.000000000","message":"Excellent! Thank you sir!","commit_id":"1efdc7a8e4ae4fa1972d735364537c532cf34f86"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"c05c375f9df1e6080a50f0fb3abcbea9d041bbb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d53214db_8ae6ea8d","in_reply_to":"f23049d1_8f912c43","updated":"2022-08-03 12:42:49.000000000","message":"Thanks!\nAdded two tests to validate the retry on BufferError and the abort on KafkaError. For good measure I also checked they pass with the previous version of impl_kafka.py. Also added the release-note.","commit_id":"1efdc7a8e4ae4fa1972d735364537c532cf34f86"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ffe6f9ed52834e3f45b84d121543105c1d0329c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6dc65052_f214efc1","updated":"2022-08-03 14:32:29.000000000","message":"LGTM, waiting for the CI\u0027s outcome.","commit_id":"d97ceb6e32c3e26f31ef0532750cdf3f011e0848"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b034e100eb675b202eaa69fa711c2abdb796932e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c475a0ee_8d663883","updated":"2022-10-11 08:48:25.000000000","message":"Actually, I have found an issue with this - it never resets ``poll`` back to 0.","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"12e3e45393dfbcf850afcefc4710d3e8f8d1fc38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21692a63_b00fc7f5","updated":"2022-11-17 09:12:33.000000000","message":"Hello!\nAny news about this?","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"581b1ca96e9ea23ede311d56b946fdc5b1149920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6352beac_00620159","updated":"2022-10-04 14:36:14.000000000","message":"Hey team, is there any issue with that patch? Can we move forward?","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf3a44cf71f5718b82396dc45e25b58ad95b7af9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38b17908_b0b2e549","updated":"2022-10-11 08:43:54.000000000","message":"I guess this deserves a W+1 as it has 2x CR+2.","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"83ad4d7699a4c2d3e86c8387e94002f7152c2d53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f6985ed_aa29e05a","updated":"2022-12-21 06:16:35.000000000","message":"LGTM. The concern by Radolsaw was already answered.","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"2c155e8a30e71008bea902335433bf6146c66f6b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c01e31d8_6a1899a1","in_reply_to":"c475a0ee_8d663883","updated":"2022-10-20 14:10:26.000000000","message":"Hi!\nIt\u0027s been a while so I had to re-read the whole thing!\n\nFrom the point of view of the caller of notify_send, before that patch, we would run _produce_message which would call self.producer.produce and do one of these:\n1. Success, break out of the loop, poll(0), and return to notify_send which returns\n2. Fail with a KafkaException, LOG an error message, break out of the while True loop, poll(0), and return to notify_send which returns\n3. Fail with a BufferError, call self.producer.poll(0.5), and loop back to the call to self.producer.produce\n\nWith the proposed patch:\nnotify_send calls _produce_message with a poll\u003d0 which in turns calls self.producer.produce and do one of these:\n1. Success, poll(0), return to notify_send which returns\n2. Fail with a KafkaException, poll(0), raise to notify_send which LOGs the error message, breaks out of its loop and returns\n3. Fail with a BufferError, raise to notify_send which LOGs a debug message, sets poll to 0.5 and loops back to the call to self.producer.produce\n\nFrom what I understand, in both cases, as long as the call to _produce_message fails with a BufferError, we poll(0.5). And as soon as _produce_message works (or fail with KafkaException), we end-up leaving notify_send. Subsequent calls to notify_send are started with poll\u003d0. Am I missing something there?","commit_id":"43f2224aacb668aa51de3d1274ff8939d8aa73ae"}],"releasenotes/notes/bug-1981093-kafka-dont-log-in-tpool-execute-fa50ceee2d55ebae.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ffe6f9ed52834e3f45b84d121543105c1d0329c9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1981093 \u003chttps://bugs.launchpad.net/oslo.messaging/+bug/1981093\u003e`_]"},{"line_number":5,"context_line":"    Pulls calls to logging functions out of impl_kafka._produce_message. Since"},{"line_number":6,"context_line":"    _produce_message is called through tpool.execute, calling logging functions"},{"line_number":7,"context_line":"    inside _produce_message could cause subsequent calls to logging functions"},{"line_number":8,"context_line":"    to deadlock."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2f6e3ec1_96ba78fb","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":20},"updated":"2022-08-03 14:32:29.000000000","message":"Could be surrounded with rst syntax \"`\":\n\n``_produce_message``.\n\nBut LGTM as it is now.","commit_id":"d97ceb6e32c3e26f31ef0532750cdf3f011e0848"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"d3aefaaaf3cf85462caee8e4c0b267af5c25ead7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1981093 \u003chttps://bugs.launchpad.net/oslo.messaging/+bug/1981093\u003e`_]"},{"line_number":5,"context_line":"    Pulls calls to logging functions out of impl_kafka._produce_message. Since"},{"line_number":6,"context_line":"    _produce_message is called through tpool.execute, calling logging functions"},{"line_number":7,"context_line":"    inside _produce_message could cause subsequent calls to logging functions"},{"line_number":8,"context_line":"    to deadlock."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f45e432e_3581caf5","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":20},"in_reply_to":"2f6e3ec1_96ba78fb","updated":"2022-08-03 15:36:33.000000000","message":"Done","commit_id":"d97ceb6e32c3e26f31ef0532750cdf3f011e0848"}]}