)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d4ddc7f538c6dc500b2ad6e9095e2f2b264502","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We already expose functions to handle the instantiation"},{"line_number":10,"context_line":"of classes such as RPCServer and RPCTransport but the"},{"line_number":11,"context_line":"same was never done for RPCClient so the API is"},{"line_number":12,"context_line":"inconsistent in it\u0027s enforcement."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This adds a get_rpc_client function that should be used"},{"line_number":15,"context_line":"instead of instatiating the RPCClient class directly to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f57e1e4_75bef579","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":20},"updated":"2022-10-25 07:48:54.000000000","message":"its","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc66f572010b77de6ab8754ec2b4bbc344d75091","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We already expose functions to handle the instantiation"},{"line_number":10,"context_line":"of classes such as RPCServer and RPCTransport but the"},{"line_number":11,"context_line":"same was never done for RPCClient so the API is"},{"line_number":12,"context_line":"inconsistent in it\u0027s enforcement."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This adds a get_rpc_client function that should be used"},{"line_number":15,"context_line":"instead of instatiating the RPCClient class directly to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a7a0ba7_60055c78","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":20},"in_reply_to":"1f57e1e4_75bef579","updated":"2022-10-25 13:42:56.000000000","message":"Done","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d4ddc7f538c6dc500b2ad6e9095e2f2b264502","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9cdb173f_68e5e50d","updated":"2022-10-25 07:48:54.000000000","message":"Some nits inline, nothing very important.","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"932f837129cd503042f6719fc8a4583050045bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"575b6bdc_6529500a","updated":"2022-11-21 09:01:02.000000000","message":"Just one inline comment, else LGTM","commit_id":"4ead7cb2dcf376032f7bf9532a375256db6d3784"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c00e4fb15fef2d1632f310532017cfd7a45231e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01eabbad_d344555d","updated":"2022-10-25 11:43:08.000000000","message":"done :)","commit_id":"4ead7cb2dcf376032f7bf9532a375256db6d3784"}],"oslo_messaging/rpc/client.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d4ddc7f538c6dc500b2ad6e9095e2f2b264502","unresolved":true,"context_lines":[{"line_number":270,"context_line":"    method.  For further information see the cast() and call() methods."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    The default target used for all subsequent calls and casts is supplied to"},{"line_number":273,"context_line":"    the RPCClient constructor.  The client uses the target to control how the"},{"line_number":274,"context_line":"    RPC request is delivered to a server.  If only the target\u0027s topic (and"},{"line_number":275,"context_line":"    optionally exchange) are set, then the RPC can be serviced by any server"},{"line_number":276,"context_line":"    that is listening to that topic (and exchange).  If multiple servers are"}],"source_content_type":"text/x-python","patch_set":3,"id":"0786f54a_7d4b1423","side":"PARENT","line":273,"updated":"2022-10-25 07:48:54.000000000","message":"There is not really a need to change this wording. It holds true still.","commit_id":"e5e70a5d894b576b3de705c5f55f9704bb8e593e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc66f572010b77de6ab8754ec2b4bbc344d75091","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    method.  For further information see the cast() and call() methods."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    The default target used for all subsequent calls and casts is supplied to"},{"line_number":273,"context_line":"    the RPCClient constructor.  The client uses the target to control how the"},{"line_number":274,"context_line":"    RPC request is delivered to a server.  If only the target\u0027s topic (and"},{"line_number":275,"context_line":"    optionally exchange) are set, then the RPC can be serviced by any server"},{"line_number":276,"context_line":"    that is listening to that topic (and exchange).  If multiple servers are"}],"source_content_type":"text/x-python","patch_set":3,"id":"d61a1ec7_376d3e60","side":"PARENT","line":273,"in_reply_to":"0786f54a_7d4b1423","updated":"2022-10-25 13:42:56.000000000","message":"Done","commit_id":"e5e70a5d894b576b3de705c5f55f9704bb8e593e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d4ddc7f538c6dc500b2ad6e9095e2f2b264502","unresolved":true,"context_lines":[{"line_number":387,"context_line":"        \"\"\""},{"line_number":388,"context_line":"        if _manual_load:"},{"line_number":389,"context_line":"            LOG.warning(\"Using RPCClient manually to instantiate client. \""},{"line_number":390,"context_line":"                        \"Please use get_rpc_client to obtain a RPC client \""},{"line_number":391,"context_line":"                        \"instance.\")"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if serializer is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"65333177_554e18b7","line":390,"range":{"start_line":390,"start_character":61,"end_line":390,"end_character":62},"updated":"2022-10-25 07:48:54.000000000","message":"an","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc66f572010b77de6ab8754ec2b4bbc344d75091","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        \"\"\""},{"line_number":388,"context_line":"        if _manual_load:"},{"line_number":389,"context_line":"            LOG.warning(\"Using RPCClient manually to instantiate client. \""},{"line_number":390,"context_line":"                        \"Please use get_rpc_client to obtain a RPC client \""},{"line_number":391,"context_line":"                        \"instance.\")"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if serializer is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a521968f_7331735d","line":390,"range":{"start_line":390,"start_character":61,"end_line":390,"end_character":62},"in_reply_to":"65333177_554e18b7","updated":"2022-10-25 13:42:56.000000000","message":"Done","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32d4ddc7f538c6dc500b2ad6e9095e2f2b264502","unresolved":true,"context_lines":[{"line_number":556,"context_line":"    :param transport: the messaging transport"},{"line_number":557,"context_line":"    :type transport: Transport"},{"line_number":558,"context_line":"    :param target: the exchange, topic and server to listen on"},{"line_number":559,"context_line":"    :type target: Target"},{"line_number":560,"context_line":"    \"\"\""},{"line_number":561,"context_line":"    return RPCClient(transport, target, _manual_load\u003dFalse, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"18af41c7_740d9a8a","line":559,"updated":"2022-10-25 07:48:54.000000000","message":"Could use documenting that kwargs are passed verbatim to the constructor.","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc66f572010b77de6ab8754ec2b4bbc344d75091","unresolved":false,"context_lines":[{"line_number":556,"context_line":"    :param transport: the messaging transport"},{"line_number":557,"context_line":"    :type transport: Transport"},{"line_number":558,"context_line":"    :param target: the exchange, topic and server to listen on"},{"line_number":559,"context_line":"    :type target: Target"},{"line_number":560,"context_line":"    \"\"\""},{"line_number":561,"context_line":"    return RPCClient(transport, target, _manual_load\u003dFalse, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ac22a0e_6b7004ba","line":559,"in_reply_to":"18af41c7_740d9a8a","updated":"2022-10-25 13:42:56.000000000","message":"Done","commit_id":"0120e64e5d324a1cef557d3150b9693f15447672"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"932f837129cd503042f6719fc8a4583050045bac","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                                     call_monitor_timeout)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class RPCClient(_BaseCallContext):"},{"line_number":262,"context_line":"    \"\"\"A class for invoking methods on remote RPC servers."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    The RPCClient class is responsible for sending method invocations to and"}],"source_content_type":"text/x-python","patch_set":4,"id":"218ac381_0a739718","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":15},"updated":"2022-11-21 09:01:02.000000000","message":"May could be worth to use debtcollector here to deprecate the usage at run https://docs.openstack.org/debtcollector/latest/user/usage.html#deprecating-anything-else\n\nThoughts?","commit_id":"4ead7cb2dcf376032f7bf9532a375256db6d3784"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1a8af23faa796bd8f94d37b898cbbed0a9f05bdf","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                                     call_monitor_timeout)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class RPCClient(_BaseCallContext):"},{"line_number":262,"context_line":"    \"\"\"A class for invoking methods on remote RPC servers."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    The RPCClient class is responsible for sending method invocations to and"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d04476d_9afca02c","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":15},"in_reply_to":"218ac381_0a739718","updated":"2022-11-21 09:07:14.000000000","message":"But the class itself is not deprecated. Would not it leak that way?","commit_id":"4ead7cb2dcf376032f7bf9532a375256db6d3784"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"56260c7ae4ec64c2be46ccc6405de59049635e5e","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                                     call_monitor_timeout)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class RPCClient(_BaseCallContext):"},{"line_number":262,"context_line":"    \"\"\"A class for invoking methods on remote RPC servers."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    The RPCClient class is responsible for sending method invocations to and"}],"source_content_type":"text/x-python","patch_set":4,"id":"d84381f5_150aa16a","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":15},"in_reply_to":"7d04476d_9afca02c","updated":"2022-11-24 10:01:40.000000000","message":"True.\nI was thinking that using debtcollector here could help users to transition to the new helper.","commit_id":"4ead7cb2dcf376032f7bf9532a375256db6d3784"}]}