)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"367d665a_a3f3dc0b","updated":"2022-12-06 14:38:56.000000000","message":"Hello,\n\nI\u0027d suggest to keep only the deprecation topic here and to split default their values changes to a new patch as you already did with 86617.\n\nhttps://review.opendev.org/c/openstack/oslo.messaging/+/866617\n\nAlso this patch could be the parent patch of 86617 rather than a separated topic.","commit_id":"09e76e1e8206a8b5247ca3b2934a196d2bb49901"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"8bda3f0830e708e7253feac6d8886f50ae06f86b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3efeec92_da9b5a72","updated":"2022-12-06 16:46:25.000000000","message":"Thank you for the review, Hervé! I agree that just removing the setting abruptly is rude, but is leaving the setting in place (as I do) and simply making it do nothing a violation of deprecation practice?\n\nMy concern is that simply marking it as deprecated (or changing the default, as in 866617) doesn\u0027t actually fix the bug if the user has the setting already present in their config. ","commit_id":"09e76e1e8206a8b5247ca3b2934a196d2bb49901"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"58acc4959ef56c1b2e5f600625711abaf70e8fda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ad7e811_ea107603","updated":"2022-12-05 18:13:29.000000000","message":"The code removed by this patch has been maintained for largely superstitious reasons. I do not know for certain that it\u0027s no longer needed :(","commit_id":"09e76e1e8206a8b5247ca3b2934a196d2bb49901"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"574772f3ccda90e5d054d122bfe68af9b8e96094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"896045d0_467903ac","in_reply_to":"3efeec92_da9b5a72","updated":"2023-01-10 14:40:50.000000000","message":"ok, then you should at least leave the doc text related to the setting. However you could a some details into this help text by saying something like \"this parameter is deprecated and will be ignored if used\"...\n\nI\u0027m adding Stephen to this review to get his feedback too.","commit_id":"09e76e1e8206a8b5247ca3b2934a196d2bb49901"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01e8b7cc71d7e6b945e223b886bd2f036c205d55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc9ada5b_1d75b6d1","updated":"2023-01-13 11:31:50.000000000","message":"Yeah, I agree with Herve. You\u0027ve effectively removed the option here since even if you can still set it, it doesn\u0027t actually do anything.\n\nIf this is broken enough to cause serious issues then we should deprecate the option and log a warning for users that have set it to a non-default value. We can then remove it in B.","commit_id":"f6cb313bbe70f7045177c9afcdde22bd0ebd8640"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dbc3fbf1f24f07cc44ec0e07c238bf5f4bcdc492","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7502a573_2dd54747","updated":"2023-01-13 11:34:57.000000000","message":"You can ignore the failures. Those were bugs in tox. They\u0027ve been fixed through [1] and [2]\n\n[1] https://github.com/tox-dev/tox/pull/2828\n[2] https://github.com/tox-dev/tox/pull/2849","commit_id":"f6cb313bbe70f7045177c9afcdde22bd0ebd8640"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"6a35f733e566d1f126ec4114f4514d73d8e1be98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97ad191c_95adc56f","updated":"2023-01-11 14:24:02.000000000","message":"recheck","commit_id":"f6cb313bbe70f7045177c9afcdde22bd0ebd8640"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_delay\u0027,"},{"line_number":108,"context_line":"                 default\u003d1.0,"},{"line_number":109,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":110,"context_line":"                 help\u003d\u0027How long to wait before reconnecting in response to an \u0027"},{"line_number":111,"context_line":"                      \u0027AMQP consumer cancel notification.\u0027),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027kombu_compression\u0027,"},{"line_number":113,"context_line":"               help\u003d\"EXPERIMENTAL: Possible values are: gzip, bz2. If not \""},{"line_number":114,"context_line":"                    \"set compression will not be used. This option may not \""}],"source_content_type":"text/x-python","patch_set":1,"id":"03bb7aaf_045f3675","side":"PARENT","line":111,"range":{"start_line":110,"start_character":17,"end_line":111,"end_character":58},"updated":"2022-12-06 14:38:56.000000000","message":"The description should remain here while this option is available. This is just a deprecation, not a removal.","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":611,"context_line":"        self.heartbeat_timeout_threshold \u003d \\"},{"line_number":612,"context_line":"            driver_conf.heartbeat_timeout_threshold"},{"line_number":613,"context_line":"        self.heartbeat_rate \u003d driver_conf.heartbeat_rate"},{"line_number":614,"context_line":"        self.kombu_reconnect_delay \u003d driver_conf.kombu_reconnect_delay"},{"line_number":615,"context_line":"        self.amqp_durable_queues \u003d driver_conf.amqp_durable_queues"},{"line_number":616,"context_line":"        self.amqp_auto_delete \u003d driver_conf.amqp_auto_delete"},{"line_number":617,"context_line":"        self.ssl \u003d driver_conf.ssl"}],"source_content_type":"text/x-python","patch_set":1,"id":"af66f93e_4f916960","side":"PARENT","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":70},"updated":"2022-12-06 14:38:56.000000000","message":"Same thing here. The deprecation period should leave a couple of months to user to allow them to migrate their code first before the final removal.","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"            recoverable_error_callback and recoverable_error_callback(exc)"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"            interval \u003d (self.kombu_reconnect_delay + interval"},{"line_number":942,"context_line":"                        if self.kombu_reconnect_delay \u003e 0"},{"line_number":943,"context_line":"                        else interval)"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"            info \u003d {\u0027err_str\u0027: exc, \u0027sleep_time\u0027: interval}"},{"line_number":946,"context_line":"            info.update(self._get_connection_info(conn_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"582ea4f8_f368792c","side":"PARENT","line":943,"range":{"start_line":941,"start_character":12,"end_line":943,"end_character":38},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":956,"context_line":"                          \u0027%(err_str)s. Trying again in \u0027"},{"line_number":957,"context_line":"                          \u0027%(sleep_time)d seconds.\u0027, info)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            # XXX(nic): when reconnecting to a RabbitMQ cluster"},{"line_number":960,"context_line":"            # with mirrored queues in use, the attempt to release the"},{"line_number":961,"context_line":"            # connection can hang \"indefinitely\" somewhere deep down"},{"line_number":962,"context_line":"            # in Kombu.  Blocking the thread for a bit prior to"},{"line_number":963,"context_line":"            # release seems to kludge around the problem where it is"},{"line_number":964,"context_line":"            # otherwise reproduceable."},{"line_number":965,"context_line":"            # TODO(sileht): Check if this is useful since we"},{"line_number":966,"context_line":"            # use kombu for HA connection, the interval_step"},{"line_number":967,"context_line":"            # should sufficient, because the underlying kombu transport"},{"line_number":968,"context_line":"            # connection object freed."},{"line_number":969,"context_line":"            if self.kombu_reconnect_delay \u003e 0:"},{"line_number":970,"context_line":"                LOG.trace(\u0027Delaying reconnect for %1.1f seconds ...\u0027,"},{"line_number":971,"context_line":"                          self.kombu_reconnect_delay)"},{"line_number":972,"context_line":"                time.sleep(self.kombu_reconnect_delay)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        def on_reconnection(new_channel):"},{"line_number":975,"context_line":"            \"\"\"Callback invoked when the kombu reconnects and creates"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8324f67_46174206","side":"PARENT","line":972,"range":{"start_line":959,"start_character":12,"end_line":972,"end_character":54},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":441,"context_line":"            with mock.patch(\u0027kombu.connection.Connection.connected\u0027,"},{"line_number":442,"context_line":"                            new_callable\u003dmock.PropertyMock,"},{"line_number":443,"context_line":"                            return_value\u003dFalse):"},{"line_number":444,"context_line":"                self.assertRaises(driver_common.Timeout,"},{"line_number":445,"context_line":"                                  conn.connection.consume, timeout\u003d0.01)"},{"line_number":446,"context_line":"                # Ensure a new channel have been setuped"},{"line_number":447,"context_line":"                self.assertNotEqual(channel, conn.connection.channel)"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"413ab8d8_86f97fcf","side":"PARENT","line":445,"range":{"start_line":444,"start_character":16,"end_line":445,"end_character":72},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":443,"context_line":"                            return_value\u003dFalse):"},{"line_number":444,"context_line":"                self.assertRaises("},{"line_number":445,"context_line":"                    oslo_messaging.exceptions.MessageDeliveryFailure,"},{"line_number":446,"context_line":"                    conn.connection.consume, timeout\u003d0.1)"},{"line_number":447,"context_line":"                # Ensure a new channel have been setuped"},{"line_number":448,"context_line":"                self.assertNotEqual(channel, conn.connection.channel)"},{"line_number":449,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6116c87d_3a6ba88b","line":446,"range":{"start_line":446,"start_character":45,"end_line":446,"end_character":56},"updated":"2022-12-06 14:38:56.000000000","message":"I think it should remain unchanged here, and keep this patch focused on the deprecation. This duration could be modified through a follow up patch.","commit_id":"09e76e1e8206a8b5247ca3b2934a196d2bb49901"}],"oslo_messaging/tests/functional/test_rabbitmq.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # correctly"},{"line_number":57,"context_line":"        self.config(heartbeat_timeout_threshold\u003d1,"},{"line_number":58,"context_line":"                    rpc_conn_pool_size\u003d1,"},{"line_number":59,"context_line":"                    kombu_reconnect_delay\u003d0,"},{"line_number":60,"context_line":"                    rabbit_retry_interval\u003d0,"},{"line_number":61,"context_line":"                    rabbit_retry_backoff\u003d0,"},{"line_number":62,"context_line":"                    enable_cancel_on_failover\u003denable_cancel_on_failover,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2eb14f3_ad33f43b","side":"PARENT","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":44},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"}],"oslo_messaging/tests/test_config_opts_proxy.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_invalid_value(self):"},{"line_number":72,"context_line":"        group \u003d \u0027oslo_messaging_rabbit\u0027"},{"line_number":73,"context_line":"        self.config(kombu_reconnect_delay\u003d5.0,"},{"line_number":74,"context_line":"                    group\u003dgroup)"},{"line_number":75,"context_line":"        url \u003d transport.TransportURL.parse("},{"line_number":76,"context_line":"            self.conf, \"rabbit:///?kombu_reconnect_delay\u003dinvalid_value\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2a3300ea_8c2bb144","side":"PARENT","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":45},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"28740bfa961b3e7109defdb3a42668db9f2577ec","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.config(kombu_reconnect_delay\u003d5.0,"},{"line_number":74,"context_line":"                    group\u003dgroup)"},{"line_number":75,"context_line":"        url \u003d transport.TransportURL.parse("},{"line_number":76,"context_line":"            self.conf, \"rabbit:///?kombu_reconnect_delay\u003dinvalid_value\""},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        self.assertRaises(ValueError, drv_cmn.ConfigOptsProxy, self.conf,"},{"line_number":79,"context_line":"                          url, group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1251b93a_3324b4b5","side":"PARENT","line":76,"range":{"start_line":76,"start_character":12,"end_line":76,"end_character":71},"updated":"2022-12-06 14:38:56.000000000","message":"ditto","commit_id":"2e81fac97344d1eacf4c56a1022f25256d52e7ab"}]}