)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c23b62142d32341210f9b4e9c38c18a94b009662","unresolved":true,"context_lines":[{"line_number":11,"context_line":"which results in various code paths never being traversed"},{"line_number":12,"context_line":"due to premature timeout exceptions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Bug: 1993149"},{"line_number":15,"context_line":"Change-Id: I103d2aa79b4bd2c331810583aeca53e22ee27a49"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3b48228b_59e857c0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":3},"updated":"2023-04-10 03:30:39.000000000","message":"Closes-Bug: #1993149","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb87928dba9ab5c08052ea24c44de612baec368d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"which results in various code paths never being traversed"},{"line_number":12,"context_line":"due to premature timeout exceptions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Bug: 1993149"},{"line_number":15,"context_line":"Change-Id: I103d2aa79b4bd2c331810583aeca53e22ee27a49"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ccc15404_7cc744a3","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":3},"in_reply_to":"3b48228b_59e857c0","updated":"2023-05-10 09:45:07.000000000","message":"Done","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"5f988f8b7c66add5330686040ea55793d4f70617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4f7f665_8d7f936a","updated":"2022-12-06 16:47:04.000000000","message":"I can\u0027t understand why this is -1 verified. Every voting test seems to have passed?","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"b3108310e2178249eab18ae5b0ebd0ac46929c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c0e49a7_ec73db02","updated":"2022-12-05 18:12:41.000000000","message":"I\u0027ve submitted two version of this fix. This is the messier but less-disruptive version. A (probably) better option is https://review.opendev.org/c/openstack/oslo.messaging/+/866616","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"18a571b595bd5a9fbe4831a36ebf283e188931e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56d45188_bea1c342","updated":"2022-12-09 20:36:04.000000000","message":"recheck","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"694205e064c26c7c2ca161e71f47cd0f1e9b5899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92ed320d_bc070b5f","updated":"2022-12-15 21:23:35.000000000","message":"recheck","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"82d65457222d796f35a67cad5a38eaba8869c522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4265028_e65bedd0","updated":"2022-12-20 14:51:23.000000000","message":"recheck","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac746a521382aab9b0f618ec59192a3f7af90eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ddf1a66_e151b332","updated":"2023-02-09 14:05:28.000000000","message":"This one seems fairly important - it causes issues when one of the RabbitMQ cluster nodes is down, and is a regression since Yoga.","commit_id":"722c59b92f17858efd609aad055e12b24b75d12d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a9839f72b5e06e834df283af83081bb865aa285d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bca75ed8_71567d45","updated":"2023-02-09 14:06:18.000000000","message":"recheck","commit_id":"722c59b92f17858efd609aad055e12b24b75d12d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8545880211d7eec8718acc9704fc78f9d2d67d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"791bd928_90866b4e","updated":"2023-02-09 14:05:47.000000000","message":"recheck\n\nsome tox patches merged","commit_id":"722c59b92f17858efd609aad055e12b24b75d12d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c23b62142d32341210f9b4e9c38c18a94b009662","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ccaf717_dec182ab","updated":"2023-04-10 03:30:39.000000000","message":"Instead of decreasing the default value, should we increase ACK_REQUEUE_EVERY_SECONDS_MAX ? The main concern with the current approach is it makes the system busier and increased ACK_REQUEUE_EVERY_SECONDS_MAX would results in a behavior more similar to past behaviors","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"254bbb431cd14214c48c8c2b1cc1cda88246123c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c19f25a_fe49f334","updated":"2023-03-28 02:05:34.000000000","message":"recheck","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"307f95b51b6b88149ae70d65ac9ebd2d16007dda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"333d82df_558aa07f","updated":"2023-03-20 10:28:49.000000000","message":"recheck\n\nhow about now?","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"99b36b977877f2eb6b66dbc2d74b6931b07a17fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70a7cb49_dfc88b5b","in_reply_to":"1ccaf717_dec182ab","updated":"2023-04-11 13:54:47.000000000","message":"I agree with Takashi, IMO we should increase the max rather than decrease the default.","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"e99880ce81f4bd2a4d5fec3d3f150fd0643277bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f390a11b_964362db","in_reply_to":"70a7cb49_dfc88b5b","updated":"2023-04-16 19:54:53.000000000","message":"Increasing ACK_REQUEUE_EVERY_SECONDS_MAX is certainly an easy fix! Would you suggest increasing it to 10 seconds to maintain the same ratio as in this patch?","commit_id":"0253db57ad2241c76e8a9f87ccc9c2d302fa78ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"30ca5291e173704ee3ecf444da23cf89fa94a3da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bc5600ce_890d3adc","updated":"2023-05-10 08:19:09.000000000","message":"Could someone please approve this? It\u0027s a fairly nasty regression that goes back to xena.","commit_id":"0602d1a10ac20c48fa35ad711355c79ee5b0ec77"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f807e8939b514e972865417f1c700c423cbe900d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45d22260_030d05a0","updated":"2023-05-10 09:58:57.000000000","message":"Thanks!","commit_id":"0602d1a10ac20c48fa35ad711355c79ee5b0ec77"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bb71ee713f08091aca41a7e1f59764d0e6e4f79d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"339c0792_440776d7","updated":"2023-05-18 10:38:57.000000000","message":"recheck oslo.messaging-src-dsvm-full-rabbit to get newer logs","commit_id":"0602d1a10ac20c48fa35ad711355c79ee5b0ec77"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ba90b43afdcb7f8bc38981df6071365f0d83fd32","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_delay\u0027,"},{"line_number":108,"context_line":"                 default\u003d0.1,"},{"line_number":109,"context_line":"                 min\u003d0.0,"},{"line_number":110,"context_line":"                 max\u003d0.5,"},{"line_number":111,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":112,"context_line":"                 help\u003d\u0027How long to wait (in seconds) before reconnecting in \u0027"},{"line_number":113,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"373aefdc_0c904cb9","line":110,"updated":"2023-01-30 10:22:09.000000000","message":"It seems worth tying this to the value of `ACK_REQUEUE_EVERY_SECONDS_MAX`, rather than a hard-coded value. I\u0027ve amended the patch to do this. Why did you choose 0.5s for the max value, and not a value closer to `ACK_REQUEUE_EVERY_SECONDS_MAX`? For example, `ACK_REQUEUE_EVERY_SECONDS_MAX * 0.9`","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb87928dba9ab5c08052ea24c44de612baec368d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_delay\u0027,"},{"line_number":108,"context_line":"                 default\u003d0.1,"},{"line_number":109,"context_line":"                 min\u003d0.0,"},{"line_number":110,"context_line":"                 max\u003d0.5,"},{"line_number":111,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":112,"context_line":"                 help\u003d\u0027How long to wait (in seconds) before reconnecting in \u0027"},{"line_number":113,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"70214a53_17192630","line":110,"in_reply_to":"373aefdc_0c904cb9","updated":"2023-05-10 09:45:07.000000000","message":"Done","commit_id":"9f8a7a958db60cbde35e269d9c43be0342f23efe"}]}
