)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5c22d896890a954a1ed558011da3c1dca78d6ae8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    ..."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"With heartbeat_rate\u003d3, the heartbeat_check will be executed more often:"},{"line_number":34,"context_line":"    heartbeat_timeout / heartbeat_rate / 2.0 \u003d 60 / 2 / 2.0 \u003d 10"},{"line_number":35,"context_line":"Frame flow:"},{"line_number":36,"context_line":"    T+0  --\u003e do nothing (60/3 \u003e 0)"},{"line_number":37,"context_line":"    T+10 --\u003e do nothing (60/3 \u003e 10)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"57ed749d_e9bc5581","line":34,"range":{"start_line":34,"start_character":52,"end_line":34,"end_character":53},"updated":"2023-07-14 08:05:14.000000000","message":"that should be 3, not 2","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"8b98ccd504ae06df46451c03c604e1a793337dc6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ..."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"With heartbeat_rate\u003d3, the heartbeat_check will be executed more often:"},{"line_number":34,"context_line":"    heartbeat_timeout / heartbeat_rate / 2.0 \u003d 60 / 2 / 2.0 \u003d 10"},{"line_number":35,"context_line":"Frame flow:"},{"line_number":36,"context_line":"    T+0  --\u003e do nothing (60/3 \u003e 0)"},{"line_number":37,"context_line":"    T+10 --\u003e do nothing (60/3 \u003e 10)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"505ceb9c_d975f59f","line":34,"range":{"start_line":34,"start_character":52,"end_line":34,"end_character":53},"in_reply_to":"57ed749d_e9bc5581","updated":"2023-08-08 13:24:36.000000000","message":"done","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e666eeb8926c575ec0d4a7ec1bc04de0e148530b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f65a3b2e_b398b3ee","updated":"2023-06-21 12:57:28.000000000","message":"Does this fix the \"missed heartbeats from client, timeout: 60s\" issue seen in RabbitMQ logs?","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"525e559354c5cfdb35f98d8acf1f65e2841a1171","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"040bd2bd_c22bd13f","updated":"2023-04-13 10:56:14.000000000","message":"Hi, this is affecting also us, we are reconfiguring heartbeat_rate in configuration with kolla-ansible config override, but it will be cool if default value will be finally the right one. Thanks!","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6baef3788bec6f035dd4a628facfd7dc1410ed3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59c53c93_019ece18","updated":"2023-07-18 04:54:24.000000000","message":"I was hoping to get some clarifications about my previous comment but seems people are facing so urgent situation (though workaround can be implemented easily as the option is configurable) so I\u0027ll nudge this.","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"bb143190d67d129a008ae5c8d68f4c80b4531915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96a069d9_9ddc2c9d","updated":"2023-07-13 15:45:05.000000000","message":"Is there anyone available for a small w+1 here? 😊","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3744f370c8ceeceabb62646140416cf4481d86d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bde8a04d_71402dbe","updated":"2023-07-14 11:00:17.000000000","message":"Isn\u0027t this the problem caused by usage of \u003e instead of \u003e\u003d in heartbeat_tick ? For me the problem appears in\n\n```\n    T+30 --\u003e do nothing (60/2 \u003e 30)\n```\n\nand replacing \u003e by \u003e\u003d would send the message at the proper timing\n\n\n```\n    T+0  --\u003e do nothing   (60/2 \u003e 0)\n    T+15 --\u003e do nothing   (60/2 \u003e 15)\n    T+30 --\u003e send a frame (60/2 \u003d 30)\n    T+45 --\u003e do nothing   (60/2 \u003c 45)\n```\n\nHowever this requires change in the underyling lib. I\u0027m ok with fixing updating the value as the immediate mitigation.","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"96b763535853e0d67b0a0a7e2d85218ca8583386","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b99d57a_323a21ca","updated":"2023-07-17 20:48:48.000000000","message":"Ping ?","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"aa27b2c964a2ee9521a561167bf59e5468741546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"411b7f7b_2f09166a","updated":"2023-06-06 13:24:29.000000000","message":"Who want a candy?","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"5c22d896890a954a1ed558011da3c1dca78d6ae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff23ba6d_6db165b6","updated":"2023-07-14 08:05:14.000000000","message":"spotted one small error in the commit message.\nrest LGTM.","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"5171161ac1dbadcf791b33ccc1a2b47ae9493bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f158f56b_4115385e","updated":"2023-05-04 08:22:57.000000000","message":"up","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"8b98ccd504ae06df46451c03c604e1a793337dc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89bbd13b_4a7697b8","in_reply_to":"bde8a04d_71402dbe","updated":"2023-08-08 13:24:36.000000000","message":"I am not even sure the \u003e\u003d would help, this is something we would need to test.\nAnd yes, updating the rate to 3 is a quick win in this situation","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"2c347192ba866a8a9c0b77cdaebaf5f115c56f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4de49dfe_2cae56c6","in_reply_to":"f65a3b2e_b398b3ee","updated":"2023-06-21 21:16:16.000000000","message":"It helps a little bit, but not that much.\nMost of the missed heartbeats are due to the fact that heartbeats are sent from a greenthread and not a pthread.\n\nEnabling heartbeat_in_pthreads option is helping a lot with the recent fix (see [1]).\n\n[1] https://opendev.org/openstack/oslo.messaging/commit/fd2381c723fe805b17aca1f80bfff4738fbe9628","commit_id":"1a387ee25b813fb8f0eab9dd86e02a7c4a421060"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aadeebedc8629b092bed2e236772914b70f0c57a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"68304247_0f425ca0","updated":"2023-09-14 01:45:09.000000000","message":"The only change made since last +A is in commit message so I\u0027ll approve this now.","commit_id":"36fb5bceabe08a982ebd52e4a8f005cd26fdf6b8"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e1c283537ff4a41fba2eab20b657129f4dc67999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f5160150_20f9584a","updated":"2023-10-11 10:44:24.000000000","message":"recheck","commit_id":"36fb5bceabe08a982ebd52e4a8f005cd26fdf6b8"}]}