)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9bc64b84d75699de8855a8abde4a5c760b03cbd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"159afff5_d44abd8a","updated":"2023-07-12 10:30:14.000000000","message":"Thanks !","commit_id":"ee13e53614239572647e1ee0d4bba7dca1a860a3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"25040759bebca00dc032e8029d2cbc118c34c955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fcdc67d_1788ca36","updated":"2023-09-29 08:51:57.000000000","message":"recheck","commit_id":"ee13e53614239572647e1ee0d4bba7dca1a860a3"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5372614bd04a5be15f62f88c980a3397906d380c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e7cde1e5_82dbb314","updated":"2023-10-11 10:43:54.000000000","message":"recheck","commit_id":"ee13e53614239572647e1ee0d4bba7dca1a860a3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8aaf305a3ff0e23dbe6c86d916c50a00340c7c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe264bc7_162fac84","updated":"2023-10-20 10:18:56.000000000","message":"recheck  are the func jobs still broken ?","commit_id":"ee13e53614239572647e1ee0d4bba7dca1a860a3"}],"oslo_messaging/_metrics/client.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"395fbf37028c0946a5f80bc09e004b07c4b78d87","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # we will facing an issue by trying to override the threading module."},{"line_number":42,"context_line":"    stdlib_threading \u003d threading"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"tmpdir \u003d tempfile.mkdtemp()"},{"line_number":45,"context_line":"tmp_filename \u003d \u0027metrics_collector.sock\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"oslo_messaging_metrics \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"af7c083b_daa9aebe","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":27},"updated":"2023-04-10 02:06:57.000000000","message":"IIUC this call creates a temporal directory when this module is loaded. We should not call this at this layer, otherwise for example oslo-config-generator can create this directory.","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5a71cdf787fe40dae063512daf5baf66d994723","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # we will facing an issue by trying to override the threading module."},{"line_number":42,"context_line":"    stdlib_threading \u003d threading"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"tmpdir \u003d tempfile.mkdtemp()"},{"line_number":45,"context_line":"tmp_filename \u003d \u0027metrics_collector.sock\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"oslo_messaging_metrics \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9ead62ad_0c4b6749","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":27},"in_reply_to":"6bc2260a_ccf11ef8","updated":"2023-06-27 12:05:21.000000000","message":"Done","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0f5c9d3f215a9abaa0dfc209fa335f7c1dfc2f06","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # we will facing an issue by trying to override the threading module."},{"line_number":42,"context_line":"    stdlib_threading \u003d threading"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"tmpdir \u003d tempfile.mkdtemp()"},{"line_number":45,"context_line":"tmp_filename \u003d \u0027metrics_collector.sock\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"oslo_messaging_metrics \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"6bc2260a_ccf11ef8","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":27},"in_reply_to":"af7c083b_daa9aebe","updated":"2023-05-17 09:06:08.000000000","message":"I agree with you","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"395fbf37028c0946a5f80bc09e004b07c4b78d87","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027metrics_buffer_size\u0027, default\u003d1000,"},{"line_number":51,"context_line":"               help\u003d\u0027Buffer size to store in oslo.messaging.\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027metrics_socket_file\u0027,"},{"line_number":53,"context_line":"               default\u003dos.path.join(tmpdir, tmp_filename),"},{"line_number":54,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":55,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027metrics_process_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"befcc9de_6a517c5d","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":57},"updated":"2023-04-10 02:06:57.000000000","message":"We can\u0027t really use this value as default because the value varies every time.\n(The default value in the generated config file does not match the actual default generated at every run time)\nWe probably should have used /var/run instead but updating the default might be too late.\n\nI personally prefer we just ignore the rule for this to avoid backword incompatibility.","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5a71cdf787fe40dae063512daf5baf66d994723","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027metrics_buffer_size\u0027, default\u003d1000,"},{"line_number":51,"context_line":"               help\u003d\u0027Buffer size to store in oslo.messaging.\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027metrics_socket_file\u0027,"},{"line_number":53,"context_line":"               default\u003dos.path.join(tmpdir, tmp_filename),"},{"line_number":54,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":55,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027metrics_process_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7986ae5_7423f830","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":57},"in_reply_to":"7ecd8eb0_ced5de24","updated":"2023-06-27 12:05:21.000000000","message":"Done","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0f5c9d3f215a9abaa0dfc209fa335f7c1dfc2f06","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(\u0027metrics_buffer_size\u0027, default\u003d1000,"},{"line_number":51,"context_line":"               help\u003d\u0027Buffer size to store in oslo.messaging.\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027metrics_socket_file\u0027,"},{"line_number":53,"context_line":"               default\u003dos.path.join(tmpdir, tmp_filename),"},{"line_number":54,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":55,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027metrics_process_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ecd8eb0_ced5de24","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":57},"in_reply_to":"befcc9de_6a517c5d","updated":"2023-05-17 09:06:08.000000000","message":"done","commit_id":"4cdf01f8e2910776f56fc44bf7e9f454aaa3efcf"}]}
