)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"544ab342_3138a3fb","updated":"2023-08-29 09:23:36.000000000","message":"Couple of nits. The -1 is for the logging at info level instead of debug.\n\nIs there any reason people _wouldn\u0027t_ want to do this? I wonder if we should issue a deprecation warning telling people to opt-in to the new behavior or get it by default in e.g. D?","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"79494ac856f05704f9fe5c4c686a8d1a0d947e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"47013bb4_c60bd65a","updated":"2024-01-12 16:04:26.000000000","message":"recheck","commit_id":"4614132ad01d7e4559c4ff43c1e7dba1c1bdb81e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b012692eb723a0de7513eb97d8f97767944dd175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eba06a3f_74c63f9b","updated":"2023-11-13 01:40:01.000000000","message":"recheck the tempest failure could be unrelated.","commit_id":"4614132ad01d7e4559c4ff43c1e7dba1c1bdb81e"}],"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":42,"context_line":"ACK_REQUEUE_EVERY_SECONDS_MAX \u003d 5.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QManager(object):"},{"line_number":46,"context_line":"    \"\"\"Queue Manager to build queue name for reply (and fanout) type."},{"line_number":47,"context_line":"    This class is used only when use_queue_manager is set to True in config"},{"line_number":48,"context_line":"    file."}],"source_content_type":"text/x-python","patch_set":5,"id":"dc7c6447_adb4ba5a","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":22},"updated":"2023-08-29 09:23:36.000000000","message":"nit: don\u0027t need this (all classes are new-style classes in Python 3)","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"4dea32dd6fa4ad2ad5b1696409a1b88c995c0d74","unresolved":true,"context_lines":[{"line_number":42,"context_line":"ACK_REQUEUE_EVERY_SECONDS_MAX \u003d 5.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QManager(object):"},{"line_number":46,"context_line":"    \"\"\"Queue Manager to build queue name for reply (and fanout) type."},{"line_number":47,"context_line":"    This class is used only when use_queue_manager is set to True in config"},{"line_number":48,"context_line":"    file."}],"source_content_type":"text/x-python","patch_set":5,"id":"75412922_fe43daba","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":22},"in_reply_to":"2e94ed81_ec902ca4","updated":"2024-01-10 13:33:05.000000000","message":"I agree it\u0027s better to have object to stay consistent and do a clean with another patch.","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":true,"context_lines":[{"line_number":42,"context_line":"ACK_REQUEUE_EVERY_SECONDS_MAX \u003d 5.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QManager(object):"},{"line_number":46,"context_line":"    \"\"\"Queue Manager to build queue name for reply (and fanout) type."},{"line_number":47,"context_line":"    This class is used only when use_queue_manager is set to True in config"},{"line_number":48,"context_line":"    file."}],"source_content_type":"text/x-python","patch_set":5,"id":"f1f1c606_965b5f01","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":22},"in_reply_to":"dc7c6447_adb4ba5a","updated":"2023-09-06 13:54:07.000000000","message":"all other classes in this files are using (object) notation, should I do differently againts consistency?","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68f35156de8a2fd1b86c7fa64c1f0fe1ac082095","unresolved":true,"context_lines":[{"line_number":42,"context_line":"ACK_REQUEUE_EVERY_SECONDS_MAX \u003d 5.0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QManager(object):"},{"line_number":46,"context_line":"    \"\"\"Queue Manager to build queue name for reply (and fanout) type."},{"line_number":47,"context_line":"    This class is used only when use_queue_manager is set to True in config"},{"line_number":48,"context_line":"    file."}],"source_content_type":"text/x-python","patch_set":5,"id":"2e94ed81_ec902ca4","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":22},"in_reply_to":"f1f1c606_965b5f01","updated":"2023-11-13 01:39:12.000000000","message":"The existing classes were created in old days when we still supported Python 2 and we haven\u0027t removed inheritance from object since we dropped py2 support.\n\nthough I\u0027m personally fine with keeping it now to make this code consistent with the others.","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    file."},{"line_number":49,"context_line":"    It rely on a shared memory accross processes (reading/writing data to"},{"line_number":50,"context_line":"    /dev/shm/xyz) and oslo_concurrency.lockutils to avoid assigning the same"},{"line_number":51,"context_line":"    queue name twice (or more) to differents processes."},{"line_number":52,"context_line":"    The original idea of this queue manager was to avoid random queue names,"},{"line_number":53,"context_line":"    so on service restart, the previously created queues can be reused,"},{"line_number":54,"context_line":"    avoiding deletion/creation of queues on rabbitmq side (which cost of lot"}],"source_content_type":"text/x-python","patch_set":5,"id":"2b0fc374_2e937b1e","line":51,"range":{"start_line":51,"start_character":34,"end_line":51,"end_character":44},"updated":"2023-08-29 09:23:36.000000000","message":"nit: different","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    file."},{"line_number":49,"context_line":"    It rely on a shared memory accross processes (reading/writing data to"},{"line_number":50,"context_line":"    /dev/shm/xyz) and oslo_concurrency.lockutils to avoid assigning the same"},{"line_number":51,"context_line":"    queue name twice (or more) to differents processes."},{"line_number":52,"context_line":"    The original idea of this queue manager was to avoid random queue names,"},{"line_number":53,"context_line":"    so on service restart, the previously created queues can be reused,"},{"line_number":54,"context_line":"    avoiding deletion/creation of queues on rabbitmq side (which cost of lot"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5514f18_ee851c09","line":51,"range":{"start_line":51,"start_character":34,"end_line":51,"end_character":44},"in_reply_to":"2b0fc374_2e937b1e","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    queue name twice (or more) to differents processes."},{"line_number":52,"context_line":"    The original idea of this queue manager was to avoid random queue names,"},{"line_number":53,"context_line":"    so on service restart, the previously created queues can be reused,"},{"line_number":54,"context_line":"    avoiding deletion/creation of queues on rabbitmq side (which cost of lot"},{"line_number":55,"context_line":"    at scale)."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    def __init__(self, hostname, processname):"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ef5e958_d53da324","line":54,"range":{"start_line":54,"start_character":70,"end_line":54,"end_character":72},"updated":"2023-08-29 09:23:36.000000000","message":"nit: a","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    queue name twice (or more) to differents processes."},{"line_number":52,"context_line":"    The original idea of this queue manager was to avoid random queue names,"},{"line_number":53,"context_line":"    so on service restart, the previously created queues can be reused,"},{"line_number":54,"context_line":"    avoiding deletion/creation of queues on rabbitmq side (which cost of lot"},{"line_number":55,"context_line":"    at scale)."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    def __init__(self, hostname, processname):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec196073_8bf39a26","line":54,"range":{"start_line":54,"start_character":70,"end_line":54,"end_character":72},"in_reply_to":"2ef5e958_d53da324","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"4e6200120d862412ce0516c5f9c3381f23e49579","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        self.processname \u003d processname"},{"line_number":63,"context_line":"        # This is where the counter is kept"},{"line_number":64,"context_line":"        # This counter MUST be reset on service stop/restart, note that it\u0027s"},{"line_number":65,"context_line":"        # not process safe to do it in code, so operiator must implement that"},{"line_number":66,"context_line":"        # outside (like in systemd)."},{"line_number":67,"context_line":"        self.file_name \u003d \u0027/dev/shm/%s_%s_qmanager\u0027 % (self.hostname,  # nosec"},{"line_number":68,"context_line":"                                                      self.processname)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e9518bf6_61c2c456","line":65,"updated":"2023-08-18 09:34:22.000000000","message":"s/operiator/operator/","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.processname \u003d processname"},{"line_number":63,"context_line":"        # This is where the counter is kept"},{"line_number":64,"context_line":"        # This counter MUST be reset on service stop/restart, note that it\u0027s"},{"line_number":65,"context_line":"        # not process safe to do it in code, so operiator must implement that"},{"line_number":66,"context_line":"        # outside (like in systemd)."},{"line_number":67,"context_line":"        self.file_name \u003d \u0027/dev/shm/%s_%s_qmanager\u0027 % (self.hostname,  # nosec"},{"line_number":68,"context_line":"                                                      self.processname)"}],"source_content_type":"text/x-python","patch_set":5,"id":"abb1692c_890e405a","line":65,"in_reply_to":"e9518bf6_61c2c456","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"4e6200120d862412ce0516c5f9c3381f23e49579","unresolved":true,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        msg \u003d message"},{"line_number":705,"context_line":"        if \u0027method\u0027 in msg:"},{"line_number":706,"context_line":"            LOG.info(\u0027Calling RPC method %s on target %s\u0027, msg.get(\u0027method\u0027),"},{"line_number":707,"context_line":"                     target.topic)"},{"line_number":708,"context_line":"        else:"},{"line_number":709,"context_line":"            LOG.info(\u0027Sending message to topic %s\u0027, target.topic)"}],"source_content_type":"text/x-python","patch_set":5,"id":"657b309c_c479490f","line":706,"updated":"2023-08-18 09:34:22.000000000","message":"Maybe better to turn logging about messages sent/received in debug ?","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        msg \u003d message"},{"line_number":705,"context_line":"        if \u0027method\u0027 in msg:"},{"line_number":706,"context_line":"            LOG.info(\u0027Calling RPC method %s on target %s\u0027, msg.get(\u0027method\u0027),"},{"line_number":707,"context_line":"                     target.topic)"},{"line_number":708,"context_line":"        else:"},{"line_number":709,"context_line":"            LOG.info(\u0027Sending message to topic %s\u0027, target.topic)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ca5d02ef_df367b8b","line":706,"in_reply_to":"657b309c_c479490f","updated":"2023-08-29 09:23:36.000000000","message":"Yeah, this feels like debug","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        msg \u003d message"},{"line_number":705,"context_line":"        if \u0027method\u0027 in msg:"},{"line_number":706,"context_line":"            LOG.info(\u0027Calling RPC method %s on target %s\u0027, msg.get(\u0027method\u0027),"},{"line_number":707,"context_line":"                     target.topic)"},{"line_number":708,"context_line":"        else:"},{"line_number":709,"context_line":"            LOG.info(\u0027Sending message to topic %s\u0027, target.topic)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d47a8abd_99cf61eb","line":706,"in_reply_to":"ca5d02ef_df367b8b","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"}],"releasenotes/notes/rabbit_queue_manager-363209285cbbe257.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add three new options to switch oslo_messaging from random queue names"},{"line_number":5,"context_line":"    (for reply_q and fanouts) to consistent naming."},{"line_number":6,"context_line":"    The default value is False, so oslo_messaging will still use random queue"},{"line_number":7,"context_line":"    names if nothing is set in configuration file of services."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a7b457c5_def82b90","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":50},"updated":"2023-08-29 09:23:36.000000000","message":"nit: `oslo.messaging` (that\u0027s the package name)","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add three new options to switch oslo_messaging from random queue names"},{"line_number":5,"context_line":"    (for reply_q and fanouts) to consistent naming."},{"line_number":6,"context_line":"    The default value is False, so oslo_messaging will still use random queue"},{"line_number":7,"context_line":"    names if nothing is set in configuration file of services."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4a69e4df_3c38ac8d","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":50},"in_reply_to":"a7b457c5_def82b90","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e2d0204175e5d2da66f8afede82f88009756d138","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add three new options to switch oslo_messaging from random queue names"},{"line_number":5,"context_line":"    (for reply_q and fanouts) to consistent naming."},{"line_number":6,"context_line":"    The default value is False, so oslo_messaging will still use random queue"},{"line_number":7,"context_line":"    names if nothing is set in configuration file of services."},{"line_number":8,"context_line":"    When switching use_queue_manager to True, the uuid4 random string from the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f949e001_27d7eea6","line":5,"updated":"2023-08-29 09:23:36.000000000","message":"Can you list the options? Don\u0027t forget to format as literals:\n\n```\n``literal``\n```","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"32a7dac554769559f3969034328ab8849fe9944e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add three new options to switch oslo_messaging from random queue names"},{"line_number":5,"context_line":"    (for reply_q and fanouts) to consistent naming."},{"line_number":6,"context_line":"    The default value is False, so oslo_messaging will still use random queue"},{"line_number":7,"context_line":"    names if nothing is set in configuration file of services."},{"line_number":8,"context_line":"    When switching use_queue_manager to True, the uuid4 random string from the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"43c489f7_d7acfc28","line":5,"in_reply_to":"f949e001_27d7eea6","updated":"2023-09-06 13:54:07.000000000","message":"Done","commit_id":"0d9155465db227af15cb5c456da0cb8c88b6c526"}]}