)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b232aee75a1269b2f073f0a4ecb130741cacaa42","unresolved":true,"context_lines":[{"line_number":10,"context_line":"queue TTL in config."},{"line_number":11,"context_line":"Moreover, using policies is much more simpler as you dont need to"},{"line_number":12,"context_line":"delete/recreate the queues to apply the new parameter (see [1])."},{"line_number":13,"context_line":"So, adding the possible to set the transient queue TTL to 0 will allow"},{"line_number":14,"context_line":"the creation of the queue without the x-expire parameter and only the"},{"line_number":15,"context_line":"policy will apply."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0a0624a9_dc1cc28e","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":23},"updated":"2023-08-31 09:43:58.000000000","message":"possibility","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"aa18b753f6095c07d472e854f17e4224a5df5a1b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"queue TTL in config."},{"line_number":11,"context_line":"Moreover, using policies is much more simpler as you dont need to"},{"line_number":12,"context_line":"delete/recreate the queues to apply the new parameter (see [1])."},{"line_number":13,"context_line":"So, adding the possible to set the transient queue TTL to 0 will allow"},{"line_number":14,"context_line":"the creation of the queue without the x-expire parameter and only the"},{"line_number":15,"context_line":"policy will apply."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4cacd883_2027bd64","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":23},"in_reply_to":"0a0624a9_dc1cc28e","updated":"2023-09-06 13:53:57.000000000","message":"Done","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"747c3081816b9ff7aeda34952413dbc03f2348ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5ad92cb_d6982dfb","updated":"2023-08-29 09:18:00.000000000","message":"Doesn\u0027t change the default but rather just allows a larger config. Seems fine to me. Can we get a release note though?","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b232aee75a1269b2f073f0a4ecb130741cacaa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9b55f2f_4b8b048d","updated":"2023-08-31 09:43:58.000000000","message":"Hello,\n\nI\u0027d suggest adding a release note to highlight this config change.\n\nAlso as we are in feature freeze I\u0027d suggest to wait a couple of week before merging this patch.","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"97f6dbdd9593a40f6b75b6708b908b9b93a952e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46df1b0f_11d6ce16","updated":"2023-08-16 10:34:21.000000000","message":"Makes total sense to me","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b232aee75a1269b2f073f0a4ecb130741cacaa42","unresolved":true,"context_lines":[{"line_number":211,"context_line":"               help\u003d\u0027Positive integer representing duration in seconds for \u0027"},{"line_number":212,"context_line":"                    \u0027queue TTL (x-expires). Queues which are unused for the \u0027"},{"line_number":213,"context_line":"                    \u0027duration of the TTL are automatically deleted. The \u0027"},{"line_number":214,"context_line":"                    \u0027parameter affects only reply and fanout queues. Setting \u0027"},{"line_number":215,"context_line":"                    \u00270 as value will disable the x-expires. If doing so, \u0027"},{"line_number":216,"context_line":"                    \u0027make sure you have a rabbitmq policy to delete the \u0027"},{"line_number":217,"context_line":"                    \u0027queues or you deployment will create an infinite number \u0027"},{"line_number":218,"context_line":"                    \u0027of queue over time.\u0027),"},{"line_number":219,"context_line":"    cfg.IntOpt(\u0027rabbit_qos_prefetch_count\u0027,"},{"line_number":220,"context_line":"               default\u003d0,"},{"line_number":221,"context_line":"               help\u003d\u0027Specifies the number of messages to prefetch. Setting to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"2bd51b9e_fa53e3d1","line":218,"range":{"start_line":214,"start_character":69,"end_line":218,"end_character":40},"updated":"2023-08-31 09:43:58.000000000","message":"I\u0027d suggest to log a warn somewhere in the case this config is set to 0. To capture the attention of operators about the policy part.","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"aa18b753f6095c07d472e854f17e4224a5df5a1b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"               help\u003d\u0027Positive integer representing duration in seconds for \u0027"},{"line_number":212,"context_line":"                    \u0027queue TTL (x-expires). Queues which are unused for the \u0027"},{"line_number":213,"context_line":"                    \u0027duration of the TTL are automatically deleted. The \u0027"},{"line_number":214,"context_line":"                    \u0027parameter affects only reply and fanout queues. Setting \u0027"},{"line_number":215,"context_line":"                    \u00270 as value will disable the x-expires. If doing so, \u0027"},{"line_number":216,"context_line":"                    \u0027make sure you have a rabbitmq policy to delete the \u0027"},{"line_number":217,"context_line":"                    \u0027queues or you deployment will create an infinite number \u0027"},{"line_number":218,"context_line":"                    \u0027of queue over time.\u0027),"},{"line_number":219,"context_line":"    cfg.IntOpt(\u0027rabbit_qos_prefetch_count\u0027,"},{"line_number":220,"context_line":"               default\u003d0,"},{"line_number":221,"context_line":"               help\u003d\u0027Specifies the number of messages to prefetch. Setting to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"56604815_0f274911","line":218,"range":{"start_line":214,"start_character":69,"end_line":218,"end_character":40},"in_reply_to":"2bd51b9e_fa53e3d1","updated":"2023-09-06 13:53:57.000000000","message":"so each time a queue will be created, a warn will be visible in logs?\nI am not a fan of this as this is not the default value, and if an operator set this to 0, it is on purpose and is already suppose to know what he is doing.\nWhat do you think?","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"379a95dd47d3a9a2c5755574e0319201f913766a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"               help\u003d\u0027Positive integer representing duration in seconds for \u0027"},{"line_number":212,"context_line":"                    \u0027queue TTL (x-expires). Queues which are unused for the \u0027"},{"line_number":213,"context_line":"                    \u0027duration of the TTL are automatically deleted. The \u0027"},{"line_number":214,"context_line":"                    \u0027parameter affects only reply and fanout queues. Setting \u0027"},{"line_number":215,"context_line":"                    \u00270 as value will disable the x-expires. If doing so, \u0027"},{"line_number":216,"context_line":"                    \u0027make sure you have a rabbitmq policy to delete the \u0027"},{"line_number":217,"context_line":"                    \u0027queues or you deployment will create an infinite number \u0027"},{"line_number":218,"context_line":"                    \u0027of queue over time.\u0027),"},{"line_number":219,"context_line":"    cfg.IntOpt(\u0027rabbit_qos_prefetch_count\u0027,"},{"line_number":220,"context_line":"               default\u003d0,"},{"line_number":221,"context_line":"               help\u003d\u0027Specifies the number of messages to prefetch. Setting to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"c69e4cc3_f776a8d8","line":218,"range":{"start_line":214,"start_character":69,"end_line":218,"end_character":40},"in_reply_to":"2f80cff8_07fdb15a","updated":"2023-11-11 22:18:16.000000000","message":"Done","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f291ca8699eab1ad74eea2fff253f4123a8972c","unresolved":true,"context_lines":[{"line_number":211,"context_line":"               help\u003d\u0027Positive integer representing duration in seconds for \u0027"},{"line_number":212,"context_line":"                    \u0027queue TTL (x-expires). Queues which are unused for the \u0027"},{"line_number":213,"context_line":"                    \u0027duration of the TTL are automatically deleted. The \u0027"},{"line_number":214,"context_line":"                    \u0027parameter affects only reply and fanout queues. Setting \u0027"},{"line_number":215,"context_line":"                    \u00270 as value will disable the x-expires. If doing so, \u0027"},{"line_number":216,"context_line":"                    \u0027make sure you have a rabbitmq policy to delete the \u0027"},{"line_number":217,"context_line":"                    \u0027queues or you deployment will create an infinite number \u0027"},{"line_number":218,"context_line":"                    \u0027of queue over time.\u0027),"},{"line_number":219,"context_line":"    cfg.IntOpt(\u0027rabbit_qos_prefetch_count\u0027,"},{"line_number":220,"context_line":"               default\u003d0,"},{"line_number":221,"context_line":"               help\u003d\u0027Specifies the number of messages to prefetch. Setting to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f80cff8_07fdb15a","line":218,"range":{"start_line":214,"start_character":69,"end_line":218,"end_character":40},"in_reply_to":"56604815_0f274911","updated":"2023-11-02 04:46:30.000000000","message":"We can implement a mechanism to avoid repeating the log, but I agree with Arnaund that users should be aware of the side effect when they set this intentionally and adding warning sounds like over-killing.","commit_id":"03322a46e01f17a07030caa2b2c4af80e99b841e"}]}