)]}'
{"oslo/messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"f38bff60505415905687e5f0bd0cf0d5bb8e506f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        try:"},{"line_number":387,"context_line":"            with self._get_connection() as conn:"},{"line_number":388,"context_line":"                if notify:"},{"line_number":389,"context_line":"                    conn.notify_send(target.exchange or self._default_exchange,"},{"line_number":390,"context_line":"                                     target.topic, msg)"},{"line_number":391,"context_line":"                elif target.fanout:"},{"line_number":392,"context_line":"                    conn.fanout_send(target.topic, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_80e93de8","line":389,"updated":"2014-05-06 11:29:38.000000000","message":"Really not liking the duplication of this pattern\n\nI\u0027d rather a simle\n\n  def _get_exchange(self, target):\n      return target.exchange or self._default_exchange","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"90b3b135a75eb1ca0f07543aed8d6196db9d4245","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        try:"},{"line_number":387,"context_line":"            with self._get_connection() as conn:"},{"line_number":388,"context_line":"                if notify:"},{"line_number":389,"context_line":"                    conn.notify_send(target.exchange or self._default_exchange,"},{"line_number":390,"context_line":"                                     target.topic, msg)"},{"line_number":391,"context_line":"                elif target.fanout:"},{"line_number":392,"context_line":"                    conn.fanout_send(target.topic, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_6c06d987","line":389,"in_reply_to":"9ad9bd40_80e93de8","updated":"2014-05-07 13:50:08.000000000","message":"Done","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"}],"oslo/messaging/_drivers/impl_qpid.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"f38bff60505415905687e5f0bd0cf0d5bb8e506f","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                raise StopIteration"},{"line_number":606,"context_line":"            yield self.ensure(_error_callback, _consume)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def publisher_send(self, cls, exchange_name, topic, msg, **kwargs):"},{"line_number":609,"context_line":"        \"\"\"Send to a publisher based on the publisher class.\"\"\""},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        def _connect_error(exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_c06a6580","line":608,"updated":"2014-05-06 11:29:38.000000000","message":"Hmm, exchange_name is unused here\n\nI think you probably intended for this to be passed through via kwargs?","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"90b3b135a75eb1ca0f07543aed8d6196db9d4245","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                raise StopIteration"},{"line_number":606,"context_line":"            yield self.ensure(_error_callback, _consume)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def publisher_send(self, cls, exchange_name, topic, msg, **kwargs):"},{"line_number":609,"context_line":"        \"\"\"Send to a publisher based on the publisher class.\"\"\""},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        def _connect_error(exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_4c72f511","line":608,"in_reply_to":"9ad9bd40_c06a6580","updated":"2014-05-07 13:50:08.000000000","message":"Arf, it seems sone unit tests are missing, and yes it should be in kwargs.\n\nI have added some unit tests for methods used between the Connection class and the AMQPDriver class.","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"}],"oslo/messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"f38bff60505415905687e5f0bd0cf0d5bb8e506f","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                raise StopIteration"},{"line_number":709,"context_line":"            yield self.ensure(_error_callback, _consume)"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def publisher_send(self, cls, topic, msg, timeout\u003dNone, **kwargs):"},{"line_number":712,"context_line":"        \"\"\"Send to a publisher based on the publisher class.\"\"\""},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        def _error_callback(exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_4025755a","line":711,"updated":"2014-05-06 11:29:38.000000000","message":"No exchange_name here?","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"90b3b135a75eb1ca0f07543aed8d6196db9d4245","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                raise StopIteration"},{"line_number":709,"context_line":"            yield self.ensure(_error_callback, _consume)"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    def publisher_send(self, cls, topic, msg, timeout\u003dNone, **kwargs):"},{"line_number":712,"context_line":"        \"\"\"Send to a publisher based on the publisher class.\"\"\""},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        def _error_callback(exc):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_8c807dc1","line":711,"in_reply_to":"9ad9bd40_4025755a","updated":"2014-05-07 13:50:08.000000000","message":"exchange_name is in the kwargs, because only TopicPublisher and NotifyPublisher allow to set a exchange name, \n\nFor the DirectPublisher it is forced to the msg_id and for the FanoutPublisher to the topic suffixed by \u0027_fanout\u0027","commit_id":"f89bbfa5f52a53bd0f061dcc29a560efe822a33b"}]}