)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1462c55774023a552a29e6c17c6dc26a2c6a1a6d","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The commit 859e0d4eaa45d75eb822f4a6be46c547187c6358"},{"line_number":14,"context_line":"directly revert the log due to the msg_id is not"},{"line_number":15,"context_line":"accessable for non-rabbit drivers. It\u0027s not the"},{"line_number":16,"context_line":"right way to make things better."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So add the log back with the attribute msg_id for base"},{"line_number":19,"context_line":"IncomingMessage class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5e8c3c06_797d1651","line":16,"range":{"start_line":15,"start_character":35,"end_line":16,"end_character":32},"updated":"2024-07-04 13:33:21.000000000","message":"I agree as long as people gives quick response to fix the problem timely :-)","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"977bc512b705b919c6f656d2aa982f87b35c3410","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The commit 859e0d4eaa45d75eb822f4a6be46c547187c6358"},{"line_number":14,"context_line":"directly revert the log due to the msg_id is not"},{"line_number":15,"context_line":"accessable for non-rabbit drivers. It\u0027s not the"},{"line_number":16,"context_line":"right way to make things better."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So add the log back with the attribute msg_id for base"},{"line_number":19,"context_line":"IncomingMessage class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c25b13bc_ccbfdceb","line":16,"range":{"start_line":15,"start_character":35,"end_line":16,"end_character":32},"in_reply_to":"5e8c3c06_797d1651","updated":"2024-07-05 01:12:32.000000000","message":"Acknowledged","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1462c55774023a552a29e6c17c6dc26a2c6a1a6d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"So add the log back with the attribute msg_id for base"},{"line_number":19,"context_line":"IncomingMessage class."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1847747"},{"line_number":22,"context_line":"Related-Bug: #1855775"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib35c8fbb24d5c51d3b54e8ca63e663428318eca5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6b904f1c_bc06338a","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"updated":"2024-07-04 13:33:21.000000000","message":"this but was already closed. Can we create a new one which explains additional context about the revert, to avoid future confusions ?","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"977bc512b705b919c6f656d2aa982f87b35c3410","unresolved":false,"context_lines":[{"line_number":18,"context_line":"So add the log back with the attribute msg_id for base"},{"line_number":19,"context_line":"IncomingMessage class."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1847747"},{"line_number":22,"context_line":"Related-Bug: #1855775"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ib35c8fbb24d5c51d3b54e8ca63e663428318eca5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"79f54d9c_22ffa52f","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"in_reply_to":"6b904f1c_bc06338a","updated":"2024-07-05 01:12:32.000000000","message":"Done","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0bccb862700c73840e902f7b443d81b2fa7dbfbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc1aea32_46dc3305","updated":"2024-07-04 00:46:01.000000000","message":"Failures are not related this patch, other changes have same failures.","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e369063cf577da405edf33a3f58f153d3b0448ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5cbef50f_c24a560d","updated":"2024-07-03 01:03:01.000000000","message":"Not run tox locally, wait for upstream CI results.","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"12e7ee14a867ccd430f01a094ea6f49e2c94bd67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"530e8101_c2a801de","updated":"2024-07-08 02:05:27.000000000","message":"recheck","commit_id":"3d28d72860a6c9c2353e643bd0c75de9a413a87a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1693b29d21e487eb8ce7039ab84f941c38d8473b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d235a111_2f3551d5","updated":"2024-07-09 00:58:54.000000000","message":"recheck","commit_id":"3d28d72860a6c9c2353e643bd0c75de9a413a87a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a0c3afd4202add4ad3edb250fd23ff22ba43afd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d894c86f_d90c0331","updated":"2024-07-10 06:35:56.000000000","message":"@","commit_id":"6b3268990f22db75360e8af2771160668c8c710a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0dcc8ccd6d1549ac4ff858404fca5b0addf3881d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"933ba2be_3113d345","updated":"2024-07-12 11:32:47.000000000","message":"This patch seems legit and lgtm","commit_id":"104a63b9aa040dda567d356e598aad5f8734d3ec"}],"oslo_messaging/_drivers/base.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1462c55774023a552a29e6c17c6dc26a2c6a1a6d","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.ctxt \u003d ctxt"},{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":"        self.msg_id \u003d str(uuid.uuid4())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def acknowledge(self):"},{"line_number":89,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7cee989_e3d21c3d","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":39},"updated":"2024-07-04 13:33:21.000000000","message":"this results in redundant handling of msg_id in AMQPIncomingMessage . I\u0027d suggest adding msg_id\u003dNone as a new additional argument,\n\n```\ndef __init__(self, ctxt, message, msg_id\u003dNone):\n    ...\n    if self.msg_id is None:\n        self.msg_id \u003d str(uuid.uuid4())\n    else:\n        self.msg_id \u003dmsg_id\n```\n\nand set the msg_id in `AMQPIncomingMessage.__init__`","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"977bc512b705b919c6f656d2aa982f87b35c3410","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.ctxt \u003d ctxt"},{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":"        self.msg_id \u003d str(uuid.uuid4())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def acknowledge(self):"},{"line_number":89,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"}],"source_content_type":"text/x-python","patch_set":1,"id":"c31d653b_3629ac80","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":39},"in_reply_to":"a7cee989_e3d21c3d","updated":"2024-07-05 01:12:32.000000000","message":"Done","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a0c3afd4202add4ad3edb250fd23ff22ba43afd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.ctxt \u003d ctxt"},{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":"        self.msg_id \u003d str(uuid.uuid4())"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def acknowledge(self):"},{"line_number":89,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fe2defa_a15555e5","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":39},"in_reply_to":"c31d653b_3629ac80","updated":"2024-07-10 06:35:56.000000000","message":"@Takashi Kajinami\n\nBased on this change, seems the oslo.messaging-tox-py310-func-scenario01 test can not pass:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_57d/923337/5/check/oslo.messaging-tox-py310-func-scenario01/57d32d6/testr_results.html\n\nCould you take a look at that failure? I\u0027m not very sure which part is the root cause.","commit_id":"46a66379847308233ad44b4dfffc760b1c2e4c2d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16622b6d0fd13f0d368e029da657df301784d869","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if msg_id is None:"},{"line_number":88,"context_line":"            self.msg_id \u003d str(uuid.uuid4())"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.msg_id \u003d msg_id"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def acknowledge(self):"},{"line_number":93,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"},{"line_number":94,"context_line":"        this is called the driver must notify the backend of the"}],"source_content_type":"text/x-python","patch_set":5,"id":"cdbece46_57919369","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":0},"updated":"2024-07-12 09:02:14.000000000","message":"A uniq msg_id is very usefull to locate the time cost for each rpc call. It will be impossible to find each RPC req-reply log pair because of many same None IDs.","commit_id":"6b3268990f22db75360e8af2771160668c8c710a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff63074fe8afa9ceab57747052ed3f13f2773dcb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if msg_id is None:"},{"line_number":88,"context_line":"            self.msg_id \u003d str(uuid.uuid4())"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.msg_id \u003d msg_id"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def acknowledge(self):"},{"line_number":93,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"},{"line_number":94,"context_line":"        this is called the driver must notify the backend of the"}],"source_content_type":"text/x-python","patch_set":5,"id":"b9dce1de_1ed85912","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":0},"in_reply_to":"4dec334f_2ecdbf84","updated":"2024-07-12 09:37:10.000000000","message":"Done","commit_id":"6b3268990f22db75360e8af2771160668c8c710a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"97ca8acd83beff10ac5768ec01b4ff7284df614b","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        self.message \u003d message"},{"line_number":85,"context_line":"        self.client_timeout \u003d None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if msg_id is None:"},{"line_number":88,"context_line":"            self.msg_id \u003d str(uuid.uuid4())"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.msg_id \u003d msg_id"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def acknowledge(self):"},{"line_number":93,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"},{"line_number":94,"context_line":"        this is called the driver must notify the backend of the"}],"source_content_type":"text/x-python","patch_set":5,"id":"4dec334f_2ecdbf84","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":0},"in_reply_to":"cdbece46_57919369","updated":"2024-07-12 09:10:55.000000000","message":"I understand that point but the problem is caused by the uuid generation and server somehow does not shutdown timely.","commit_id":"6b3268990f22db75360e8af2771160668c8c710a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"16622b6d0fd13f0d368e029da657df301784d869","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        self.ctxt \u003d ctxt"},{"line_number":83,"context_line":"        self.message \u003d message"},{"line_number":84,"context_line":"        self.client_timeout \u003d None"},{"line_number":85,"context_line":"        self.msg_id \u003d msg_id"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def acknowledge(self):"},{"line_number":88,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"}],"source_content_type":"text/x-python","patch_set":6,"id":"9b5b678e_98ff7810","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":28},"updated":"2024-07-12 09:02:14.000000000","message":"Anyway, let\u0027s see how this change works for func test.","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff63074fe8afa9ceab57747052ed3f13f2773dcb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.ctxt \u003d ctxt"},{"line_number":83,"context_line":"        self.message \u003d message"},{"line_number":84,"context_line":"        self.client_timeout \u003d None"},{"line_number":85,"context_line":"        self.msg_id \u003d msg_id"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def acknowledge(self):"},{"line_number":88,"context_line":"        \"\"\"Called by the server to acknowledge receipt of the message. When"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f5bbaaa_715e1185","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":28},"in_reply_to":"9b5b678e_98ff7810","updated":"2024-07-12 09:37:10.000000000","message":"Done","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"97ca8acd83beff10ac5768ec01b4ff7284df614b","unresolved":true,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ea845aa_20ae8b1a","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"updated":"2024-07-12 09:10:55.000000000","message":"why was this change needed ???","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ff63074fe8afa9ceab57747052ed3f13f2773dcb","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7d86db70_c3b64b58","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"in_reply_to":"1849424d_1c606a10","updated":"2024-07-12 09:37:10.000000000","message":"Updating the broken unit test without actual investigation is not the way to make things better :-)","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1a56e57dc525e5a0348418df539581c0f091574d","unresolved":true,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1849424d_1c606a10","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"in_reply_to":"20e5a12a_464fae0d","updated":"2024-07-12 09:22:24.000000000","message":"OK https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L187-L190 is broken by the fallback.","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"703a68fea61dc74b7bf5b1949b6ea7845d2adb95","unresolved":true,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce5e10cf_be12401c","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"in_reply_to":"3ea845aa_20ae8b1a","updated":"2024-07-12 09:14:29.000000000","message":"Maybe still because of that uuid generate","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1fa04a871ccd61ba3cf05f7a347b60a675bd69cb","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"caf27527_60ae203a","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"in_reply_to":"7d86db70_c3b64b58","updated":"2024-07-12 11:07:55.000000000","message":"Yes, that uuid generation is somehow related to the failure functional case. All these clues point to that.","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6eacd3f070b48bf10b3bed4474f9cea7061cc8b1","unresolved":true,"context_lines":[{"line_number":733,"context_line":"        # Verify the _send_reply was not invoked by driver:"},{"line_number":734,"context_line":"        with mock.patch.object(msgs[2], \u0027_send_reply\u0027) as method:"},{"line_number":735,"context_line":"            msgs[2].reply({\u0027rx_id\u0027: 2})"},{"line_number":736,"context_line":"            self.assertEqual(1, method.call_count)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        # Wait for the 3rd thread to finish"},{"line_number":739,"context_line":"        senders[2].join()"}],"source_content_type":"text/x-python","patch_set":6,"id":"20e5a12a_464fae0d","line":736,"range":{"start_line":736,"start_character":30,"end_line":736,"end_character":31},"in_reply_to":"ce5e10cf_be12401c","updated":"2024-07-12 09:19:01.000000000","message":"So this assertion fails if we add fallback for generated id. This IS a real problem and might be related to the issue with functional tests.","commit_id":"f62189ca932a6f04cde9fa2d5adc7ff4cea6324c"}]}