)]}'
{"oslo/messaging/notify/_impl_routing.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a5294a436ab91e4d5d03a7db60f930630e7ec530","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return list(accepted_drivers)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _filter_func(self, ext, context, message, accepted_drivers):"},{"line_number":108,"context_line":"        \"\"\"True/False if the driver should be called for this message."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        # context is unused here, but passed in by map()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_5701cf36","line":107,"updated":"2014-06-03 16:25:35.000000000","message":"should add priority here as well","commit_id":"93006f709acf1ce4e79bdf6922e786ccdff7c3b1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2bbcae8d48ce33946ea5d1bcdbc32e2196d1bc57","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return list(accepted_drivers)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _filter_func(self, ext, context, message, accepted_drivers):"},{"line_number":108,"context_line":"        \"\"\"True/False if the driver should be called for this message."},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        # context is unused here, but passed in by map()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_4e42fa68","line":107,"in_reply_to":"1ae5cdf2_5701cf36","updated":"2014-06-06 11:52:16.000000000","message":"Done and I have added a test to \u0027really\u0027 cover that.","commit_id":"93006f709acf1ce4e79bdf6922e786ccdff7c3b1"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"47124f105f4b1cbc24ec9f2951ae707633df91af","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        for group in self.routing_groups.values():"},{"line_number":130,"context_line":"            accepted_drivers.update(self._get_drivers_for_message(group,"},{"line_number":131,"context_line":"                                                                  event_type,"},{"line_number":132,"context_line":"                                                                  priority))"},{"line_number":133,"context_line":"        self.plugin_manager.map(self._filter_func, self._call_notify, context,"},{"line_number":134,"context_line":"                                message, priority, list(accepted_drivers))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_502dfe8d","line":132,"updated":"2014-06-13 15:25:38.000000000","message":"You should pass priority.lower() here ... right? If so, that indicates some missing test coverage","commit_id":"a76b82e204c1ad4c38482b0232947b09d0bf1f9f"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"cfe8ef2ca653500d60e730f16182a6c0354dc6aa","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        for group in self.routing_groups.values():"},{"line_number":130,"context_line":"            accepted_drivers.update(self._get_drivers_for_message(group,"},{"line_number":131,"context_line":"                                                                  event_type,"},{"line_number":132,"context_line":"                                                                  priority))"},{"line_number":133,"context_line":"        self.plugin_manager.map(self._filter_func, self._call_notify, context,"},{"line_number":134,"context_line":"                                message, priority, list(accepted_drivers))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_99485c8c","line":132,"in_reply_to":"1ae5cdf2_502dfe8d","updated":"2014-06-16 13:32:27.000000000","message":"good catch, done with test","commit_id":"a76b82e204c1ad4c38482b0232947b09d0bf1f9f"}],"tests/test_notifier.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"903ef55654f136e46ac89d92a069b14925e9ffb5","unresolved":false,"context_lines":[{"line_number":511,"context_line":"             extension.Extension(\u0027bar\u0027, None, None, bar_driver)],"},{"line_number":512,"context_line":"        )"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        with contextlib.nested("},{"line_number":515,"context_line":"            mock.patch.object(self.router, \u0027_get_notifier_config_file\u0027,"},{"line_number":516,"context_line":"                              config_file),"},{"line_number":517,"context_line":"            mock.patch(\u0027stevedore.dispatch.DispatchExtensionManager\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_3ff6dfd7","line":514,"updated":"2014-06-18 13:13:30.000000000","message":"You should use two with blocks instead of contextlib.nested(). This function was removed in Python 3.3 (maybe in Python 3.0, I don\u0027t remember). There is also a fixture to mock objects. I don\u0027t have a suggestion to the best syntax, just avoid contextlib.nested ;-)","commit_id":"cbbb90e28c608d165df94b779c04593bd17d02f1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"98af94a4e35a01bcc04680f547bbdd1e71ca2b8e","unresolved":false,"context_lines":[{"line_number":511,"context_line":"             extension.Extension(\u0027bar\u0027, None, None, bar_driver)],"},{"line_number":512,"context_line":"        )"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        with contextlib.nested("},{"line_number":515,"context_line":"            mock.patch.object(self.router, \u0027_get_notifier_config_file\u0027,"},{"line_number":516,"context_line":"                              config_file),"},{"line_number":517,"context_line":"            mock.patch(\u0027stevedore.dispatch.DispatchExtensionManager\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_bf94af37","line":514,"in_reply_to":"1ae5cdf2_3ff6dfd7","updated":"2014-06-18 13:18:14.000000000","message":"I have fixed it into an other review: https://review.openstack.org/100902","commit_id":"cbbb90e28c608d165df94b779c04593bd17d02f1"}]}