)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate the option heartbeat_in_pthread."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The option is strongly related to Eventlet. Eventlet will be removed and the option have never worked as excepted."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ide8b22e2c66eae6639266950a39c4042d9a656fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"95e0b185_34b1190b","line":9,"updated":"2024-08-15 10:02:49.000000000","message":"This line is too long.","commit_id":"2206958e35f4e6c3f84d6922834853f1b62e1742"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"da958011b79dc9bef2e90d3ae5a6ca28f26993f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f65c7af_bba96830","updated":"2024-08-06 15:55:14.000000000","message":"Can you also fix the typo (\"depracated\") in the filename?","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"104fe9b8061468d27c2339f9fc2e7f347a880799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10ab5525_9d1067b9","updated":"2024-08-06 15:01:16.000000000","message":"Sean/Melanie: I forget, but don\u0027t we need this option when we\u0027re running in non-eventlet mode to make sure we run the rabbit heartbeat?","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70e3b4d27e44799e9867bfa3e28999aa59b148fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5de6345d_485e1967","updated":"2024-08-06 15:46:19.000000000","message":"the release note and deprecation reason are not correct and don\u0027t capture why this is begin deprecated in my opipion.\n\nthis feature/config option has never been related to efficency\n\nit was added purly so allow the heatbeat to escape the lifecycle management of a wsgi server when an applicaiton usign oslo.messaging is run under an external wsgi server like uwsgi or apache mod_wsgi.\n\nim +1 for the deprecation but if we are going to do it we shoudl explain why properly.\n\nthis is being done because the option causes runtime issues in the form of deadlock which required use to use a debug only option to disable concurrancy protection in eventl. this is not supported in the aioeventlet hub and as such this is preventing us form moving forward with the eventlet removal work.\n\nwe are deprecating this to aid in the eventlet removal and because it provide no pratical benefit to enabling this in production other then avoiding disconnect messages in rabbitmq.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49b9bb5ac1792d022c07833c35eb1306b690f952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05064fd9_641ceb1b","in_reply_to":"10ab5525_9d1067b9","updated":"2024-08-06 15:39:38.000000000","message":"its only \"neeeded\" if you want to not have a log messaged.\n\nit is not required for nova to work properly.\n\nwe are setting heartbeat_in_pthread to false even when running under mod wsgi\n\nin our new installer because it was causing issues do to how logging works.\n\nhttps://github.com/openstack-k8s-operators/nova-operator/blob/main/templates/nova.conf#L66\n\nhttps://review.opendev.org/c/openstack/oslo.log/+/852443 was intended for fix that issues as part of https://launchpad.net/bugs/1983863 but the PipeMutex intoduced by that and the fact it sets this debug option \nhttps://review.opendev.org/c/openstack/oslo.log/+/852443/1/oslo_log/pipe_mutex.py#26\n\nis very problemtic \n\nit preventing making progress on removing eventlet and its also partly unsafe as\nits disabling concurrance protections within eventlet that we really dont want to disable.\n\nso we dont plan to enable heartbeat_in_pthread in the non eventlet case in our downstream product and i dont think we should recommend that others do that in general upstream.\n\nso im in favor of this deprecation and removal of heartbeat_in_pthread keeping the behaivor of false.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"81287d44dc5b3cbc605ae14b37e682efe71f9e8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b68730b_fd866948","in_reply_to":"5de6345d_485e1967","updated":"2024-08-06 15:53:21.000000000","message":"Ok, I will update the release note.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"b02e0eb3e9749731b1ab58803766fd972b874ae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf64f8a9_481be0ab","in_reply_to":"9b68730b_fd866948","updated":"2024-08-07 14:07:40.000000000","message":"I have updated the release note. Thanks a lot.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"82b0c558aa3e4d0aa2b6a59d35241724b94f3656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ed57b9d_5f829ded","in_reply_to":"9f65c7af_bba96830","updated":"2024-08-07 14:07:01.000000000","message":"Done, thanks a lot.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a87a8ea1e2d4943a734e9f107c0800d300f8e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c1e9e454_50ad1173","updated":"2024-08-08 14:37:33.000000000","message":"Current state looks enough for me, I won\u0027t spend more time playing ping pong with nit picks, feel free to propose a follow up patch to address my inline comments","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"255c56555193373a3d36215ec7d8f0ca1934dfe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2f42210_15141b62","updated":"2024-08-08 14:39:46.000000000","message":"Dan\u0027s comment have not been addressed, though...","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9c92d8fd7321ad3fd41fe1c6d8fa0917611517c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8f206d90_5762e1a2","updated":"2024-08-08 14:42:35.000000000","message":"The name is still wrong. It was \"depracate\" (which is not a word), now it\u0027s \"depreciate\" which means \"to reduce in value\". It should be \"deprecate\" which is the word we\u0027re looking for :)","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"565a8177f39481952e98186a20f262935030c6b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a79bf33_814f6e4a","in_reply_to":"a2f42210_15141b62","updated":"2024-08-08 14:41:22.000000000","message":"ah no sorry, my bad, ignore the above comment","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b421442a46abb240b4867d2cc8937ace52b2c836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6bea0e07_a4fb9a14","updated":"2024-08-08 16:03:25.000000000","message":"The filename is still wrong... See Dan\u0027s comment","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1c383ae984c9ede88acde59f89c55ababe43dba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"863ae315_2934c476","in_reply_to":"6bea0e07_a4fb9a14","updated":"2024-08-08 16:08:43.000000000","message":"I have fixed the filename what do you mean by is still wrong?","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ea07e790776badd6f4430817c90fc6360088dcf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cd1af0a8_6e66270d","in_reply_to":"863ae315_2934c476","updated":"2024-08-08 16:17:37.000000000","message":"See Dan\u0027s comment just above...","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"46cb989a03b3c487bb58a6f4bf6c34b318d9c989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6261279c_924d3cf3","in_reply_to":"cd1af0a8_6e66270d","updated":"2024-08-08 16:18:22.000000000","message":"https://review.opendev.org/c/openstack/oslo.messaging/+/925778/comments/8f206d90_5762e1a2","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"53d6d81a_b1e5db6b","updated":"2024-08-12 16:17:18.000000000","message":"I agree with the removal but we need a few improvements in doc items, I think.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"057cb642f3dd9f119de48d261cbe3c4d0170331a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ffa77115_5fc81ed5","updated":"2024-08-09 15:08:04.000000000","message":"Ok, the CI is green now.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3c0d37f2a23cc82fc2314dfa7430da27abc9fcc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30d2b7b8_3c336d95","updated":"2024-08-08 18:54:16.000000000","message":"The typo in the file name [1] is still there, but I propose to stop wasting time on this typo by simply fixing it in a follow up patch [2]...\n\n[1] https://review.opendev.org/c/openstack/oslo.messaging/+/925778/comments/8f206d90_5762e1a2\n[2] https://review.opendev.org/c/openstack/oslo.messaging/+/926011","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"45dc13334d4bce01fe2bbc3307d5fbff9cd1a89f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"70d4bd8e_ff60b07d","updated":"2024-08-09 13:23:54.000000000","message":"recheck","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d341727b9ed9b01e71ee6775aec2c2fd252c0b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"115ea005_5ce2be17","updated":"2024-08-09 14:12:44.000000000","message":"yes there is a followup for the file name already so we can proceed with this provided ci passes of course","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1e7887de29566331878b2501cae826f779a053f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f39b5d75_360ed029","in_reply_to":"2becf5f4_20b93d02","updated":"2024-08-09 14:14:47.000000000","message":"Ok I was not aware it was wrong in english.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"2cc41fa2636a41c9c03f0d780b3fe0114aac13de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cfbe9c55_5815a6ad","in_reply_to":"30d2b7b8_3c336d95","updated":"2024-08-09 13:25:37.000000000","message":"The typo was depracated and I have changed it for depreciate, depreciate it\u0027s a valid english word.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"568430bfae09aca01e0cd6832ad71b7b46b0c073","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2becf5f4_20b93d02","in_reply_to":"cfbe9c55_5815a6ad","updated":"2024-08-09 14:04:11.000000000","message":"depreciate is a valid english word it is just the wrong one, `deprecate` is the correct English word in this context.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c271c719_24672959","updated":"2024-08-15 10:02:49.000000000","message":"Fixed a few minor problems and updated the descriptions to make them more clear (hopefully).","commit_id":"020e7a5f3f70b5421b5ac51f2ad275d01dd19fb2"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70e3b4d27e44799e9867bfa3e28999aa59b148fc","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb54630_66754c4d","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"updated":"2024-08-06 15:46:19.000000000","message":"this had nothighing to do with efficiency.\n\nthis was added to ensure that if your wsgi application is running in a wsgi server such as apaches mod_wsgi, the lifetime of the pthread would be decoupled form the lifetime of the request handler thread.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2c161ba34a17a743211c0d2daf17545a345f66e3","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"a9dd77bd_ff1d25de","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"in_reply_to":"094a8fa6_7b6c3925","updated":"2024-08-08 10:27:04.000000000","message":"so the release not is now fine but this is still not adressed.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5f0553df266b5b8ffd8f381dc5c7a29d867d10b2","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bbed21a5_bd785473","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"in_reply_to":"a9dd77bd_ff1d25de","updated":"2024-08-08 12:31:18.000000000","message":"Beyond the comments already there, I\u0027d also suggest to advice users to do not use it anymore. My opinion...","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"49c8135c1024813a09c1efec3e93d7572f4d2a5c","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"c2bf10fa_63967ab7","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"in_reply_to":"bbed21a5_bd785473","updated":"2024-08-08 13:19:51.000000000","message":"Ok right, I will update the help message.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"2deac9f3_c410df5f","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"in_reply_to":"c2bf10fa_63967ab7","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"81287d44dc5b3cbc605ae14b37e682efe71f9e8c","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027and totally useless in term of efficiency.\u0027,"},{"line_number":99,"context_line":"                help\u003d\"(DEPRECATED) Run the health check heartbeat thread \""},{"line_number":100,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":101,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":1,"id":"094a8fa6_7b6c3925","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":76},"in_reply_to":"ffb54630_66754c4d","updated":"2024-08-06 15:53:21.000000000","message":"Ok, I will change it.","commit_id":"c77a1ab95ff029b699716fdbeaacbf27325bbb5d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a87a8ea1e2d4943a734e9f107c0800d300f8e4","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option have \u0027"},{"line_number":99,"context_line":"                                  \u0027never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option anymore \""},{"line_number":101,"context_line":"                     \"Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1137d51a_8dc51fa0","line":100,"range":{"start_line":100,"start_character":48,"end_line":100,"end_character":54},"updated":"2024-08-08 14:37:33.000000000","message":"Is the correct form is not \"to not use\"?","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1c383ae984c9ede88acde59f89c55ababe43dba5","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option have \u0027"},{"line_number":99,"context_line":"                                  \u0027never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option anymore \""},{"line_number":101,"context_line":"                     \"Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":6,"id":"d96c40fd_dbf7b6df","line":100,"range":{"start_line":100,"start_character":48,"end_line":100,"end_character":54},"in_reply_to":"1137d51a_8dc51fa0","updated":"2024-08-08 16:08:43.000000000","message":"Sorry I\u0027m not sure but I can change it. I think it\u0027s a correct form.","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option have \u0027"},{"line_number":99,"context_line":"                                  \u0027never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option anymore \""},{"line_number":101,"context_line":"                     \"Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":6,"id":"4b75c478_3304e58b","line":100,"range":{"start_line":100,"start_character":48,"end_line":100,"end_character":54},"in_reply_to":"d96c40fd_dbf7b6df","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":93,"context_line":"                \u0027an exception will be raised.\u0027),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027heartbeat_in_pthread\u0027,"},{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9131230e_474cbd9c","line":99,"range":{"start_line":96,"start_character":44,"end_line":99,"end_character":66},"updated":"2024-08-12 16:17:18.000000000","message":"these are continued lines. Please add `.` to separate sentences.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                \u0027an exception will be raised.\u0027),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027heartbeat_in_pthread\u0027,"},{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""}],"source_content_type":"text/x-python","patch_set":8,"id":"373cbde7_84015a03","line":99,"range":{"start_line":96,"start_character":44,"end_line":99,"end_character":66},"in_reply_to":"9131230e_474cbd9c","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":8,"id":"73f3fb7d_3fe2af8f","line":100,"range":{"start_line":100,"start_character":35,"end_line":100,"end_character":37},"updated":"2024-08-12 16:17:18.000000000","message":"it is recommended","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""}],"source_content_type":"text/x-python","patch_set":8,"id":"62f1a8b3_03a3d6de","line":100,"range":{"start_line":100,"start_character":35,"end_line":100,"end_character":37},"in_reply_to":"73f3fb7d_3fe2af8f","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""},{"line_number":104,"context_line":"                     \"heartbeat will inherit the execution model \""}],"source_content_type":"text/x-python","patch_set":8,"id":"fd2863e9_afadc233","line":101,"updated":"2024-08-12 16:17:18.000000000","message":"add `.`","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) We recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""},{"line_number":104,"context_line":"                     \"heartbeat will inherit the execution model \""}],"source_content_type":"text/x-python","patch_set":8,"id":"c6e50acb_52cca15b","line":101,"in_reply_to":"fd2863e9_afadc233","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027heartbeat_in_pthread\u0027,"},{"line_number":95,"context_line":"                default\u003dFalse,"},{"line_number":96,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":97,"context_line":"                deprecated_reason\u003d\u0027The option is strongly related to Eventlet. \u0027"},{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted.\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) It is recommend not to use this option \""}],"source_content_type":"text/x-python","patch_set":9,"id":"24d7dd14_8bb4e8ef","line":97,"range":{"start_line":97,"start_character":79,"end_line":97,"end_character":80},"updated":"2024-08-15 10:02:49.000000000","message":"this line is too long","commit_id":"2206958e35f4e6c3f84d6922834853f1b62e1742"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                  \u0027Eventlet will be removed and the option \u0027"},{"line_number":99,"context_line":"                                  \u0027have never worked as excepted.\u0027,"},{"line_number":100,"context_line":"                help\u003d\"(DEPRECATED) It is recommend not to use this option \""},{"line_number":101,"context_line":"                     \"anymore Run the health check heartbeat thread \""},{"line_number":102,"context_line":"                     \"through a native python thread by default. If this \""},{"line_number":103,"context_line":"                     \"option is equal to False then the health check \""},{"line_number":104,"context_line":"                     \"heartbeat will inherit the execution model \""}],"source_content_type":"text/x-python","patch_set":9,"id":"862ec57f_b50d56a0","line":101,"updated":"2024-08-15 10:02:49.000000000","message":"missing `.` after `anymore`","commit_id":"2206958e35f4e6c3f84d6922834853f1b62e1742"}],"releasenotes/notes/depreciate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5f0553df266b5b8ffd8f381dc5c7a29d867d10b2","unresolved":true,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. The option was added for fix"},{"line_number":6,"context_line":"    an issue with the logging but the PipeMutex introduced by that"},{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c85af245_8fb0b3de","line":7,"range":{"start_line":5,"start_character":34,"end_line":7,"end_character":51},"updated":"2024-08-08 12:31:18.000000000","message":"hmm... To be exact, and as Sean already said in his previous comment, this option was added with the intention to allow the heatbeat to escape the lifecycle management of a wsgi server when an applicaiton using oslo.messaging is run under an external wsgi server like uwsgi or apache mod_wsgi [1]. Unfortunately it doesn\u0027t work like expected because we cannot mix the usage of python threads and the usage of greenlet coroutines [2].\n\nIMO, release notes deprecations messages are more there to give details about the removal I\u0027m not sure we need to give whole story of the option here...\nUsually we just explain that the option/module is deprecated and why it is deprecated, and basta... Examples among others:\n\n- https://opendev.org/openstack/oslo.messaging/src/branch/master/releasenotes/notes/deprecated-amqp1-driver-4bf57449bc2b7aad.yaml\n- https://opendev.org/openstack/oslo.messaging/src/branch/master/releasenotes/notes/deprecate-ZeroMQ-driver-a8af25aaba867c5b.yaml\n- https://opendev.org/openstack/oslo.messaging/src/branch/master/releasenotes/notes/blocking-executor-deprecated-895146c1c3bf2f51.yaml\n\nPerhaps, this message should begin with the \"what\" (the option h_i_p is deprecated), and then give a \"why\" (eventlet will removed, h_i_p is strongly related to eventlet and it never worked as expected, so lets simply prepare its removal). But I don\u0027t want to nit pick your message neither...\n\n[1] https://opendev.org/openstack/oslo.messaging/commit/22f240b82fffbd62be8568a7d0d3369134596ace\n[2] https://greenlet.readthedocs.io/en/stable/python_threads.html","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. The option was added for fix"},{"line_number":6,"context_line":"    an issue with the logging but the PipeMutex introduced by that"},{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b38dc2cd_c6778658","line":7,"range":{"start_line":5,"start_character":34,"end_line":7,"end_character":51},"in_reply_to":"089991a3_44cd3bef","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"49c8135c1024813a09c1efec3e93d7572f4d2a5c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. The option was added for fix"},{"line_number":6,"context_line":"    an issue with the logging but the PipeMutex introduced by that"},{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"089991a3_44cd3bef","line":7,"range":{"start_line":5,"start_character":34,"end_line":7,"end_character":51},"in_reply_to":"c85af245_8fb0b3de","updated":"2024-08-08 13:19:51.000000000","message":"Ok thanks a lot. I will change it.","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"05a3229214bfeaec9a15fb7c7de6b1d94f21b41b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"51f3eba3_da25b096","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":68},"updated":"2024-08-08 13:36:27.000000000","message":"I\u0027m not a native speaker but this sentence looks weird.\nWhat to you think of \"and the removal will be scheduled soon\" or \"we will schedule its removal in the coming months\" or something like these sentences?","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2d58dc8ac1860ec4e280b1d72fd0489e5aa4073f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"35d5f09e_e3698a96","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":68},"in_reply_to":"364f5aab_ee20c8d1","updated":"2024-08-09 14:04:36.000000000","message":"My comment was against the patch set number 4, we are now at patch set number 8 and you already updated it, so I think this comment is now outdated, hence this sub-discussion can be tagged as resolved.","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"f3fd27463b0ff4c74cd11782e8b3f032afee0abd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    and the fact it set a debug option is a problem. It preventing"},{"line_number":8,"context_line":"    making progress in the removing of eventlet and it\u0027s also unsafe"},{"line_number":9,"context_line":"    as it\u0027s disabling concurrence protection. The option is now"},{"line_number":10,"context_line":"    deprecated and a scheduled for a future removal will be planned."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"364f5aab_ee20c8d1","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":68},"in_reply_to":"51f3eba3_da25b096","updated":"2024-08-09 13:23:47.000000000","message":"I think it\u0027s correct in english but I can change it.","commit_id":"4cb9f9566f6f2e02331a5abec86d44de3c213917"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a87a8ea1e2d4943a734e9f107c0800d300f8e4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"52b61663_41f542c3","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":35},"updated":"2024-08-08 14:37:33.000000000","message":"could be syntax highligthed with \"`\"","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"13cb59ef_231bfd2a","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":35},"in_reply_to":"52b61663_41f542c3","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a87a8ea1e2d4943a734e9f107c0800d300f8e4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"32860bf3_3190e86d","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":24},"updated":"2024-08-08 14:37:33.000000000","message":"same thing here...","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"befc5298_fd1b7739","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":24},"in_reply_to":"32860bf3_3190e86d","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5a87a8ea1e2d4943a734e9f107c0800d300f8e4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"836b55d4_11e931c4","line":7,"range":{"start_line":6,"start_character":59,"end_line":7,"end_character":31},"updated":"2024-08-08 14:37:33.000000000","message":"Already said at the beginning of that sentence...","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option heartbeat_in_pthread from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    heartbeat_in_pthread have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"503d4565_fabf5d52","line":7,"range":{"start_line":6,"start_character":59,"end_line":7,"end_character":31},"in_reply_to":"836b55d4_11e931c4","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"4d93b2be8c48819ae1fc77919b8f5720fe78b607"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b421442a46abb240b4867d2cc8937ace52b2c836","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"37351f6b_3a45623d","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":16},"updated":"2024-08-08 16:03:25.000000000","message":"Should be doubled back quotes, see https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#inline-markup","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b5fb4004_5f90c0e5","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":16},"in_reply_to":"37351f6b_3a45623d","updated":"2024-08-12 16:17:18.000000000","message":"+1","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cec521ee_54e4291f","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":16},"in_reply_to":"b5fb4004_5f90c0e5","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0b90eecefb5cad13499a4100f91c4023066ed386","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fffa9eba_0adb441c","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":5},"updated":"2024-08-08 16:04:29.000000000","message":"And same thing here","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"858329f4_bffd1786","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":5},"in_reply_to":"8ddfe88d_99401b75","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"adad2b309300853d16ba5f99cb5ecd5eaba26e0a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8ddfe88d_99401b75","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":5},"in_reply_to":"e2cc58ca_2244eca5","updated":"2024-08-08 16:28:27.000000000","message":"you have a single ``` \n`and should have  2 of them `````\n\n\n```suggestion\n    ``heartbeat_in_pthread`` have never worked as expected and is\n```\n\nif you run sphinx lint on this it will warn\n\na single backtic is the default rule a double backtic is a litrial","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1c383ae984c9ede88acde59f89c55ababe43dba5","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e2cc58ca_2244eca5","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":5},"in_reply_to":"fffa9eba_0adb441c","updated":"2024-08-08 16:08:43.000000000","message":"I have fixed it what do you mean?","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b421442a46abb240b4867d2cc8937ace52b2c836","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3b01489a_c7eb1612","line":7,"range":{"start_line":6,"start_character":61,"end_line":7,"end_character":31},"updated":"2024-08-08 16:03:25.000000000","message":"This sentence is still duplicated...","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ef455236ae48dcf8e64266e23e3b0c64a36ef49","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"72cf0e20_da3684a2","line":7,"range":{"start_line":6,"start_character":61,"end_line":7,"end_character":31},"in_reply_to":"29c69a74_45a1841e","updated":"2024-08-08 16:29:31.000000000","message":"i think this makes it less clear.","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1c383ae984c9ede88acde59f89c55ababe43dba5","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"29c69a74_45a1841e","line":7,"range":{"start_line":6,"start_character":61,"end_line":7,"end_character":31},"in_reply_to":"3b01489a_c7eb1612","updated":"2024-08-08 16:08:43.000000000","message":"I have do it in purpose I would like to reinforce it.","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"be8a5ea88dc5425432564057e1951ef8426856e4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ee42c60d_8b69e8d8","line":7,"range":{"start_line":6,"start_character":61,"end_line":7,"end_character":31},"in_reply_to":"72cf0e20_da3684a2","updated":"2024-08-08 16:38:30.000000000","message":"Ok I will remove it.","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"becbd90f55026cb2a3ed76c58386e0b0b962642e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked as expected and is"},{"line_number":7,"context_line":"    strongly linked to eventlet. We will plan and prepare the"},{"line_number":8,"context_line":"    removal. The option is now deprecated and we recommend to not"},{"line_number":9,"context_line":"    use it anymore."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f6da4da4_89325a7e","line":7,"range":{"start_line":6,"start_character":61,"end_line":7,"end_character":31},"in_reply_to":"ee42c60d_8b69e8d8","updated":"2024-08-15 10:02:49.000000000","message":"Done","commit_id":"e15373b03fd7db69209087ded1c394abec63338a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked. We will plan"},{"line_number":7,"context_line":"    and prepare the removal. The option is now deprecated and we"},{"line_number":8,"context_line":"    recommend to not use it anymore."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"69898a32_ec4fdb59","line":7,"range":{"start_line":6,"start_character":46,"end_line":7,"end_character":28},"updated":"2024-08-12 16:17:18.000000000","message":"Removal of what ? If you meant eventlet then this is duplicate of the previous sentence, it seems.\n\nEventlet will be remove in a future release of OpenStack so the option.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fad1f311954097174fcd874b3350ef79e40005a6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked. We will plan"},{"line_number":7,"context_line":"    and prepare the removal. The option is now deprecated and we"},{"line_number":8,"context_line":"    recommend to not use it anymore."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0f5dfef8_f8d05e87","line":7,"range":{"start_line":7,"start_character":62,"end_line":7,"end_character":64},"updated":"2024-08-12 16:17:18.000000000","message":"it is recoomended not to use it anymore.","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked. We will plan"},{"line_number":7,"context_line":"    and prepare the removal. The option is now deprecated and we"},{"line_number":8,"context_line":"    recommend to not use it anymore."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ed8d18b7_4a9d9cbf","line":7,"range":{"start_line":7,"start_character":62,"end_line":7,"end_character":64},"in_reply_to":"0f5dfef8_f8d05e87","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5ac63dbd5b2e305d70d03c39f9315f08a174e2ca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The option `heartbeat_in_pthread` from the rabbitmq driver is"},{"line_number":5,"context_line":"    strongly related to Eventlet. Eventlet will be removed,"},{"line_number":6,"context_line":"    `heartbeat_in_pthread` have never worked. We will plan"},{"line_number":7,"context_line":"    and prepare the removal. The option is now deprecated and we"},{"line_number":8,"context_line":"    recommend to not use it anymore."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2a638e3d_a2898942","line":7,"range":{"start_line":6,"start_character":46,"end_line":7,"end_character":28},"in_reply_to":"69898a32_ec4fdb59","updated":"2024-08-15 09:07:16.000000000","message":"Done","commit_id":"22f5de69e4f07b16bf41badac710ab679f9962a0"}]}