)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94b1f3da22233ad90ecc6cc17556161386e137e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5704863_9f3b1593","updated":"2024-10-17 01:23:43.000000000","message":"The implementation looks good but we need a release note to describe the new option.\n\nAlso, please check my inline comments","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"039716986ff98677fc5c111fe0eeabc21667e4ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e5cdfe7_f9cde79b","in_reply_to":"b5704863_9f3b1593","updated":"2024-12-02 19:47:05.000000000","message":"Done","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94b1f3da22233ad90ecc6cc17556161386e137e1","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                 help\u003d\u0027How long to wait (in seconds) before reconnecting in \u0027"},{"line_number":120,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"},{"line_number":121,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_splay\u0027,"},{"line_number":122,"context_line":"                 default\u003d0.0,"},{"line_number":123,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"                 help\u003d\u0027Random time to wait for when reconnecting in response \u0027"},{"line_number":125,"context_line":"                      \u0027to an AMQP consumer cancel notification.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccdb43d1_1754dcbb","line":122,"updated":"2024-10-17 01:23:43.000000000","message":"Let\u0027s add min\u003d0.0,","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"53b6ba4a04b8d981f339ec1ce9b31a0ad2093f37","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                 help\u003d\u0027How long to wait (in seconds) before reconnecting in \u0027"},{"line_number":120,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"},{"line_number":121,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_splay\u0027,"},{"line_number":122,"context_line":"                 default\u003d0.0,"},{"line_number":123,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"                 help\u003d\u0027Random time to wait for when reconnecting in response \u0027"},{"line_number":125,"context_line":"                      \u0027to an AMQP consumer cancel notification.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef68ddc9_9d3a616e","line":122,"in_reply_to":"ccdb43d1_1754dcbb","updated":"2024-12-02 19:46:50.000000000","message":"Done","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94b1f3da22233ad90ecc6cc17556161386e137e1","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"},{"line_number":121,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_splay\u0027,"},{"line_number":122,"context_line":"                 default\u003d0.0,"},{"line_number":123,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"                 help\u003d\u0027Random time to wait for when reconnecting in response \u0027"},{"line_number":125,"context_line":"                      \u0027to an AMQP consumer cancel notification.\u0027),"},{"line_number":126,"context_line":"    cfg.StrOpt(\u0027kombu_compression\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"63e37aec_f7f1418f","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":44},"updated":"2024-10-17 01:23:43.000000000","message":"This is no needed, because this is a new option.","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"53b6ba4a04b8d981f339ec1ce9b31a0ad2093f37","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                      \u0027response to an AMQP consumer cancel notification.\u0027),"},{"line_number":121,"context_line":"    cfg.FloatOpt(\u0027kombu_reconnect_splay\u0027,"},{"line_number":122,"context_line":"                 default\u003d0.0,"},{"line_number":123,"context_line":"                 deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"                 help\u003d\u0027Random time to wait for when reconnecting in response \u0027"},{"line_number":125,"context_line":"                      \u0027to an AMQP consumer cancel notification.\u0027),"},{"line_number":126,"context_line":"    cfg.StrOpt(\u0027kombu_compression\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b000fe6_be4b8812","line":123,"range":{"start_line":123,"start_character":17,"end_line":123,"end_character":44},"in_reply_to":"63e37aec_f7f1418f","updated":"2024-12-02 19:46:50.000000000","message":"Done","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94b1f3da22233ad90ecc6cc17556161386e137e1","unresolved":true,"context_lines":[{"line_number":1101,"context_line":"            interval \u003d (self.kombu_reconnect_delay + interval"},{"line_number":1102,"context_line":"                        if self.kombu_reconnect_delay \u003e 0"},{"line_number":1103,"context_line":"                        else interval)"},{"line_number":1104,"context_line":"            interval +\u003d random.random() * self.kombu_reconnect_splay  # nosec"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"            info \u003d {\u0027err_str\u0027: exc, \u0027sleep_time\u0027: interval}"},{"line_number":1107,"context_line":"            info.update(self._get_connection_info(conn_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"76ccb674_bfd2dfdc","line":1104,"range":{"start_line":1104,"start_character":12,"end_line":1104,"end_character":68},"updated":"2024-10-17 01:23:43.000000000","message":"Can we add `if self.kombu_reconnect_splay \u003e 0:`, to avoid calling `random.random` for no use","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"53b6ba4a04b8d981f339ec1ce9b31a0ad2093f37","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"            interval \u003d (self.kombu_reconnect_delay + interval"},{"line_number":1102,"context_line":"                        if self.kombu_reconnect_delay \u003e 0"},{"line_number":1103,"context_line":"                        else interval)"},{"line_number":1104,"context_line":"            interval +\u003d random.random() * self.kombu_reconnect_splay  # nosec"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"            info \u003d {\u0027err_str\u0027: exc, \u0027sleep_time\u0027: interval}"},{"line_number":1107,"context_line":"            info.update(self._get_connection_info(conn_error\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"39edfac1_5ee94622","line":1104,"range":{"start_line":1104,"start_character":12,"end_line":1104,"end_character":68},"in_reply_to":"76ccb674_bfd2dfdc","updated":"2024-12-02 19:46:50.000000000","message":"Done","commit_id":"078d639ed3893f65b08a28481c5fe05a28387947"}]}