)]}'
{"oslo/messaging/_drivers/amqp.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"8e9e923852452a5e3623446a0cb451b180648e30","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    \"\"\"Add unique_id for checking duplicate messages.\"\"\""},{"line_number":249,"context_line":"    unique_id \u003d uuid.uuid4().hex"},{"line_number":250,"context_line":"    msg.update({UNIQUE_ID: unique_id})"},{"line_number":251,"context_line":"    LOG.debug(\u0027UNIQUE_ID is %s.\u0027, (unique_id))"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"def get_control_exchange(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_6db5b37c","line":251,"updated":"2014-06-06 08:29:28.000000000","message":"You should remove now useless parenthesis.","commit_id":"e24d11908e9628706996e92df04a598478a1f084"}],"oslo/messaging/_drivers/common.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"31b83821e508a10220d9e559f747bf4c0839a4c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                # log the issue and the kwargs"},{"line_number":102,"context_line":"                LOG.exception(_(\u0027Exception in string format operation\u0027))"},{"line_number":103,"context_line":"                for name, value in six.iteritems(kwargs):"},{"line_number":104,"context_line":"                    LOG.error(\"%(name)s: %(value)s\","},{"line_number":105,"context_line":"                              {\u0027name\u0027: name, \u0027value\u0027: value})"},{"line_number":106,"context_line":"                # at least get the core message out if something happened"},{"line_number":107,"context_line":"                message \u003d self.msg_fmt"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_d51e49ba","line":104,"updated":"2014-05-20 13:03:35.000000000","message":"Why not keeping %s and indexed parameters? It can be useful if the format string is translated, but it\u0027s not the case here.","commit_id":"3e0cf0a19ba2585345b1ca2863fa6e2d5b180885"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"8e9e923852452a5e3623446a0cb451b180648e30","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                LOG.exception(_(\u0027Exception in string format operation\u0027))"},{"line_number":103,"context_line":"                for name, value in six.iteritems(kwargs):"},{"line_number":104,"context_line":"                    LOG.error(\"%(name)s: %(value)s\","},{"line_number":105,"context_line":"                              {\u0027name\u0027: name, \u0027value\u0027: value})"},{"line_number":106,"context_line":"                # at least get the core message out if something happened"},{"line_number":107,"context_line":"                message \u003d self.msg_fmt"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_2d664b2a","line":105,"updated":"2014-06-06 08:29:28.000000000","message":"I would prefer simpler LOG.error(\"%s: %s\", name, value) syntax.","commit_id":"e24d11908e9628706996e92df04a598478a1f084"}],"oslo/messaging/_drivers/impl_qpid.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"31b83821e508a10220d9e559f747bf4c0839a4c5","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        \"\"\""},{"line_number":586,"context_line":"        def _connect_error(exc):"},{"line_number":587,"context_line":"            log_info \u003d {\u0027topic\u0027: topic, \u0027err_str\u0027: exc}"},{"line_number":588,"context_line":"            LOG.error(_(\"Failed to declare consumer for topic \u0027%(topic)s\u0027: \""},{"line_number":589,"context_line":"                      \"%(err_str)s\") % log_info)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        def _declare_consumer():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_357f6de1","side":"PARENT","line":588,"updated":"2014-05-20 13:03:35.000000000","message":"Why do you remove the translation here?","commit_id":"84887ccee331d247658895f75eca6f971b83ac24"}]}
