)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"51cfb14128365552b5c7228b4b1d31bf11009112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f75e9e0_ec891f7a","updated":"2025-04-16 12:23:37.000000000","message":"I was a bit worried about removing these interfaces but it may not impact users because the metrics module is declared to be a private one.\n\nLeaving one suggestion for efficiency.","commit_id":"3b1e3237f58be904f5a8629f442cd3b418dc2887"}],"oslo_messaging/_metrics/client.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"51cfb14128365552b5c7228b4b1d31bf11009112","unresolved":true,"context_lines":[{"line_number":236,"context_line":"        \"method\": method,"},{"line_number":237,"context_line":"        \"call_type\": call_type,"},{"line_number":238,"context_line":"    }"},{"line_number":239,"context_line":"    if metrics_enabled:"},{"line_number":240,"context_line":"        collector.rpc_client_invocation_start_total(**kwargs)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a0ac2d5_f212d953","line":239,"updated":"2025-04-16 12:23:37.000000000","message":"I wonder if we can implement\n\n```\nif not metrics_enabled:\n    yield\n    return\n```\n  \nat L233 to avoid redundant logic ?","commit_id":"3b1e3237f58be904f5a8629f442cd3b418dc2887"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b8e21e76fd609aba420b6b0b0b8c27a1a79d755","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        \"method\": method,"},{"line_number":237,"context_line":"        \"call_type\": call_type,"},{"line_number":238,"context_line":"    }"},{"line_number":239,"context_line":"    if metrics_enabled:"},{"line_number":240,"context_line":"        collector.rpc_client_invocation_start_total(**kwargs)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"745b29ee_f4420a3e","line":239,"in_reply_to":"080c9f65_5cf36644","updated":"2025-04-17 09:32:55.000000000","message":"Done","commit_id":"3b1e3237f58be904f5a8629f442cd3b418dc2887"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"9060a64c2df459b23306e937f00ccfed3b50daaf","unresolved":true,"context_lines":[{"line_number":236,"context_line":"        \"method\": method,"},{"line_number":237,"context_line":"        \"call_type\": call_type,"},{"line_number":238,"context_line":"    }"},{"line_number":239,"context_line":"    if metrics_enabled:"},{"line_number":240,"context_line":"        collector.rpc_client_invocation_start_total(**kwargs)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"080c9f65_5cf36644","line":239,"in_reply_to":"6a0ac2d5_f212d953","updated":"2025-04-16 15:01:33.000000000","message":"thanks, looks better now","commit_id":"3b1e3237f58be904f5a8629f442cd3b418dc2887"}]}