)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unix driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TODO:"},{"line_number":10,"context_line":"- Talk with the team about this new driver, to see if that could be"},{"line_number":11,"context_line":"  useful"},{"line_number":12,"context_line":"- Add some doc"},{"line_number":13,"context_line":"- Add some tests"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ed9b520fa1562327ce454dfd991f82bbdc7e339"},{"line_number":16,"context_line":"Signed-off-by: Arnaud M \u003carnaud.morin@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5bcc359c_c6460c9d","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":16},"updated":"2025-09-30 08:53:39.000000000","message":"Do you want to do that with follow-ups patches?","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8acf6829927032ad7867f01d7bc2ffdc06046841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5fca5a54_2f139ac7","updated":"2025-09-17 09:22:19.000000000","message":"Your intent seems close from Sean\u0027s proposal:\nhttps://review.opendev.org/c/openstack/oslo.messaging/+/84189\nhttps://specs.openstack.org/openstack/oslo-specs/specs/zed/unix-socket-oslo-messaging-notifications-driver.html\n\nIIRC, I think we more or less agreed on Sean\u0027s proposal. I don\u0027t see reasons to reject your proposal. Sean abandoned his patch for Nova reasons (IIRC).\n\nIn all the case, the rationale behind this change are legit.","commit_id":"b289764b37192400141aacc8f125e1fc676ab059"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a4b6247170c6890e2a3322ea6d339790b34b1a15","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a9ab69a2_8e486cbb","in_reply_to":"5fca5a54_2f139ac7","updated":"2025-09-17 18:06:26.000000000","message":"yes, it sounds like the what is described in the spec, but it goes a little bit further by allowing not only the notifications.\nShould I reference the blueprint anyway in the commit message? Let me know.\n\nAlso, the review link you provided is 404 here, is that only me?","commit_id":"b289764b37192400141aacc8f125e1fc676ab059"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f95393538576ec8c1304c8c1880c660edb3c1ae3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53654c3a_ac788336","in_reply_to":"a9ab69a2_8e486cbb","updated":"2025-09-29 09:27:39.000000000","message":"Sorry wrong copy pasting, here is the right link https://review.opendev.org/c/openstack/oslo.messaging/+/841892\n\nConcerning quoting the blueprint, why not, he cannot hurt.","commit_id":"b289764b37192400141aacc8f125e1fc676ab059"}],"oslo_messaging/_drivers/impl_unix.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3218c4e823dd18ba6d8b38356d06eb1750bfa7c2","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            c +\u003d 1"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    if queue.messages:"},{"line_number":58,"context_line":"        queue.stop()"},{"line_number":59,"context_line":"        return queue.messages.pop(0)"},{"line_number":60,"context_line":"    else:"},{"line_number":61,"context_line":"        # Reply is None, failure is True"}],"source_content_type":"text/x-python","patch_set":7,"id":"034f9a4f_11cc9744","line":58,"updated":"2025-09-18 16:53:53.000000000","message":"maybe queue.stop outside the if?","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        return f\"\u003cUnixServerSocket name\u003d{self.name}\u003e\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _accept(self):"},{"line_number":98,"context_line":"        \"\"\"Accept connection on a non-blocking socket and return the connection"},{"line_number":99,"context_line":"        This is a \"queue\" created by a server"},{"line_number":100,"context_line":"        Note that accepting a connection may fail if there is no connection"},{"line_number":101,"context_line":"        to accept (no client connected), so it must be called by a thread in"},{"line_number":102,"context_line":"        a loop"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            conn, _ \u003d self._sock.accept()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ef455627_e2fc0c21","line":102,"range":{"start_line":98,"start_character":11,"end_line":102,"end_character":14},"updated":"2025-09-30 08:53:39.000000000","message":"I\u0027d suggest to add dots at the end of each sentence.","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def requeue(self):"},{"line_number":179,"context_line":"        \"\"\"Requeue is not supported\"\"\""},{"line_number":180,"context_line":"        # TODO(amorin)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def heartbeat(self):"},{"line_number":183,"context_line":"        \"\"\"Heartbeat is not supported.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"72ddb9a3_7966088e","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":22},"updated":"2025-09-30 08:53:39.000000000","message":"Should we not logs? At least at the debug level.","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        # TODO(amorin)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def heartbeat(self):"},{"line_number":183,"context_line":"        \"\"\"Heartbeat is not supported.\"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class UnixListener(base.PollStyleListener):"}],"source_content_type":"text/x-python","patch_set":7,"id":"96e92347_2948d413","line":183,"range":{"start_line":183,"start_character":8,"end_line":183,"end_character":41},"updated":"2025-09-30 08:53:39.000000000","message":"Same thing","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"}],"oslo_messaging/tests/drivers/test_impl_unix.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        if self._call:"},{"line_number":76,"context_line":"            raise Exception(\u0027error\u0027)"},{"line_number":77,"context_line":"        self._call \u003d True"},{"line_number":78,"context_line":"        return \u0027Coucou \u0027 + arg"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def coucou_call_topic(self, ctx, arg):"},{"line_number":81,"context_line":"        if self._topic:"}],"source_content_type":"text/x-python","patch_set":7,"id":"f6ee88c8_6b116f59","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":22},"updated":"2025-09-30 08:53:39.000000000","message":"😊","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8451f09a385be89493aa4b724ab8856ad6e824a3","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        result \u003d client.prepare(timeout\u003d10).call("},{"line_number":132,"context_line":"            None,"},{"line_number":133,"context_line":"            \u0027coucou_call_topic\u0027,"},{"line_number":134,"context_line":"            arg\u003d\u0027choupinou\u0027"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        self.assertEqual(\u0027Coucou choupinou\u0027, result)"},{"line_number":137,"context_line":"        self.assertEqual(True, self.endpoint._topic)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6eaa6229_50c07038","line":134,"range":{"start_line":134,"start_character":17,"end_line":134,"end_character":26},"updated":"2025-09-30 08:53:39.000000000","message":"😂","commit_id":"ed8143419effcc06832bd36443f2d5092dc51c3d"}]}