)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6288f4291608c714db4868160c672a72b4a22589","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5255e2b_fb4fd192","updated":"2026-06-15 17:19:55.000000000","message":"Removing my +2 now for awareness about the comment by gmann.","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"808d185828734e6c62c4cccf4ed6391be4996272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a730b9d1_c002e4e2","updated":"2025-10-05 12:41:01.000000000","message":"makes sense","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7abbf06f9432f756639494f6819a1fa808ff5058","unresolved":true,"context_lines":[{"line_number":1192,"context_line":"                   \u0027tries: %(err_str)s\u0027 % info)"},{"line_number":1193,"context_line":"            LOG.error(msg)"},{"line_number":1194,"context_line":"            # NOTE(amorin) let\u0027s rollout to another rabbitmq is possible"},{"line_number":1195,"context_line":"            self.connection.maybe_switch_next()"},{"line_number":1196,"context_line":"            raise exceptions.MessageDeliveryFailure(msg)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"cde53eb1_b062a6f9","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":47},"updated":"2026-05-27 01:27:18.000000000","message":"I do not think this is correct way. L1164 self.connection.autoretry() internally call maybe_switch_next() to move/retry it to the next available broker url. We should not be required to maybe_switch_next manually. maybe_switch_next just switch the url in memory but does not initialize the socket itself so this only will not help anything.\n\nAre you seeing issue where autoretry does not retry it to the next url? and are you sure we have correct max_retries which should be more than the number of brokers in cluster (if we want it to try on all brokers).","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"735d7068b897be41748bd79a1fdc117c74c33a84","unresolved":true,"context_lines":[{"line_number":1192,"context_line":"                   \u0027tries: %(err_str)s\u0027 % info)"},{"line_number":1193,"context_line":"            LOG.error(msg)"},{"line_number":1194,"context_line":"            # NOTE(amorin) let\u0027s rollout to another rabbitmq is possible"},{"line_number":1195,"context_line":"            self.connection.maybe_switch_next()"},{"line_number":1196,"context_line":"            raise exceptions.MessageDeliveryFailure(msg)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f24e1d8_ba37c6ff","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":47},"in_reply_to":"0b74a1f1_7c182c71","updated":"2026-07-09 08:57:19.000000000","message":"Hi,\nI will go over this again","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"77bba7f521426f7c1f5ad995ccba86655ef9addb","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"                   \u0027tries: %(err_str)s\u0027 % info)"},{"line_number":1193,"context_line":"            LOG.error(msg)"},{"line_number":1194,"context_line":"            # NOTE(amorin) let\u0027s rollout to another rabbitmq is possible"},{"line_number":1195,"context_line":"            self.connection.maybe_switch_next()"},{"line_number":1196,"context_line":"            raise exceptions.MessageDeliveryFailure(msg)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5f8a590_811d9e88","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":47},"in_reply_to":"5f24e1d8_ba37c6ff","updated":"2026-10-12 16:10:57.000000000","message":"So, I finally took time to go over this.\nAs said by Takashi, this is not a recoverable error, but a Irrecoverable channel error, which is given by kombu when the channel have an issue, not the connection.\nThere is no call to autoretry() here, because the connection is good, max_retries has no effect on this path.\n\nI will narrow down the error to run self.connection.maybe_switch_next() only on channel errors","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5715fabd1f9c6a6aea266f38fb67b73c6ee0bd29","unresolved":true,"context_lines":[{"line_number":1192,"context_line":"                   \u0027tries: %(err_str)s\u0027 % info)"},{"line_number":1193,"context_line":"            LOG.error(msg)"},{"line_number":1194,"context_line":"            # NOTE(amorin) let\u0027s rollout to another rabbitmq is possible"},{"line_number":1195,"context_line":"            self.connection.maybe_switch_next()"},{"line_number":1196,"context_line":"            raise exceptions.MessageDeliveryFailure(msg)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b74a1f1_7c182c71","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":47},"in_reply_to":"cde53eb1_b062a6f9","updated":"2026-06-04 15:35:03.000000000","message":"I was guessing that autoretry does not trigger _ensure_connection in this case because of a different exception raised (it does only for recoverable_connection_errors) but this needs to be confirmed by Arnaud.","commit_id":"d8a5d51a8e7f70d794a56cf1a0e200f246eb6afe"}]}
