)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"22b2bcda4521d1a31fc451c823536cdee7a9b842","unresolved":true,"context_lines":[{"line_number":19,"context_line":"Now imagine this with more than 3k agents..."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I762bf2839482ee06c5b2fc9fa50f38f5542cbe99"},{"line_number":22,"context_line":"Related-bug: #2028384"},{"line_number":23,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"521653a4_abafc103","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":21},"updated":"2025-11-24 15:13:15.000000000","message":"Because this bug was closed some time ago, please create a new bug instead, with describing the problem with the original change.","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c9792f5496b579884698bd7bdeb54e22edc59962","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Now imagine this with more than 3k agents..."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I762bf2839482ee06c5b2fc9fa50f38f5542cbe99"},{"line_number":22,"context_line":"Related-bug: #2028384"},{"line_number":23,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@ovhcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a9dcc81_0ef2b274","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":21},"in_reply_to":"521653a4_abafc103","updated":"2025-12-01 10:33:53.000000000","message":"Done","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"22b2bcda4521d1a31fc451c823536cdee7a9b842","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1be4f4ba_dc17e0bc","updated":"2025-11-24 15:13:15.000000000","message":"-1 mainly because of missing \"raise\"\n\nBecause this changes the core behavior, I think we need a release note.\n\nAlso as I mentioned in my comment for the commit message, please create a separate bug.","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"0c1583b640b63d04c78854b4f1d8a26aa7b83bf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91ee6cbd_b1082481","in_reply_to":"1be4f4ba_dc17e0bc","updated":"2025-12-15 16:28:22.000000000","message":"Done","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7609d502366f0b149caf43f7c974fc087251f646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3312857_c78f0b22","updated":"2026-01-23 14:36:26.000000000","message":"if you have time to review this again, thanks","commit_id":"ecef670efcfdd4a7101f6e81bd8cd8d71cb542e6"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"22b2bcda4521d1a31fc451c823536cdee7a9b842","unresolved":true,"context_lines":[{"line_number":615,"context_line":"                # but this is problematic for queues that are shared between"},{"line_number":616,"context_line":"                # agents. So now, we decided to only log."},{"line_number":617,"context_line":"                if exc.code \u003d\u003d 541:"},{"line_number":618,"context_line":"                    LOG.warning("},{"line_number":619,"context_line":"                        \u0027Queue %s seems broken, operator may need to delete \u0027"},{"line_number":620,"context_line":"                        \u0027it manually.\u0027, self.queue.name)"},{"line_number":621,"context_line":"            else:"},{"line_number":622,"context_line":"                raise"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"99a677ec_d7eb2115","line":620,"range":{"start_line":618,"start_character":20,"end_line":620,"end_character":56},"updated":"2025-11-24 15:13:15.000000000","message":"I wonder if this additional log is very useful or we can guess the same from rabbitmq error raised in the upper layer ? I\u0027m asking this because adding warning for every single behavior of rabbitmq might be too complicated.","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c9792f5496b579884698bd7bdeb54e22edc59962","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                # but this is problematic for queues that are shared between"},{"line_number":616,"context_line":"                # agents. So now, we decided to only log."},{"line_number":617,"context_line":"                if exc.code \u003d\u003d 541:"},{"line_number":618,"context_line":"                    LOG.warning("},{"line_number":619,"context_line":"                        \u0027Queue %s seems broken, operator may need to delete \u0027"},{"line_number":620,"context_line":"                        \u0027it manually.\u0027, self.queue.name)"},{"line_number":621,"context_line":"            else:"},{"line_number":622,"context_line":"                raise"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8941d215_50b67644","line":620,"range":{"start_line":618,"start_character":20,"end_line":620,"end_character":56},"in_reply_to":"99a677ec_d7eb2115","updated":"2025-12-01 10:33:53.000000000","message":"I think you are totally right","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"22b2bcda4521d1a31fc451c823536cdee7a9b842","unresolved":true,"context_lines":[{"line_number":618,"context_line":"                    LOG.warning("},{"line_number":619,"context_line":"                        \u0027Queue %s seems broken, operator may need to delete \u0027"},{"line_number":620,"context_line":"                        \u0027it manually.\u0027, self.queue.name)"},{"line_number":621,"context_line":"            else:"},{"line_number":622,"context_line":"                raise"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def cancel(self, tag):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c71bb16_5ead08d3","line":621,"range":{"start_line":621,"start_character":12,"end_line":621,"end_character":17},"updated":"2025-11-24 15:13:15.000000000","message":"I think we should remove this else logic so that the exception is raised.","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c9792f5496b579884698bd7bdeb54e22edc59962","unresolved":false,"context_lines":[{"line_number":618,"context_line":"                    LOG.warning("},{"line_number":619,"context_line":"                        \u0027Queue %s seems broken, operator may need to delete \u0027"},{"line_number":620,"context_line":"                        \u0027it manually.\u0027, self.queue.name)"},{"line_number":621,"context_line":"            else:"},{"line_number":622,"context_line":"                raise"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def cancel(self, tag):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4be267a_6a401f52","line":621,"range":{"start_line":621,"start_character":12,"end_line":621,"end_character":17},"in_reply_to":"4c71bb16_5ead08d3","updated":"2025-12-01 10:33:53.000000000","message":"agree, thanks","commit_id":"6b9990f961e136a00b6043bd12154fc157a876b0"}]}
