)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a181b426e790465df01662d7c5e2a1104f5ab533","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aaron Rosen \u003caaronorosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-02 14:46:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check creditentials to log message if rabbmitmq closes socket"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one has the credentials misconfigured for rabbitmq currently the following"},{"line_number":10,"context_line":"error message is shown: \"AMQP server on 10.0.0.23:5672 is unreachable:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_b6731514","line":7,"updated":"2014-06-02 22:14:08.000000000","message":"*credentials","commit_id":"12545db4296f7e3a9fd6415a3f65b80d32395f75"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2b9bff57a8e1f0d36ac575b870b5577737251108","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aaron Rosen \u003caaronorosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-02 14:46:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check creditentials to log message if rabbmitmq closes socket"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one has the credentials misconfigured for rabbitmq currently the following"},{"line_number":10,"context_line":"error message is shown: \"AMQP server on 10.0.0.23:5672 is unreachable:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_39cff6b1","line":7,"in_reply_to":"1ae5cdf2_b6731514","updated":"2014-06-02 22:31:03.000000000","message":"Done","commit_id":"12545db4296f7e3a9fd6415a3f65b80d32395f75"}],"oslo/messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a181b426e790465df01662d7c5e2a1104f5ab533","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in str(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_160e898d","line":631,"updated":"2014-06-02 22:14:08.000000000","message":"We prefer to use six.text_type(e) in case there could be unicode data in the exception message.  I don\u0027t know if that\u0027s possible in this case, but I\u0027d like to be consistent anyway.","commit_id":"12545db4296f7e3a9fd6415a3f65b80d32395f75"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2b9bff57a8e1f0d36ac575b870b5577737251108","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in str(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d9d1b258","line":631,"in_reply_to":"1ae5cdf2_160e898d","updated":"2014-06-02 22:31:03.000000000","message":"I only did this because this is what is done on line  608","commit_id":"12545db4296f7e3a9fd6415a3f65b80d32395f75"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"49c771438f6031af860a867d4dd5622dd5e3a625","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in str(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_99564ad1","line":631,"in_reply_to":"1ae5cdf2_d9d1b258","updated":"2014-06-02 22:33:09.000000000","message":"I\u0027ll clean the above one up in another patch.","commit_id":"12545db4296f7e3a9fd6415a3f65b80d32395f75"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4c6ccc6a19eefef2cd9328b1b04d8b7e3904897d","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in six.text_type(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f813bf63","line":631,"updated":"2014-06-03 08:01:44.000000000","message":"Ok, so does it make sense to be stuck in the loop? Wouldn\u0027t be better to break out of the loop, in this situation?","commit_id":"a8b1a2b6bcf6603422ed13589d6417813068193a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a162c9d7361380a2e42ec098aa2454361b13ac29","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in six.text_type(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e449d061","line":631,"in_reply_to":"1ae5cdf2_68398ad6","updated":"2014-06-06 14:49:48.000000000","message":"I agree i think having it retry is desired to avoid having to care about order.","commit_id":"a8b1a2b6bcf6603422ed13589d6417813068193a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7aa06742ae885f3a7c71016f71b007d83c6fdc00","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in six.text_type(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_68398ad6","line":631,"in_reply_to":"1ae5cdf2_747fa9ab","updated":"2014-06-03 17:48:53.000000000","message":"Yeah, but at the moment I\u0027m not sure we have that much control over the ordering of the node deploys, and since the retries should make everything work even if they deploy out of order it\u0027s pretty low on our priority list. :-)","commit_id":"a8b1a2b6bcf6603422ed13589d6417813068193a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"afad5073517489c69d8757c0a7d733627db03d59","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in six.text_type(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_747fa9ab","line":631,"in_reply_to":"1ae5cdf2_f4cf3927","updated":"2014-06-03 15:52:16.000000000","message":"fair point; so long as there\u0027s an escape route I guess it\u0027s fine then. As to the TripleO deployment, I\u0027d expect core services like MQ and DB to be up and running prior to deploying OS services but that\u0027s another matter.","commit_id":"a8b1a2b6bcf6603422ed13589d6417813068193a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0636fee0217368fc086aef2f3559c3a3b03f59db","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                sleep_time \u003d min(sleep_time, self.interval_max)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"            log_info[\u0027sleep_time\u0027] \u003d sleep_time"},{"line_number":631,"context_line":"            if \u0027Socket closed\u0027 in six.text_type(e):"},{"line_number":632,"context_line":"                LOG.error(_(\u0027AMQP server %(hostname)s:%(port)d closed\u0027"},{"line_number":633,"context_line":"                            \u0027 the connection. Check login credentials:\u0027"},{"line_number":634,"context_line":"                            \u0027 %(err_str)s\u0027) % log_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f4cf3927","line":631,"in_reply_to":"1ae5cdf2_f813bf63","updated":"2014-06-03 15:48:14.000000000","message":"If the rabbit server hasn\u0027t been configured yet when a node comes up, we may get this error, but the connection will succeed once the server configuration has been completed.\n\nI\u0027m pretty sure this can happen with a TripleO deployment, so I\u0027d like to keep the retry semantics for this case too.  If it\u0027s causing a problem maybe we can add an upper bound to how long we\u0027ll wait for this type of error though.","commit_id":"a8b1a2b6bcf6603422ed13589d6417813068193a"}]}