)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4060908250706b8144666bf8ba986c7cec72672","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a6cdb355_551946c4","updated":"2026-03-09 14:36:59.000000000","message":"You are enforcing the behavior which is known to break any services using eventlet.\nUnless eventlet patching is enabled in services, this option takes no effect (because apparently native threading is used).","commit_id":"1f20bdbc4f1c4e594d80b6f9b16da3e61109830e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e5082501282336d8ca1e42737c592a1b95b857c8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e478f484_33609655","in_reply_to":"2d54bb6c_555dca04","updated":"2026-03-10 09:15:37.000000000","message":"Indeed, I think you are right and I think we should not force native restore and lets eventlet doing its own stuffs","commit_id":"1f20bdbc4f1c4e594d80b6f9b16da3e61109830e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e9cfe38069df38ca01100a50eb2072a755502987","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2d54bb6c_555dca04","in_reply_to":"a6cdb355_551946c4","updated":"2026-03-09 14:42:03.000000000","message":"See https://review.opendev.org/c/openstack/oslo.messaging/+/979669 . IIUC this is the correct way forward.","commit_id":"1f20bdbc4f1c4e594d80b6f9b16da3e61109830e"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"9dcf7aad6905ae04e5d5e1063f71433a37b7ce67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f9af1cdf_fcd6f986","in_reply_to":"e478f484_33609655","updated":"2026-03-10 13:18:18.000000000","message":"Done","commit_id":"1f20bdbc4f1c4e594d80b6f9b16da3e61109830e"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"fdc6aa7558e18fb33cf52a5c84a29aeb7b87ab5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2fbadd50_85abb207","in_reply_to":"f9af1cdf_fcd6f986","updated":"2026-03-10 13:20:40.000000000","message":"Thanks a lot for the code review!\n\n@kajinamit@oss.nttdata.com, I have removed the code that was enforcing native threading as suggested, so the driver now simply removes the deprecated option and the related code path. I also updated the commit message accordingly.","commit_id":"1f20bdbc4f1c4e594d80b6f9b16da3e61109830e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"170b5485a9a2929a1df1b5b30e7c93477da1db04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2da0da4_16075159","updated":"2026-03-11 01:39:00.000000000","message":"lgtm, after search it is not used anywhere except kolla ansible template which can be cleaned up after this. https://codesearch.openstack.org/?q\u003dheartbeat_in_pthread\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"624f8572485676e2d17b63580948b71fb5ab2b02"}],"releasenotes/notes/remove-heartbeat-in-pthread-option-0ffa11bfc07c58e2.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bfda8ef41e34a22edea1df36bbf4feea4a28c887","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The deprecated ``[oslo_messaging_rabbit] heartbeat_in_pthread`` option"},{"line_number":5,"context_line":"    has been removed. The RabbitMQ driver now always runs the health check"},{"line_number":6,"context_line":"    heartbeat in a native Python thread. Remove this option from your"},{"line_number":7,"context_line":"    configuration if present; otherwise the service will fail to start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1524de8f_c8fa475d","line":7,"updated":"2026-03-09 14:14:03.000000000","message":"Is that true? I think it will just be ignored?","commit_id":"9ff4f33b4a7b1ea8a1cad610c0a2ff097e5a17e3"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e784f26fa13c6f85a65624d434b288ae10363968","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The deprecated ``[oslo_messaging_rabbit] heartbeat_in_pthread`` option"},{"line_number":5,"context_line":"    has been removed. The RabbitMQ driver now always runs the health check"},{"line_number":6,"context_line":"    heartbeat in a native Python thread. Remove this option from your"},{"line_number":7,"context_line":"    configuration if present; otherwise the service will fail to start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c652ec2d_4d411d44","line":7,"in_reply_to":"1524de8f_c8fa475d","updated":"2026-03-09 14:27:56.000000000","message":"You\u0027re right. I have updated the release note to clarify that the option is simply removed and should be removed from configuration files.","commit_id":"9ff4f33b4a7b1ea8a1cad610c0a2ff097e5a17e3"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"8eb17b0d5d256c75b8b8daf4c4c4462f8614911f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The deprecated ``[oslo_messaging_rabbit] heartbeat_in_pthread`` option"},{"line_number":5,"context_line":"    has been removed. The RabbitMQ driver now always runs the health check"},{"line_number":6,"context_line":"    heartbeat in a native Python thread. Remove this option from your"},{"line_number":7,"context_line":"    configuration if present; otherwise the service will fail to start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"75e8952c_e0f93277","line":7,"in_reply_to":"c652ec2d_4d411d44","updated":"2026-03-09 14:28:13.000000000","message":"Done","commit_id":"9ff4f33b4a7b1ea8a1cad610c0a2ff097e5a17e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f3873e1268f1fd78a5534e0f8f8e5f9a5004ce6e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The deprecated ``heartbeat_in_pthread`` option in the"},{"line_number":5,"context_line":"    ``[oslo_messaging_rabbit]`` section has been removed. Operators should"},{"line_number":6,"context_line":"    remove this option from their configuration files."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"12c4cdf9_c479b6d5","line":6,"range":{"start_line":5,"start_character":58,"end_line":6,"end_character":54},"updated":"2026-03-10 15:30:05.000000000","message":"This feels redundant but that\u0027s just my own preference.","commit_id":"624f8572485676e2d17b63580948b71fb5ab2b02"}]}
