)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d004e5f92756cef3d02fce327a2a0fcf30797b2d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"from oslo_log import log as logging"},{"line_number":39,"context_line":"from oslo_utils import eventletutils"},{"line_number":40,"context_line":"from oslo_utils import netutils"},{"line_number":41,"context_line":"from oslo_utils import versionutils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"import oslo_messaging"},{"line_number":44,"context_line":"from oslo_messaging._drivers import amqp as rpc_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"1dc04ae8_0762ef44","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"updated":"2026-06-03 14:05:07.000000000","message":"I\u0027m afraid you include an irrelevant change ?","commit_id":"9004d73344cf84db427552c5f1257b99c384b2dc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0e24e6102b813002f303566dc0a94e73b7e3a4b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"from oslo_log import log as logging"},{"line_number":39,"context_line":"from oslo_utils import eventletutils"},{"line_number":40,"context_line":"from oslo_utils import netutils"},{"line_number":41,"context_line":"from oslo_utils import versionutils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"import oslo_messaging"},{"line_number":44,"context_line":"from oslo_messaging._drivers import amqp as rpc_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"093bbbf4_2e220a9a","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"in_reply_to":"01b718ee_38ebd0ce","updated":"2026-06-04 14:55:29.000000000","message":"I don\u0027t get your point. Could you please explain how that \"migration to SSLContext enables ssl_enforce_hostname_verification\" ?\n\nI believe we have already merged the required fixes for SSL problems during failover, and didn\u0027t expect anything additionally caused this change. For example after we merged https://review.opendev.org/c/openstack/oslo.messaging/+/989344 we always require kombu\u003e\u003d5.2.0 and that version check does not make any sense to me.","commit_id":"9004d73344cf84db427552c5f1257b99c384b2dc"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"297145f4a09ec293b93dcc595942f642c8eb36cc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from oslo_log import log as logging"},{"line_number":39,"context_line":"from oslo_utils import eventletutils"},{"line_number":40,"context_line":"from oslo_utils import netutils"},{"line_number":41,"context_line":"from oslo_utils import versionutils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"import oslo_messaging"},{"line_number":44,"context_line":"from oslo_messaging._drivers import amqp as rpc_amqp"}],"source_content_type":"text/x-python","patch_set":2,"id":"01b718ee_38ebd0ce","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"in_reply_to":"1dc04ae8_0762ef44","updated":"2026-06-04 13:32:19.000000000","message":"The `versionutils` import is used at L936 inside `_get_ssl_server_hostname()` to check the Kombu version for multi-host TLS hostname verification. This logic was added because the migration to `SSLContext` enables `ssl_enforce_hostname_verification`, which needs to resolve the correct broker hostname during failover. Happy to split into a separate patch if you prefer.","commit_id":"9004d73344cf84db427552c5f1257b99c384b2dc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d004e5f92756cef3d02fce327a2a0fcf30797b2d","unresolved":true,"context_lines":[{"line_number":917,"context_line":"        return self.amqp_durable_queues or self.rabbit_quorum_queue"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    @classmethod"},{"line_number":920,"context_line":"    def validate_ssl_version(cls, version):"},{"line_number":921,"context_line":"        \"\"\"No-op kept for API compatibility during deprecation period.\"\"\""},{"line_number":922,"context_line":"        pass"},{"line_number":923,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"abfdc7f2_b5648e5d","line":920,"range":{"start_line":920,"start_character":8,"end_line":920,"end_character":28},"updated":"2026-06-03 14:05:07.000000000","message":"Can we add a warning message to indicate this is deprecated ? We could even remove it though, seeing this is only used internally atm.","commit_id":"9004d73344cf84db427552c5f1257b99c384b2dc"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"297145f4a09ec293b93dcc595942f642c8eb36cc","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        return self.amqp_durable_queues or self.rabbit_quorum_queue"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    @classmethod"},{"line_number":920,"context_line":"    def validate_ssl_version(cls, version):"},{"line_number":921,"context_line":"        \"\"\"No-op kept for API compatibility during deprecation period.\"\"\""},{"line_number":922,"context_line":"        pass"},{"line_number":923,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"53abc680_af93fff7","line":920,"range":{"start_line":920,"start_character":8,"end_line":920,"end_character":28},"in_reply_to":"abfdc7f2_b5648e5d","updated":"2026-06-04 13:32:19.000000000","message":"Done. Added a `LOG.warning` indicating this method is deprecated and will be removed in a future release.","commit_id":"9004d73344cf84db427552c5f1257b99c384b2dc"}]}