)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da189383d609d2a7df28737a64ca4be49fb92837","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"259c5a51_0ff66af5","updated":"2024-10-19 15:22:18.000000000","message":"Doesn\u0027t this silence eny logs (eg error logs) within the prometheus proxy server ? Logging every single log may cause too verbose log but disabling all may hide something useful for debugging.\nIf the log can be useful in debugging scenarios then at least we need a knob to re-enable the logging","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":9642,"name":"Guillaume Espanel","email":"guillaume.espanel@gmail.com","username":"quatre"},"change_message_id":"ad50cdc50f77156e5590a22bd6ca8cea7fe0a1a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e81c66d1_506882bb","updated":"2024-11-14 11:00:49.000000000","message":"Hi, this is how it\u0027s done in Prometheus client\u0027s default server [1]. I\u0027m not sure we are losing anything of value here.\n\n[1]: https://github.com/prometheus/client_python/blob/c89624f784c344803699d3bdcfb5c24b5e63307b/prometheus_client/exposition.py#L233","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"d21ff27c67b7babbfc26243c2a6ec51c800297c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fd48d58_3eebcf08","updated":"2024-11-14 09:38:16.000000000","message":"I will double check with the team, but I believe we introduced this since logging inside a greenthread was blocking the metrics server","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"fbb372d9dad531959da0f06bca61e7e55c17f2f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cada0445_6e03bf9a","in_reply_to":"259c5a51_0ff66af5","updated":"2024-11-28 19:43:55.000000000","message":"Done","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"96c0ef73b3fe89f8d07de583dcb625e3d56bc981","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3cfbfa8_acb7b5e3","in_reply_to":"3fd48d58_3eebcf08","updated":"2024-11-14 09:50:16.000000000","message":"Please correct me if I\u0027m wrong, but IIUC the logging is used by the oslo-metric server process which does not use eventlet. So I don\u0027t know how it can be related to greenthread.","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"fbb372d9dad531959da0f06bca61e7e55c17f2f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75f6bc56_e93a79dd","in_reply_to":"e3cfbfa8_acb7b5e3","updated":"2024-11-28 19:43:55.000000000","message":"Done","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"fbb372d9dad531959da0f06bca61e7e55c17f2f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5560e9de_1d11806d","in_reply_to":"e3e27052_8de9a9e3","updated":"2024-11-28 19:43:55.000000000","message":"done","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"519a5537abbd5571535d0852df16e3d900d454b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3e27052_8de9a9e3","in_reply_to":"e81c66d1_506882bb","updated":"2024-11-26 05:56:24.000000000","message":"That is a fair point. I\u0027m ok with the change itself, but the commit message really needs appropriate explanation.","commit_id":"c691f1ccd16a2e2a7da32eaeb5962791068a358a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6766b35c7ba8826debc1e224486eef952012f63b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"78767030_4e267cb3","updated":"2024-11-29 10:17:52.000000000","message":"That\u0027s seems a bit brutal to silent every WSGI server thing without allowing some configuration to enable/disable that, no?\n\nWouldn\u0027t be possible make it more optional?","commit_id":"477c563c6c29273508ad50904df19630997e5b6e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"24a47f449b8ce1a42fc5f1b59b588190b483003e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2af859c_6d2d49ca","in_reply_to":"78767030_4e267cb3","updated":"2024-12-03 06:46:37.000000000","message":"maybe we could keep the logging in debug mode. does it sound reasonable to you?","commit_id":"477c563c6c29273508ad50904df19630997e5b6e"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"f87f26ff7ee3afb66fe39568a007f7fb049ee2c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"654fb40e_193cf80c","in_reply_to":"f2af859c_6d2d49ca","updated":"2024-12-04 14:20:02.000000000","message":"The fact is that it\u0027s logging outside of any control from the service. And it\u0027s not adding any value.","commit_id":"477c563c6c29273508ad50904df19630997e5b6e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb45d86c41c68319796add8f9ae741788035d1d9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"533236ef_b2171e89","updated":"2025-01-10 19:10:27.000000000","message":"Couple of things:\n- I find it incredibly hard to believe the logging is *never* needed for troubleshooting. What\u0027s the harm in making it configurable but default-disabled?\n- Even if this is a good change to make (I\u0027m not convinced), it must be documented in a release note.\n\nThere are environments where operators would have to explain why the service stopped logging when it used to; it\u0027s completely unacceptable IMO to change this without at least some notification (a releasenote at the minimum).","commit_id":"a740c63a790eb05caed1fa281f5b2ec4890bf8ff"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"8d9e26814de1b8ff01a3298295ad50fc1fcd8af4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a05bfc14_0cf06692","in_reply_to":"533236ef_b2171e89","updated":"2025-09-04 09:56:31.000000000","message":"I added an option and a release note.\nHowever I kept the fact that the logs are silent by default now.\nI exposed this info in the release note and commit message.\n\nAny though?","commit_id":"a740c63a790eb05caed1fa281f5b2ec4890bf8ff"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"389aebf8622586c5867815b8dd3dae03535e307c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09877870_aa69a732","updated":"2025-09-12 12:46:31.000000000","message":"Hello Team!\nSince 2025.2 branch is done, do you think we can move this forward?","commit_id":"68a6f51dcac64ae4093e1da67d4b769da2b72af2"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f20ec81ad97c69d3476091db76ad400e36eb77e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ecc855c_bece5060","updated":"2025-10-10 14:14:32.000000000","message":"LGTM.\nThe latest version seems to address all the previous comments made here and there.\nI understand the reasons that motivated this patch and I agree with the turn given here.","commit_id":"68a6f51dcac64ae4093e1da67d4b769da2b72af2"}]}