)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"0fe12af93b2c8444b12d8d30b5135f4811a26ee4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"838864f3_859e021f","updated":"2024-11-05 11:36:09.000000000","message":"I agree with Takashi. Could you please provide more detailed information about the reasoning behind this change, particularly any impacts or benefits this adjustment brings?","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7dafe9f696d60da1a7dd22caeaf105905c8997b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"90ccf42e_8afbbb2c","updated":"2024-11-14 11:50:45.000000000","message":"Previous comments seems all addressed and changes LGTM.\nI just +2 for now to leave a chance to Takashi to confirm that everything is ok for him","commit_id":"106e48e8031293e43f9d2e3bd8f413a9d5eaee02"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c5c58c0b64d4f1f61bc2f0b18f51bbbc3a8da420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4dd56d9b_62a79445","updated":"2024-11-25 16:12:13.000000000","message":"Sorry I didn\u0027t notice the notification somehow.","commit_id":"106e48e8031293e43f9d2e3bd8f413a9d5eaee02"}],"oslo_metrics/__main__.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b00fe530a80b3e4f14d8428e89fe542b8df7aba3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"logging.register_options(CONF)"},{"line_number":46,"context_line":"logging.setup(CONF, \u0027oslo-metrics\u0027)"},{"line_number":47,"context_line":"LOG.logger.setLevel(logging.INFO)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class MetricsListener():"}],"source_content_type":"text/x-python","patch_set":1,"id":"80f749ef_1be87e44","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":33},"updated":"2024-10-19 15:23:38.000000000","message":"Do we even need this setLevel ? IIUC the default log level is INFO and users can enable debug by debug option or --debug.","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2fc7e7f1920789db4b522bcd7e4c50e13e494b35","unresolved":true,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"logging.register_options(CONF)"},{"line_number":46,"context_line":"logging.setup(CONF, \u0027oslo-metrics\u0027)"},{"line_number":47,"context_line":"LOG.logger.setLevel(logging.INFO)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class MetricsListener():"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3acc398_174c564e","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":33},"in_reply_to":"80f749ef_1be87e44","updated":"2024-10-19 15:25:11.000000000","message":"Also please consider adding more meaningful imformation to the commit message which justifies thiss change. (this is not specific to this single patch)","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a88f3598ad52fae1893a1c1ebba8aa7b60ab50cb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"logging.register_options(CONF)"},{"line_number":46,"context_line":"logging.setup(CONF, \u0027oslo-metrics\u0027)"},{"line_number":47,"context_line":"LOG.logger.setLevel(logging.INFO)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class MetricsListener():"}],"source_content_type":"text/x-python","patch_set":1,"id":"b78e9d3f_1779a325","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":33},"in_reply_to":"df10f8f4_2db611c5","updated":"2024-11-14 09:55:05.000000000","message":"Done","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"77ce51ef4c8b1f551c275fb2204442434a70544d","unresolved":true,"context_lines":[{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"logging.register_options(CONF)"},{"line_number":46,"context_line":"logging.setup(CONF, \u0027oslo-metrics\u0027)"},{"line_number":47,"context_line":"LOG.logger.setLevel(logging.INFO)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class MetricsListener():"}],"source_content_type":"text/x-python","patch_set":1,"id":"df10f8f4_2db611c5","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":33},"in_reply_to":"f3acc398_174c564e","updated":"2024-11-07 23:33:36.000000000","message":"++ IMO we should remove this line","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"}],"oslo_metrics/message_router.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"77ce51ef4c8b1f551c275fb2204442434a70544d","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                      (metric.action.action, metric.action.value, e))"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        LOG.debug(\"Perform action %s for %s metrics\" %"},{"line_number":81,"context_line":"                  (metric.action.action, metric.name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"953f427d_9816bc48","line":81,"updated":"2024-11-07 23:33:36.000000000","message":"I\u0027m obviously not the submitter, but my reading of this implies we\u0027re printing a log message at INFO for each metric sent -- that does seem quite excessive when looking at  https://docs.openstack.org/oslo.log/victoria/user/guidelines.html#definition-of-log-levels","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a88f3598ad52fae1893a1c1ebba8aa7b60ab50cb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      (metric.action.action, metric.action.value, e))"},{"line_number":79,"context_line":"            return"},{"line_number":80,"context_line":"        LOG.debug(\"Perform action %s for %s metrics\" %"},{"line_number":81,"context_line":"                  (metric.action.action, metric.name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1bb0f48_2d0ac559","line":81,"in_reply_to":"953f427d_9816bc48","updated":"2024-11-14 09:55:05.000000000","message":"I updated the message commit to explain this.\nIn a short, some services are receiving a lot of messages, like nova-conductor, neutron-rpc, etc. \nUnder this condition, it\u0027s logging too much.\nEach RPC message will add a log info.","commit_id":"a85858dfd478f796ac61a48ca0f67eb988bd07f3"}]}