)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"231a23ff1644c82dceea81aa238a27c65a9ad942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de9f37ea_1f10a1f2","updated":"2025-03-05 10:29:10.000000000","message":"Note that we are at the feature freeze phase and may not merge new features until stable branches are cut.","commit_id":"a194dd85d8f45b3dfbb40f0c8f5b18a410a368df"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c9d244da04230b61510568745b4c758cfaf0119e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb832196_cb8aadda","updated":"2025-03-05 15:00:18.000000000","message":"Sorry I overlooked this in my previous review, but could you please also add a release note to explain the new feature ?","commit_id":"09b1a8906a3b27b7c57075448f92b93d96818727"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"dd4f6bce3959d1ebfb75e527743865d5a76491c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6d89a6e_3a5289bb","updated":"2025-03-08 18:23:00.000000000","message":"That\u0027s good for me.\nLet\u0027s approve this but we will have to wait after epoxy release to merge this","commit_id":"b9e4d4009488ed71e27dd27c1ea8fab45532d889"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"37a2e26641c09dd5da7533608b7e170edc4ee0c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5cbe9019_c3af204d","updated":"2025-03-09 12:47:45.000000000","message":"Fixed a minor formatting in the release note. As noted, we may have to wait for branching before we merge this.","commit_id":"be7067daec2e012f95d4bdf009d7d02906c30af8"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6867f8f7f94dba734676cb8e19a0b03a6aa55529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"810d3b72_dd6a8614","updated":"2025-03-10 09:09:22.000000000","message":"LGTM. As we are in feature freeze, I let Takashi decide if we want to merge it now or after the branching.","commit_id":"be7067daec2e012f95d4bdf009d7d02906c30af8"}],"oslo_metrics/__main__.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"231a23ff1644c82dceea81aa238a27c65a9ad942","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":36,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":37,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027metrics_socket_perm\u0027, default\u003d\u00270o660\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Set permission for socket\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":"cfg.CONF.register_opts(oslo_metrics_configs, group\u003d\u0027oslo_metrics\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6a4dc39_b986937d","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":14},"updated":"2025-03-05 10:29:10.000000000","message":"You can use IntOpt instead of StrOpt, with default set to 0x660","commit_id":"a194dd85d8f45b3dfbb40f0c8f5b18a410a368df"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"926f65d8b3c4ad5c818806c1980d5301eadd3356","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":36,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":37,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027metrics_socket_perm\u0027, default\u003d\u00270o660\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Set permission for socket\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":"cfg.CONF.register_opts(oslo_metrics_configs, group\u003d\u0027oslo_metrics\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b9cc7c0_5a88d0ef","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":14},"in_reply_to":"d6a4dc39_b986937d","updated":"2025-03-05 15:44:14.000000000","message":"Done","commit_id":"a194dd85d8f45b3dfbb40f0c8f5b18a410a368df"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"231a23ff1644c82dceea81aa238a27c65a9ad942","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":37,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027metrics_socket_perm\u0027, default\u003d\u00270o660\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Set permission for socket\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":"cfg.CONF.register_opts(oslo_metrics_configs, group\u003d\u0027oslo_metrics\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d7b4357d_dcee9769","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":35},"updated":"2025-03-05 10:29:10.000000000","message":"This is not very accurate because this does not control whether the permission is set, but controls the actual permission set in the socket.\n\nSo I prefer something like \"Permission set to the unix domain socket file\"","commit_id":"a194dd85d8f45b3dfbb40f0c8f5b18a410a368df"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"926f65d8b3c4ad5c818806c1980d5301eadd3356","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":37,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027metrics_socket_perm\u0027, default\u003d\u00270o660\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Set permission for socket\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":"cfg.CONF.register_opts(oslo_metrics_configs, group\u003d\u0027oslo_metrics\u0027)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6ecb179f_41f41d45","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":35},"in_reply_to":"d7b4357d_dcee9769","updated":"2025-03-05 15:44:14.000000000","message":"Done","commit_id":"a194dd85d8f45b3dfbb40f0c8f5b18a410a368df"}]}