)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0363a2d706350d6b31e7c1f5e8b477899316be2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"739f3f3e_c5e267a1","updated":"2025-10-07 08:53:08.000000000","message":"Thanks. A release note would be welcome","commit_id":"a25f93748ad66dd3e648a01b4f60c7621da26fce"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f471466839eee214223ab35e88f88558e72fd0b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43c2658e_6816d2f9","updated":"2025-11-24 16:08:29.000000000","message":"I agree with the change direction but have a few suggestions I think we should address before merging this.","commit_id":"83a97a666158fe1031e3b40878369fa28dbfb993"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"dc3bb5dac05da98a8c14dccee599418ab141a23b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed737f17_03b655d5","updated":"2025-12-08 09:02:20.000000000","message":"LGTM","commit_id":"ef48ca9f465c4e8a553a2c6135b858d9a89ebadf"}],"oslo_metrics/__main__.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"b05602de71566f78fce2719e2fd59b4ffb217d17","unresolved":true,"context_lines":[{"line_number":34,"context_line":"               default\u003d\u0027/var/tmp/metrics_collector.sock\u0027,  # nosec"},{"line_number":35,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":36,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027server_address\u0027, default\u003d\u0027\u0027, help\u003d\u0027Address to serve metrics.\u0027),"},{"line_number":38,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":39,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027metrics_socket_perm\u0027, default\u003d0o660,"}],"source_content_type":"text/x-python","patch_set":3,"id":"82686c2a_878f130e","line":37,"updated":"2025-10-20 14:53:01.000000000","message":"if a later patchset should be pushed, maybe that would be worth adding an info about what the default values does (listeing on any address IIRC)","commit_id":"7b67bde618f0e43c5f9f75ce32dbfa31441dd409"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"3c4694cb625ef5949c28ec0512e75226d21f2c44","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               default\u003d\u0027/var/tmp/metrics_collector.sock\u0027,  # nosec"},{"line_number":35,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":36,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027server_address\u0027, default\u003d\u0027\u0027, help\u003d\u0027Address to serve metrics.\u0027),"},{"line_number":38,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":39,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027metrics_socket_perm\u0027, default\u003d0o660,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6af036ed_9e7d29dc","line":37,"in_reply_to":"82686c2a_878f130e","updated":"2025-11-25 08:59:58.000000000","message":"Done","commit_id":"7b67bde618f0e43c5f9f75ce32dbfa31441dd409"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f471466839eee214223ab35e88f88558e72fd0b8","unresolved":true,"context_lines":[{"line_number":34,"context_line":"               default\u003d\u0027/var/tmp/metrics_collector.sock\u0027,  # nosec"},{"line_number":35,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":36,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027server_address\u0027, default\u003d\u0027\u0027, help\u003d\u0027Address to serve metrics.\u0027),"},{"line_number":38,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":39,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027metrics_socket_perm\u0027, default\u003d0o660,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c83d7ff1_52d46a5f","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":30},"updated":"2025-11-24 16:08:29.000000000","message":"I wonder if this needs to be an address or can it be a hostname ? (if then _host would be a better naming)\n\nAlso for consistency with the existing prometheus_port option can we use the prometheus_ prefix ?","commit_id":"83a97a666158fe1031e3b40878369fa28dbfb993"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"3c4694cb625ef5949c28ec0512e75226d21f2c44","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               default\u003d\u0027/var/tmp/metrics_collector.sock\u0027,  # nosec"},{"line_number":35,"context_line":"               help\u003d\u0027Unix domain socket file to be used\u0027"},{"line_number":36,"context_line":"                    \u0027 to send rpc related metrics\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027server_address\u0027, default\u003d\u0027\u0027, help\u003d\u0027Address to serve metrics.\u0027),"},{"line_number":38,"context_line":"    cfg.PortOpt(\u0027prometheus_port\u0027, default\u003d3000,"},{"line_number":39,"context_line":"                help\u003d\u0027Port number to expose metrics in prometheus format.\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027metrics_socket_perm\u0027, default\u003d0o660,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c375d082_78fb2ff6","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":30},"in_reply_to":"c83d7ff1_52d46a5f","updated":"2025-11-25 08:59:58.000000000","message":"Done","commit_id":"83a97a666158fe1031e3b40878369fa28dbfb993"}],"releasenotes/notes/server-address-6baf333c21788995.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f471466839eee214223ab35e88f88558e72fd0b8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added option to configure server address for serving metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e170e10a_3680b7d2","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":16},"updated":"2025-11-24 16:08:29.000000000","message":"Can we write the specific option name here ?","commit_id":"83a97a666158fe1031e3b40878369fa28dbfb993"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"3c4694cb625ef5949c28ec0512e75226d21f2c44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added option to configure server address for serving metrics."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2d4dd641_1c40aaac","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":16},"in_reply_to":"e170e10a_3680b7d2","updated":"2025-11-25 08:59:58.000000000","message":"Done","commit_id":"83a97a666158fe1031e3b40878369fa28dbfb993"}]}
