)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"aa2b98af397b2c9d0c5e9df4513bc8bcc7742c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d52da355_e0330c6e","updated":"2026-10-13 06:24:51.000000000","message":"@kajinamit@oss.nttdata.com thanks for your review. who else could look at this?","commit_id":"1ea57081ef16ba68d1f7bb98ab01142b814a0c4c"}],"oslo_middleware/basic_auth.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        \u0027http_basic_auth_user_file\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027/etc/htpasswd\u0027,"},{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":44,"context_line":"        deprecated_reason\u003d("},{"line_number":45,"context_line":"            \u0027The basic auth middleware that this option configures is \u0027"},{"line_number":46,"context_line":"            \u0027deprecated for removal.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"f779cef2_9ff6f945","line":43,"range":{"start_line":43,"start_character":26,"end_line":43,"end_character":32},"updated":"2026-10-05 17:36:10.000000000","message":"Libraries may have multiple releases during a single cycle so we may want to use the specific version (we expect 8.3.0 would be the next release version) rather than a release name.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027http_basic_auth_user_file\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027/etc/htpasswd\u0027,"},{"line_number":42,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":43,"context_line":"        deprecated_since\u003d\u00272027.1\u0027,"},{"line_number":44,"context_line":"        deprecated_reason\u003d("},{"line_number":45,"context_line":"            \u0027The basic auth middleware that this option configures is \u0027"},{"line_number":46,"context_line":"            \u0027deprecated for removal.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"99c7b853_3f8468f5","line":43,"in_reply_to":"f779cef2_9ff6f945","updated":"2026-10-06 08:14:40.000000000","message":"Done, deprecated_since\u003d\u00278.3.0\u0027.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":60,"context_line":"class BasicAuthMiddleware(base.ConfigurableMiddleware):"},{"line_number":61,"context_line":"    \"\"\"Middleware which performs HTTP basic authentication on requests"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    .. deprecated:: 2027.1"},{"line_number":64,"context_line":"        Deprecated for removal. Terminate HTTP basic authentication in a web"},{"line_number":65,"context_line":"        server in front of the service, or use keystone."},{"line_number":66,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"2415c61f_82911b15","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":26},"updated":"2026-10-05 17:36:10.000000000","message":"ditto. Use 8.3.0","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class BasicAuthMiddleware(base.ConfigurableMiddleware):"},{"line_number":61,"context_line":"    \"\"\"Middleware which performs HTTP basic authentication on requests"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    .. deprecated:: 2027.1"},{"line_number":64,"context_line":"        Deprecated for removal. Terminate HTTP basic authentication in a web"},{"line_number":65,"context_line":"        server in front of the service, or use keystone."},{"line_number":66,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"cb4ed555_d7dc9cc8","line":63,"in_reply_to":"2415c61f_82911b15","updated":"2026-10-06 08:14:40.000000000","message":"Done, \u0027.. deprecated:: 8.3.0\u0027.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        self,"},{"line_number":70,"context_line":"        application: WSGIApplication | None,"},{"line_number":71,"context_line":"        conf: dict[str, Any] | cfg.ConfigOpts | None \u003d None,"},{"line_number":72,"context_line":"    ) -\u003e None:"},{"line_number":73,"context_line":"        # NOTE: Warn from here rather than at module scope, since"},{"line_number":74,"context_line":"        # oslo_middleware/__init__.py imports this module and a module scope"},{"line_number":75,"context_line":"        # warning would reach every consumer of the package rather than the"},{"line_number":76,"context_line":"        # users of this middleware."},{"line_number":77,"context_line":"        message \u003d ("},{"line_number":78,"context_line":"            f\u0027The {__name__} module is deprecated for removal. Terminate \u0027"},{"line_number":79,"context_line":"            f\u0027HTTP basic authentication in a web server in front of the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"8662bb15_d729505e","line":76,"range":{"start_line":72,"start_character":14,"end_line":76,"end_character":35},"updated":"2026-10-05 17:36:10.000000000","message":"Can we remove this from the code ? IMHO we can understand the intention without this comment kept here.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE: Warn from here rather than at module scope, since"},{"line_number":74,"context_line":"        # oslo_middleware/__init__.py imports this module and a module scope"},{"line_number":75,"context_line":"        # warning would reach every consumer of the package rather than the"},{"line_number":76,"context_line":"        # users of this middleware."},{"line_number":77,"context_line":"        message \u003d ("},{"line_number":78,"context_line":"            f\u0027The {__name__} module is deprecated for removal. Terminate \u0027"},{"line_number":79,"context_line":"            f\u0027HTTP basic authentication in a web server in front of the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"17b68b37_64b92e37","line":76,"in_reply_to":"8662bb15_d729505e","updated":"2026-10-06 08:14:40.000000000","message":"Done, removed.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        # from the DeprecationWarning above is attributed to"},{"line_number":86,"context_line":"        # oslo_middleware/base.py rather than __main__, so Python\u0027s default"},{"line_number":87,"context_line":"        # warning filters discard it and the operator would be told nothing."},{"line_number":88,"context_line":"        LOG.warning(message)"},{"line_number":89,"context_line":"        super().__init__(application, conf)"},{"line_number":90,"context_line":"        self.auth_file \u003d cfg.CONF.oslo_middleware.http_basic_auth_user_file"},{"line_number":91,"context_line":"        validate_auth_file(self.auth_file)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7f2318c_0c10a19c","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":28},"updated":"2026-10-05 17:36:10.000000000","message":"I wonder if just having this warning log would be enough ? I think the log always appears.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # from the DeprecationWarning above is attributed to"},{"line_number":86,"context_line":"        # oslo_middleware/base.py rather than __main__, so Python\u0027s default"},{"line_number":87,"context_line":"        # warning filters discard it and the operator would be told nothing."},{"line_number":88,"context_line":"        LOG.warning(message)"},{"line_number":89,"context_line":"        super().__init__(application, conf)"},{"line_number":90,"context_line":"        self.auth_file \u003d cfg.CONF.oslo_middleware.http_basic_auth_user_file"},{"line_number":91,"context_line":"        validate_auth_file(self.auth_file)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5cfe3543_30c5bcc1","line":88,"in_reply_to":"a7f2318c_0c10a19c","updated":"2026-10-06 08:14:40.000000000","message":"Agreed, it now only logs the warning. warnings.warn and the comments explaining it are gone.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"}],"oslo_middleware/tests/test_auth_basic.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            self.assertEqual(\u0027Unsupported authorization type \"Digest\"\u0027, str(e))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class TestAuthBasicDeprecation(test_base.BaseTestCase):"},{"line_number":211,"context_line":"    def setUp(self):"},{"line_number":212,"context_line":"        super().setUp()"},{"line_number":213,"context_line":"        with tempfile.NamedTemporaryFile(mode\u003d\u0027w\u0027, delete\u003dFalse) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0536db02_72203b68","line":210,"range":{"start_line":210,"start_character":6,"end_line":210,"end_character":30},"updated":"2026-10-05 17:36:10.000000000","message":"We don\u0027t really need a separate class, IMHO. If needed we can create a helper to build the middleware/app.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            self.assertEqual(\u0027Unsupported authorization type \"Digest\"\u0027, str(e))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class TestAuthBasicDeprecation(test_base.BaseTestCase):"},{"line_number":211,"context_line":"    def setUp(self):"},{"line_number":212,"context_line":"        super().setUp()"},{"line_number":213,"context_line":"        with tempfile.NamedTemporaryFile(mode\u003d\u0027w\u0027, delete\u003dFalse) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"38a34077_ca1f0cb0","line":210,"in_reply_to":"0536db02_72203b68","updated":"2026-10-06 08:14:40.000000000","message":"Done, the class is gone and the log test is in TestAuthBasic, following the existing tests\u0027 pattern.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":254,"context_line":"            \u0027deprecated for removal\u0027, mock_log.warning.call_args[0][0]"},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_import_does_not_warn(self):"},{"line_number":258,"context_line":"        \"\"\"The warning must not fire for consumers that merely import."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        oslo_middleware/__init__.py imports this module, so a module scope"},{"line_number":261,"context_line":"        warning would reach every consumer of the package. Check in a"},{"line_number":262,"context_line":"        subprocess so the already imported module cannot mask it."},{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":"        result \u003d subprocess.run("},{"line_number":265,"context_line":"            ["},{"line_number":266,"context_line":"                sys.executable,"},{"line_number":267,"context_line":"                \u0027-W\u0027,"},{"line_number":268,"context_line":"                \u0027error::DeprecationWarning\u0027,"},{"line_number":269,"context_line":"                \u0027-c\u0027,"},{"line_number":270,"context_line":"                \u0027import oslo_middleware\u0027,"},{"line_number":271,"context_line":"            ],"},{"line_number":272,"context_line":"            capture_output\u003dTrue,"},{"line_number":273,"context_line":"            text\u003dTrue,"},{"line_number":274,"context_line":"        )"},{"line_number":275,"context_line":"        self.assertEqual(0, result.returncode, result.stderr)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_option_is_marked_deprecated(self):"},{"line_number":278,"context_line":"        (opt,) \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"6c5b946e_40b22307","line":275,"range":{"start_line":257,"start_character":0,"end_line":275,"end_character":61},"updated":"2026-10-05 17:36:10.000000000","message":"We don\u0027t usually implement such test and I find it sort of over-complicated output from AI. I\u0027d rather remove it.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            capture_output\u003dTrue,"},{"line_number":273,"context_line":"            text\u003dTrue,"},{"line_number":274,"context_line":"        )"},{"line_number":275,"context_line":"        self.assertEqual(0, result.returncode, result.stderr)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_option_is_marked_deprecated(self):"},{"line_number":278,"context_line":"        (opt,) \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"a767b5ff_3a2bd870","line":275,"in_reply_to":"6c5b946e_40b22307","updated":"2026-10-06 08:14:40.000000000","message":"Removed. It was also what failed openstack-tox-py311: webob imports the deprecated cgi module on 3.11.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7008dd8eef67b56dbaf4816f6c172b17608c03f2","unresolved":true,"context_lines":[{"line_number":274,"context_line":"        )"},{"line_number":275,"context_line":"        self.assertEqual(0, result.returncode, result.stderr)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_option_is_marked_deprecated(self):"},{"line_number":278,"context_line":"        (opt,) \u003d ("},{"line_number":279,"context_line":"            o for o in auth.OPTS if o.name \u003d\u003d \u0027http_basic_auth_user_file\u0027"},{"line_number":280,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"a0b20a19_269411aa","line":277,"range":{"start_line":277,"start_character":0,"end_line":277,"end_character":2},"updated":"2026-10-05 17:36:10.000000000","message":"IMHO this test doesn\u0027t match benefit. I\u0027m for dropping it.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6895b79654342d16b21aaf2397b2bf9398cf5815","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        )"},{"line_number":275,"context_line":"        self.assertEqual(0, result.returncode, result.stderr)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_option_is_marked_deprecated(self):"},{"line_number":278,"context_line":"        (opt,) \u003d ("},{"line_number":279,"context_line":"            o for o in auth.OPTS if o.name \u003d\u003d \u0027http_basic_auth_user_file\u0027"},{"line_number":280,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"ed98ec46_3ea1eb23","line":277,"in_reply_to":"a0b20a19_269411aa","updated":"2026-10-06 08:14:40.000000000","message":"Removed.","commit_id":"1607d7f553be9673ba7a29f991d5c36abec98a42"}]}
