)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Obtain API tracers directly from the provider initialized by middleware. A global provider owned by OSProfiler can otherwise cause API spans to use another service\u0027s Resource, exporter, and sampler."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Keep middleware provider initialization and shutdown independent while preserving shared W3C context for downstream instrumentation. Add real SDK regressions and document provider ownership and messaging fallback."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Assisted-By: Codex GPT-6"},{"line_number":14,"context_line":"Change-Id: I251f689820fa97afa257d93fe069681d28b124ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ca1cf79_5307d896","line":11,"updated":"2026-10-05 15:09:24.000000000","message":"Can you wrap at \u003c\u003d 72 characters","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"56876c6767b9918a40fcb29e2adc9f9974cda8fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Obtain API tracers directly from the provider initialized by middleware. A global provider owned by OSProfiler can otherwise cause API spans to use another service\u0027s Resource, exporter, and sampler."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Keep middleware provider initialization and shutdown independent while preserving shared W3C context for downstream instrumentation. Add real SDK regressions and document provider ownership and messaging fallback."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Assisted-By: Codex GPT-6"},{"line_number":14,"context_line":"Change-Id: I251f689820fa97afa257d93fe069681d28b124ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d9965ebb_3d0c6745","line":11,"in_reply_to":"9ca1cf79_5307d896","updated":"2026-10-06 09:05:11.000000000","message":"Done","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d771ba11f5d33edc9cc4919c5e80017692383cc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f83d1e74_b1410f1e","updated":"2026-10-05 15:06:19.000000000","message":"Sorry about the documents that were wrongly included in the commit, I have removed them.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aef640d0_08fbe44d","updated":"2026-10-05 15:09:24.000000000","message":"Those tests read like AI-generated tests 😅 I don\u0027t know about you but I can\u0027t understand them","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"0a220b89a6ab2f3757577fa19f53721c595e154d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15479488_ad0052f9","in_reply_to":"aef640d0_08fbe44d","updated":"2026-10-05 15:27:34.000000000","message":"Yeah, you are right, i was trying \"new things\" and this turned out to be a s***t show. Let me fix everything.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3964531c38bc3951db1b25fee6c1d8b820ac68f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"26587c16_8b9927bf","updated":"2026-10-06 17:08:48.000000000","message":"There\u0027s one outstanding request here. Otherwise this looks pretty good to me","commit_id":"48edd7e9715e18f8dc5562029e15c1bde8bc3855"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ab019f1a09865f099328b93d249cbed37b9a4365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69fe3505_b82a2ea8","in_reply_to":"26587c16_8b9927bf","updated":"2026-10-06 17:29:36.000000000","message":"Ah yes! that one slipped through the cracks. I have addressed it adding a small comment on a new patchset.","commit_id":"48edd7e9715e18f8dc5562029e15c1bde8bc3855"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"de8ca25c38d14b38e774ed2c123ead9827df7734","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1e777bd_bd1515fc","updated":"2026-10-08 12:52:56.000000000","message":"@stephenfin@redhat.com are you satisfied with this fix?","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5418e40e04043154a8b431c845b2406a9c6678eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa1853b1_6af4db6f","updated":"2026-10-08 13:39:32.000000000","message":"I think Takashi-san would be a good second +2 on this. He has lots of osprofiler context (more than me)","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4faeb6eb4ffef08cf1aed997b85968e0ecbfda10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"844f15f3_25456f02","updated":"2026-10-08 14:36:34.000000000","message":"One question about the behavior and a few suggestions about unit tests. Adding -1 to highlight the question so that it is cleared/answered before we merge this.\n\nI\u0027m ok to address suggestions as follow-up if you want, though fixing these in a single commit may ease backports.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2c099522377486e2bedcede830bdf9fe7b82b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c332d4bc_100bbef6","updated":"2026-10-08 13:43:54.000000000","message":"The change looks good at my first glance but let me take a deeper look. Will post my feedback soon.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9a8a69f7e5d63d288dbd967aacc2f14a553b16fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2291409e_6221b00c","updated":"2026-10-08 15:02:25.000000000","message":"Valid comments from Takashi-san.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6764be3f0ac2e5a8b754de938814d9687ae91c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e60e7bf3_7708206a","in_reply_to":"a1e777bd_bd1515fc","updated":"2026-10-08 13:38:08.000000000","message":"Sure am 👌","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb36233af9911ce15afb4723cc577fef161f600a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"da9ba566_f55f4461","updated":"2026-10-09 19:19:46.000000000","message":"changes since PS6 lgtm","commit_id":"df6414115e9b660c376708d2aa9c4e4d6f7be6e5"}],"changes_tracing_implementation.md":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09d3baaa62155a8935b419326fd89f4d82d4f091","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Tracing Provider Fix Implementation"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Branch and commit"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"feaeb33f_da9fa895","line":1,"updated":"2026-10-05 15:03:53.000000000","message":"whoops","commit_id":"5f09d86e490f17d84671b9fdf77dd406775b42f4"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d771ba11f5d33edc9cc4919c5e80017692383cc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Tracing Provider Fix Implementation"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Branch and commit"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"9a810612_e99a2759","line":1,"in_reply_to":"feaeb33f_da9fa895","updated":"2026-10-05 15:06:19.000000000","message":"Yeahhhh, whooops, sorry about that :(","commit_id":"5f09d86e490f17d84671b9fdf77dd406775b42f4"}],"doc/source/reference/tracing.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09d3baaa62155a8935b419326fd89f4d82d4f091","unresolved":true,"context_lines":[{"line_number":1,"context_line":"OpenTelemetry tracing"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Enable API tracing with ``[oslo_middleware_tracing] enabled\u003dtrue`` and set"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7e9e34ee_9f70cd09","line":1,"updated":"2026-10-05 15:03:53.000000000","message":"Can you structure this document to be more like other docs here like the `cors.rst` doc? It probably should be a separate precursor change also","commit_id":"5f09d86e490f17d84671b9fdf77dd406775b42f4"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"d771ba11f5d33edc9cc4919c5e80017692383cc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenTelemetry tracing"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Enable API tracing with ``[oslo_middleware_tracing] enabled\u003dtrue`` and set"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4e3faefb_034e501d","line":1,"in_reply_to":"7e9e34ee_9f70cd09","updated":"2026-10-05 15:06:19.000000000","message":"This is another whooops, it does not belong here, sorry, internal documents leaked by mistake.","commit_id":"5f09d86e490f17d84671b9fdf77dd406775b42f4"}],"oslo_middleware/tests/test_tracing.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        return list(self._spans)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestTracingProviderOwnership(test_base.BaseTestCase):"},{"line_number":350,"context_line":"    def patch_object(self, target, name, **kwargs):"},{"line_number":351,"context_line":"        patcher \u003d mock.patch.object(target, name, **kwargs)"},{"line_number":352,"context_line":"        result \u003d patcher.start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"26608639_420bd7a4","line":349,"updated":"2026-10-05 15:09:24.000000000","message":"idk about you but I find this test pretty inscrutable. It\u0027s not even clear to me what you\u0027re attempting to do here. Can you take a second run at this?","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"56876c6767b9918a40fcb29e2adc9f9974cda8fc","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        return list(self._spans)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestTracingProviderOwnership(test_base.BaseTestCase):"},{"line_number":350,"context_line":"    def patch_object(self, target, name, **kwargs):"},{"line_number":351,"context_line":"        patcher \u003d mock.patch.object(target, name, **kwargs)"},{"line_number":352,"context_line":"        result \u003d patcher.start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"41b20540_09af1935","line":349,"in_reply_to":"26608639_420bd7a4","updated":"2026-10-06 09:05:11.000000000","message":"I have tried to re-write it in a much more approachable way and also added a comment. I think it is much more understable now.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestTracingProviderOwnership(test_base.BaseTestCase):"},{"line_number":350,"context_line":"    def patch_object(self, target, name, **kwargs):"},{"line_number":351,"context_line":"        patcher \u003d mock.patch.object(target, name, **kwargs)"},{"line_number":352,"context_line":"        result \u003d patcher.start()"},{"line_number":353,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":354,"context_line":"        return result"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def setUp(self):"},{"line_number":357,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd55dace_c4f3b81a","line":354,"range":{"start_line":350,"start_character":0,"end_line":354,"end_character":21},"updated":"2026-10-05 15:09:24.000000000","message":"This isn\u0027t needed: use the `MockPatchObject` fixture from `fixtures`.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"56876c6767b9918a40fcb29e2adc9f9974cda8fc","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestTracingProviderOwnership(test_base.BaseTestCase):"},{"line_number":350,"context_line":"    def patch_object(self, target, name, **kwargs):"},{"line_number":351,"context_line":"        patcher \u003d mock.patch.object(target, name, **kwargs)"},{"line_number":352,"context_line":"        result \u003d patcher.start()"},{"line_number":353,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":354,"context_line":"        return result"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def setUp(self):"},{"line_number":357,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"86061797_13cef33b","line":354,"range":{"start_line":350,"start_character":0,"end_line":354,"end_character":21},"in_reply_to":"bd55dace_c4f3b81a","updated":"2026-10-06 09:05:11.000000000","message":"Done","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":375,"context_line":"                {\u0027service.name\u0027: \u0027openstack-nova-osapi_compute\u0027}"},{"line_number":376,"context_line":"            ),"},{"line_number":377,"context_line":"            shutdown_on_exit\u003dFalse,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        self.foreign.add_span_processor("},{"line_number":380,"context_line":"            SimpleSpanProcessor(self.foreign_exporter)  # type: ignore[arg-type] # noqa: E501"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        self.addCleanup(self.foreign.shutdown)"},{"line_number":383,"context_line":"        self.set_global \u003d self.useFixture("},{"line_number":384,"context_line":"            fixtures.MockPatchObject(trace, \u0027set_tracer_provider\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4a6f5486_b97e9f8d","line":381,"range":{"start_line":378,"start_character":9,"end_line":381,"end_character":9},"updated":"2026-10-06 10:10:54.000000000","message":"nit:\n\n```suggestion\n        )\n        span_processor \u003d SimpleSpanProcessor(self.foreign_exporter)\n        self.foreign.add_span_processor(span_processor) # type: ignore[arg-type]\n```","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"e5803b9f6f5bd158a47ac40d4f4ae6a47f9a7043","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                {\u0027service.name\u0027: \u0027openstack-nova-osapi_compute\u0027}"},{"line_number":376,"context_line":"            ),"},{"line_number":377,"context_line":"            shutdown_on_exit\u003dFalse,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        self.foreign.add_span_processor("},{"line_number":380,"context_line":"            SimpleSpanProcessor(self.foreign_exporter)  # type: ignore[arg-type] # noqa: E501"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        self.addCleanup(self.foreign.shutdown)"},{"line_number":383,"context_line":"        self.set_global \u003d self.useFixture("},{"line_number":384,"context_line":"            fixtures.MockPatchObject(trace, \u0027set_tracer_provider\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4b80448_8b8caf08","line":381,"range":{"start_line":378,"start_character":9,"end_line":381,"end_character":9},"in_reply_to":"4a6f5486_b97e9f8d","updated":"2026-10-06 12:36:05.000000000","message":"Fix applied.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"b110766a13e777130bf3655f109b4b40623a84e1","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                {\u0027service.name\u0027: \u0027openstack-nova-osapi_compute\u0027}"},{"line_number":376,"context_line":"            ),"},{"line_number":377,"context_line":"            shutdown_on_exit\u003dFalse,"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        self.foreign.add_span_processor("},{"line_number":380,"context_line":"            SimpleSpanProcessor(self.foreign_exporter)  # type: ignore[arg-type] # noqa: E501"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        self.addCleanup(self.foreign.shutdown)"},{"line_number":383,"context_line":"        self.set_global \u003d self.useFixture("},{"line_number":384,"context_line":"            fixtures.MockPatchObject(trace, \u0027set_tracer_provider\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f040576_2f7e8908","line":381,"range":{"start_line":378,"start_character":9,"end_line":381,"end_character":9},"in_reply_to":"f4b80448_8b8caf08","updated":"2026-10-06 12:49:35.000000000","message":"I had to modify it a little bit. the type: ignore must go on the \"self.foreign_exporter\" line","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            \u0027service_name\u0027, \u0027nova-api\u0027, group\u003d\u0027oslo_middleware_tracing\u0027"},{"line_number":407,"context_line":"        )"},{"line_number":408,"context_line":"        self.addCleanup(tracing.shutdown_tracing)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        @webob.dec.wsgify"},{"line_number":411,"context_line":"        def app(req):"},{"line_number":412,"context_line":"            return \u0027Hello\u0027"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self.app \u003d app"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _request(self, app\u003dNone, traceparent\u003dNone):"},{"line_number":417,"context_line":"        middleware \u003d tracing.TracingMiddleware(app or self.app, self.conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4020fa37_ed0bb6bd","line":414,"range":{"start_line":409,"start_character":1,"end_line":414,"end_character":22},"updated":"2026-10-06 10:10:54.000000000","message":"Assuming we are able to join `test_api_span_uses_middleware_provider_not_global` and `test_middleware_does_not_replace_global_provider` (see below), this should be moved into the combined test","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"53d77e1af559532668da0a36c05095c536ffa29a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            \u0027service_name\u0027, \u0027nova-api\u0027, group\u003d\u0027oslo_middleware_tracing\u0027"},{"line_number":407,"context_line":"        )"},{"line_number":408,"context_line":"        self.addCleanup(tracing.shutdown_tracing)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        @webob.dec.wsgify"},{"line_number":411,"context_line":"        def app(req):"},{"line_number":412,"context_line":"            return \u0027Hello\u0027"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        self.app \u003d app"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _request(self, app\u003dNone, traceparent\u003dNone):"},{"line_number":417,"context_line":"        middleware \u003d tracing.TracingMiddleware(app or self.app, self.conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"76169d99_8228377c","line":414,"range":{"start_line":409,"start_character":1,"end_line":414,"end_character":22},"in_reply_to":"4020fa37_ed0bb6bd","updated":"2026-10-06 13:07:03.000000000","message":"Done","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_api_span_uses_middleware_provider_not_global(self):"},{"line_number":428,"context_line":"        self._request()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        (span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":431,"context_line":"        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)"},{"line_number":432,"context_line":"        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])"},{"line_number":433,"context_line":"        # The foreign global provider must not receive the API span."},{"line_number":434,"context_line":"        self.assertEqual([], self.foreign_exporter.get_finished_spans())"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_middleware_does_not_replace_global_provider(self):"},{"line_number":437,"context_line":"        self._request()"}],"source_content_type":"text/x-python","patch_set":3,"id":"52ef7c3f_f6e399ad","line":434,"range":{"start_line":429,"start_character":1,"end_line":434,"end_character":72},"updated":"2026-10-06 10:10:54.000000000","message":"```suggestion\n\n        self.assertEqual(1, len(self.api_exporter.get_finished_spans()))\n        (span,) \u003d self.api_exporter.get_finished_spans()\n        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)\n        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])\n        # The foreign global provider must not receive the API span.\n        self.assertEqual(0, len(self.api_exporter.get_finished_spans()))\n```","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"b110766a13e777130bf3655f109b4b40623a84e1","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_api_span_uses_middleware_provider_not_global(self):"},{"line_number":428,"context_line":"        self._request()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        (span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":431,"context_line":"        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)"},{"line_number":432,"context_line":"        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])"},{"line_number":433,"context_line":"        # The foreign global provider must not receive the API span."},{"line_number":434,"context_line":"        self.assertEqual([], self.foreign_exporter.get_finished_spans())"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_middleware_does_not_replace_global_provider(self):"},{"line_number":437,"context_line":"        self._request()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc9b4edb_86f18809","line":434,"range":{"start_line":429,"start_character":1,"end_line":434,"end_character":72},"in_reply_to":"4ee58285_df0c90a2","updated":"2026-10-06 12:49:35.000000000","message":"The api_exporter variable here must be foreign_exporter for the test to make sense.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"e5803b9f6f5bd158a47ac40d4f4ae6a47f9a7043","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_api_span_uses_middleware_provider_not_global(self):"},{"line_number":428,"context_line":"        self._request()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        (span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":431,"context_line":"        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)"},{"line_number":432,"context_line":"        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])"},{"line_number":433,"context_line":"        # The foreign global provider must not receive the API span."},{"line_number":434,"context_line":"        self.assertEqual([], self.foreign_exporter.get_finished_spans())"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_middleware_does_not_replace_global_provider(self):"},{"line_number":437,"context_line":"        self._request()"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ee58285_df0c90a2","line":434,"range":{"start_line":429,"start_character":1,"end_line":434,"end_character":72},"in_reply_to":"52ef7c3f_f6e399ad","updated":"2026-10-06 12:36:05.000000000","message":"Fix applied.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":424,"context_line":"        tracing._TRACER_PROVIDER.force_flush()"},{"line_number":425,"context_line":"        return response"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_api_span_uses_middleware_provider_not_global(self):"},{"line_number":428,"context_line":"        self._request()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        (span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":431,"context_line":"        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)"},{"line_number":432,"context_line":"        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])"},{"line_number":433,"context_line":"        # The foreign global provider must not receive the API span."},{"line_number":434,"context_line":"        self.assertEqual([], self.foreign_exporter.get_finished_spans())"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_middleware_does_not_replace_global_provider(self):"},{"line_number":437,"context_line":"        self._request()"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        self.set_global.assert_not_called()"},{"line_number":440,"context_line":"        self.assertIs(self.foreign, self.trace.get_tracer_provider())"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def test_spans_from_other_providers_join_the_same_trace(self):"},{"line_number":443,"context_line":"        traceparent \u003d \u002700-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01\u0027"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"04df79c8_204123b8","line":441,"range":{"start_line":427,"start_character":0,"end_line":441,"end_character":1},"updated":"2026-10-06 10:10:54.000000000","message":"Does it make sense to join these? They seem to be testing two side of the same thing.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"53d77e1af559532668da0a36c05095c536ffa29a","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        tracing._TRACER_PROVIDER.force_flush()"},{"line_number":425,"context_line":"        return response"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_api_span_uses_middleware_provider_not_global(self):"},{"line_number":428,"context_line":"        self._request()"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        (span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":431,"context_line":"        self.assertEqual(\u0027HTTP GET /servers/detail\u0027, span.name)"},{"line_number":432,"context_line":"        self.assertEqual(\u0027nova-api\u0027, span.resource.attributes[\u0027service.name\u0027])"},{"line_number":433,"context_line":"        # The foreign global provider must not receive the API span."},{"line_number":434,"context_line":"        self.assertEqual([], self.foreign_exporter.get_finished_spans())"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_middleware_does_not_replace_global_provider(self):"},{"line_number":437,"context_line":"        self._request()"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        self.set_global.assert_not_called()"},{"line_number":440,"context_line":"        self.assertIs(self.foreign, self.trace.get_tracer_provider())"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def test_spans_from_other_providers_join_the_same_trace(self):"},{"line_number":443,"context_line":"        traceparent \u003d \u002700-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01\u0027"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7d2150d9_8dffe360","line":441,"range":{"start_line":427,"start_character":0,"end_line":441,"end_character":1},"in_reply_to":"04df79c8_204123b8","updated":"2026-10-06 13:07:03.000000000","message":"Yeah, i was attempting to keep the tests as atomic as possible, but you are correct in that they are actually testing the same, so it makes sense to combine them.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            return \u0027Hello\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":457,"context_line":"        self.foreign.force_flush()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":460,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"}],"source_content_type":"text/x-python","patch_set":3,"id":"babf8344_002c9356","line":457,"updated":"2026-10-06 10:10:54.000000000","message":"Do you want to assert `set_global` was called?","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"53d77e1af559532668da0a36c05095c536ffa29a","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            return \u0027Hello\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":457,"context_line":"        self.foreign.force_flush()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":460,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0fba4b1_acbb45de","line":457,"in_reply_to":"babf8344_002c9356","updated":"2026-10-06 13:07:03.000000000","message":"no, that is already asserted in the new combined test_coexists_with_foreign_global_provider, no need to duplicate it here while we are testing something else.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            return \u0027Hello\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":457,"context_line":"        self.foreign.force_flush()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":460,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"},{"line_number":461,"context_line":"        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)"},{"line_number":462,"context_line":"        # The API span continues the incoming trace, and the span from the"},{"line_number":463,"context_line":"        # other provider parents off the API span in that same trace."},{"line_number":464,"context_line":"        self.assertEqual(trace_id, api_span.context.trace_id)"},{"line_number":465,"context_line":"        self.assertEqual(trace_id, rpc_span.context.trace_id)"},{"line_number":466,"context_line":"        self.assertEqual(api_span.context.span_id, rpc_span.parent.span_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"class TestTracingIntegration(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9786a466_336ca074","line":466,"range":{"start_line":457,"start_character":34,"end_line":466,"end_character":75},"updated":"2026-10-06 10:10:54.000000000","message":"just to help us visually diff the two tests\n\n```suggestion\n        self.foreign.force_flush()\n\n        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)\n\n        self.assertEqual(1, len(self.api_exporter.get_finished_spans()))\n        (api_span,) \u003d self.api_exporter.get_finished_spans()\n        self.assertEqual(trace_id, api_span.context.trace_id)\n\n        self.assertEqual(1, len(self.api_exporter.get_finished_spans()))\n        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()\n        self.assertEqual(trace_id, rpc_span.context.trace_id)\n\n        # The API span continues the incoming trace, and the span from the\n        # other provider parents off the API span in that same trace.\n        self.assertEqual(api_span.context.span_id, rpc_span.parent.span_id)\n```","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"b110766a13e777130bf3655f109b4b40623a84e1","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            return \u0027Hello\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":457,"context_line":"        self.foreign.force_flush()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":460,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"},{"line_number":461,"context_line":"        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)"},{"line_number":462,"context_line":"        # The API span continues the incoming trace, and the span from the"},{"line_number":463,"context_line":"        # other provider parents off the API span in that same trace."},{"line_number":464,"context_line":"        self.assertEqual(trace_id, api_span.context.trace_id)"},{"line_number":465,"context_line":"        self.assertEqual(trace_id, rpc_span.context.trace_id)"},{"line_number":466,"context_line":"        self.assertEqual(api_span.context.span_id, rpc_span.parent.span_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"class TestTracingIntegration(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"994934bd_7675009d","line":466,"range":{"start_line":457,"start_character":34,"end_line":466,"end_character":75},"in_reply_to":"288d1762_2403930d","updated":"2026-10-06 12:49:35.000000000","message":"Both assertEquals end up being the same, but the second should refer to foreign_exporter.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"e5803b9f6f5bd158a47ac40d4f4ae6a47f9a7043","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            return \u0027Hello\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":457,"context_line":"        self.foreign.force_flush()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":460,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"},{"line_number":461,"context_line":"        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)"},{"line_number":462,"context_line":"        # The API span continues the incoming trace, and the span from the"},{"line_number":463,"context_line":"        # other provider parents off the API span in that same trace."},{"line_number":464,"context_line":"        self.assertEqual(trace_id, api_span.context.trace_id)"},{"line_number":465,"context_line":"        self.assertEqual(trace_id, rpc_span.context.trace_id)"},{"line_number":466,"context_line":"        self.assertEqual(api_span.context.span_id, rpc_span.parent.span_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"class TestTracingIntegration(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"288d1762_2403930d","line":466,"range":{"start_line":457,"start_character":34,"end_line":466,"end_character":75},"in_reply_to":"9786a466_336ca074","updated":"2026-10-06 12:36:05.000000000","message":"Fix applied.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4faeb6eb4ffef08cf1aed997b85968e0ecbfda10","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        from opentelemetry.sdk.trace import TracerProvider"},{"line_number":364,"context_line":"        from opentelemetry import trace"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.trace \u003d trace"},{"line_number":367,"context_line":"        self.patch(tracing, \u0027_INITIALIZED\u0027, False)"},{"line_number":368,"context_line":"        self.patch(tracing, \u0027_TRACER_PROVIDER\u0027, None)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        # Stand in for the provider OSProfiler installs as the process"},{"line_number":371,"context_line":"        # global, with its own resource and exporter."}],"source_content_type":"text/x-python","patch_set":6,"id":"044113b8_216d8f37","line":368,"range":{"start_line":366,"start_character":26,"end_line":368,"end_character":53},"updated":"2026-10-08 14:36:34.000000000","message":"(nit) it\u0027d make sense to use these in L51,52 too. can be done separately.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6ac4897c607a453a2964b7dcaf5b77041ea72817","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        from opentelemetry.sdk.trace import TracerProvider"},{"line_number":364,"context_line":"        from opentelemetry import trace"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        self.trace \u003d trace"},{"line_number":367,"context_line":"        self.patch(tracing, \u0027_INITIALIZED\u0027, False)"},{"line_number":368,"context_line":"        self.patch(tracing, \u0027_TRACER_PROVIDER\u0027, None)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        # Stand in for the provider OSProfiler installs as the process"},{"line_number":371,"context_line":"        # global, with its own resource and exporter."}],"source_content_type":"text/x-python","patch_set":6,"id":"10f74936_5061aea4","line":368,"range":{"start_line":366,"start_character":26,"end_line":368,"end_character":53},"in_reply_to":"044113b8_216d8f37","updated":"2026-10-09 08:51:39.000000000","message":"Done, and applied it to the other setUp methods: TestTracingMiddleware, TestInitTracing and TestTracingIntegration","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4faeb6eb4ffef08cf1aed997b85968e0ecbfda10","unresolved":true,"context_lines":[{"line_number":435,"context_line":"        self.set_global.assert_not_called()"},{"line_number":436,"context_line":"        self.assertIs(self.foreign, self.trace.get_tracer_provider())"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_spans_from_other_providers_join_the_same_trace(self):"},{"line_number":439,"context_line":"        traceparent \u003d \u002700-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01\u0027"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        @webob.dec.wsgify"}],"source_content_type":"text/x-python","patch_set":6,"id":"e67ec73e_3efab3b4","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":59},"updated":"2026-10-08 14:36:34.000000000","message":"Question\nWhile I understand how it works here, I\u0027m still unsure if this is the desired behavior ? This test indicates tracing middleware may affect the information captured by osprofiler. Although I assume it may be useful to have the traceparent/state to associate profiler data between these two, and these key may not conflict with any existing implementations in osprofiler, I\u0027d like to make sure it has been your intention.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"79db73df6d51ef29aa727f18f91e7d58f499d929","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        self.set_global.assert_not_called()"},{"line_number":436,"context_line":"        self.assertIs(self.foreign, self.trace.get_tracer_provider())"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_spans_from_other_providers_join_the_same_trace(self):"},{"line_number":439,"context_line":"        traceparent \u003d \u002700-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01\u0027"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        @webob.dec.wsgify"}],"source_content_type":"text/x-python","patch_set":6,"id":"19aa69f2_569fd477","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":59},"in_reply_to":"083c1ccd_8db48ab8","updated":"2026-10-09 14:37:00.000000000","message":"Done","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6243a119bf31ae98f9cff2fe3a1eacf3dcbdd9d5","unresolved":true,"context_lines":[{"line_number":435,"context_line":"        self.set_global.assert_not_called()"},{"line_number":436,"context_line":"        self.assertIs(self.foreign, self.trace.get_tracer_provider())"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_spans_from_other_providers_join_the_same_trace(self):"},{"line_number":439,"context_line":"        traceparent \u003d \u002700-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01\u0027"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        @webob.dec.wsgify"}],"source_content_type":"text/x-python","patch_set":6,"id":"083c1ccd_8db48ab8","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":59},"in_reply_to":"e67ec73e_3efab3b4","updated":"2026-10-09 08:46:10.000000000","message":"I understand the concern, specially because I made a mistake on the comment in lines 443-444, where I say that \"as oslo.messaging or OSProfiler would\", but looking into osprofiler code, this does not happen.\n\nEvery OSProfiler span builds its parent explicitly from OSProfiler\u0027s own payload IDs and passes it as an explicit context. That means that OSProfiler never reads the ambient OTel context that our middleware attaches and tracing does not affect the information captured by osprofiler.\n\nIll change the misleading comment and fix the other small requests, as they are small and easy enough to fit in this same change, no subsequent one.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4faeb6eb4ffef08cf1aed997b85968e0ecbfda10","unresolved":true,"context_lines":[{"line_number":450,"context_line":"            return \u0027Hello\u0027"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":453,"context_line":"        self.foreign.force_flush()"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cb3557c1_d5d5a5ee","line":453,"range":{"start_line":453,"start_character":8,"end_line":453,"end_character":34},"updated":"2026-10-08 14:36:34.000000000","message":"Maybe we don\u0027t need this here because this is effectively noop in SingleSpanProcessor. Remove it or add the same to L428 (and probably to internal providers of tracing middleware if we do that?) for consistency.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6ac4897c607a453a2964b7dcaf5b77041ea72817","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            return \u0027Hello\u0027"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self._request(app\u003dapp, traceparent\u003dtraceparent)"},{"line_number":453,"context_line":"        self.foreign.force_flush()"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        trace_id \u003d int(traceparent.split(\u0027-\u0027)[1], 16)"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"53861015_bcdb69dc","line":453,"range":{"start_line":453,"start_character":8,"end_line":453,"end_character":34},"in_reply_to":"cb3557c1_d5d5a5ee","updated":"2026-10-09 08:51:39.000000000","message":"Done","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4faeb6eb4ffef08cf1aed997b85968e0ecbfda10","unresolved":true,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        self.assertEqual(1, len(self.api_exporter.get_finished_spans()))"},{"line_number":458,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":459,"context_line":"        self.assertEqual(trace_id, api_span.context.trace_id)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        self.assertEqual(1, len(self.foreign_exporter.get_finished_spans()))"},{"line_number":462,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"}],"source_content_type":"text/x-python","patch_set":6,"id":"861b5039_913ea065","line":459,"updated":"2026-10-08 14:36:34.000000000","message":"Can we assert span.name and span.resource.attributes[\u0027service_name\u0027] here to make sure one do not interfere with the other ? Asserting that here allows us to verify both directions (global -\u003e local, local -\u003e global)","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"6ac4897c607a453a2964b7dcaf5b77041ea72817","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        self.assertEqual(1, len(self.api_exporter.get_finished_spans()))"},{"line_number":458,"context_line":"        (api_span,) \u003d self.api_exporter.get_finished_spans()"},{"line_number":459,"context_line":"        self.assertEqual(trace_id, api_span.context.trace_id)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        self.assertEqual(1, len(self.foreign_exporter.get_finished_spans()))"},{"line_number":462,"context_line":"        (rpc_span,) \u003d self.foreign_exporter.get_finished_spans()"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8c5e395_a77a4662","line":459,"in_reply_to":"861b5039_913ea065","updated":"2026-10-09 08:51:39.000000000","message":"Sure we can. I added assertions on both name and service.name for the API span and the other provider span so we verify both directions: they share a trace but keep separate Resource identity.","commit_id":"dfe8331d61d59bb0098ce67eeb959d01fe893857"}],"oslo_middleware/tracing.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":true,"context_lines":[{"line_number":211,"context_line":"    _TRACER_PROVIDER \u003d otel_sdk_trace.TracerProvider("},{"line_number":212,"context_line":"        resource\u003dresource,"},{"line_number":213,"context_line":"        sampler\u003dsampler,"},{"line_number":214,"context_line":"        shutdown_on_exit\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":"    _TRACER_PROVIDER.add_span_processor("},{"line_number":217,"context_line":"        otel_export.BatchSpanProcessor(exporter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"53839b63_8395db06","line":214,"updated":"2026-10-05 15:09:24.000000000","message":"Can you add a comment on this explaining why we want this? I assume it\u0027s because we are managing lifecycle automatically?","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ab019f1a09865f099328b93d249cbed37b9a4365","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    _TRACER_PROVIDER \u003d otel_sdk_trace.TracerProvider("},{"line_number":212,"context_line":"        resource\u003dresource,"},{"line_number":213,"context_line":"        sampler\u003dsampler,"},{"line_number":214,"context_line":"        shutdown_on_exit\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":"    _TRACER_PROVIDER.add_span_processor("},{"line_number":217,"context_line":"        otel_export.BatchSpanProcessor(exporter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b07cca9_4ed10bec","line":214,"in_reply_to":"3126f56d_ad7776dc","updated":"2026-10-06 17:29:36.000000000","message":"Done","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":211,"context_line":"    _TRACER_PROVIDER \u003d otel_sdk_trace.TracerProvider("},{"line_number":212,"context_line":"        resource\u003dresource,"},{"line_number":213,"context_line":"        sampler\u003dsampler,"},{"line_number":214,"context_line":"        shutdown_on_exit\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":"    _TRACER_PROVIDER.add_span_processor("},{"line_number":217,"context_line":"        otel_export.BatchSpanProcessor(exporter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3126f56d_ad7776dc","line":214,"in_reply_to":"4083a352_397e549f","updated":"2026-10-06 10:10:54.000000000","message":"Thanks for the additional context. Could we get a small comment also here explaining why we don\u0027t want to shut this down?","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"0a220b89a6ab2f3757577fa19f53721c595e154d","unresolved":true,"context_lines":[{"line_number":211,"context_line":"    _TRACER_PROVIDER \u003d otel_sdk_trace.TracerProvider("},{"line_number":212,"context_line":"        resource\u003dresource,"},{"line_number":213,"context_line":"        sampler\u003dsampler,"},{"line_number":214,"context_line":"        shutdown_on_exit\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":"    _TRACER_PROVIDER.add_span_processor("},{"line_number":217,"context_line":"        otel_export.BatchSpanProcessor(exporter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e274ea43_89706b13","line":214,"in_reply_to":"53839b63_8395db06","updated":"2026-10-05 15:27:34.000000000","message":"This is a good question and it did not end up being clear at all anywhere. \n\nThe issue is that osprofiler registers the global tracing provider because it is able to send opentelemetry traces to a backend. What it happens now is that if osprofiler and tracing middlewares are enabled at the same time (in Nova at least, which is now my main testing driver), the tracing spans get whatever osprofiler as configured as service.name in the global otel tracing provider.\n\nThis is never rewritten, and that causes that if osprofiler is enabled in Nova, traces generated by the tracing middleware for nova-api would get osprofiler service name (openstack-nova-osapi_compute) instead of what I configured for it to look like (nova-api).\n\nThe solution I came with was using a local provider (_TRACER_PROVIDER) that we can configure with the correct values, and use that accross the tracing middleware. That way we decouple osprofiler and tracing spans.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"56876c6767b9918a40fcb29e2adc9f9974cda8fc","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    _TRACER_PROVIDER \u003d otel_sdk_trace.TracerProvider("},{"line_number":212,"context_line":"        resource\u003dresource,"},{"line_number":213,"context_line":"        sampler\u003dsampler,"},{"line_number":214,"context_line":"        shutdown_on_exit\u003dFalse,"},{"line_number":215,"context_line":"    )"},{"line_number":216,"context_line":"    _TRACER_PROVIDER.add_span_processor("},{"line_number":217,"context_line":"        otel_export.BatchSpanProcessor(exporter)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4083a352_397e549f","line":214,"in_reply_to":"e274ea43_89706b13","updated":"2026-10-06 09:05:11.000000000","message":"I have rewritten the commit message to try to be much more simpler and explicative. I hope that it now gives the appropiate context.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d77207450f4db742c13e097d40bc3a0a1fb8369","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        init_tracing(self.oslo_conf)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # init_tracing() always sets the provider when tracing is enabled."},{"line_number":343,"context_line":"        provider \u003d ty.cast(\u0027otel_sdk_trace.TracerProvider\u0027, _TRACER_PROVIDER)"},{"line_number":344,"context_line":"        self._tracer \u003d provider.get_tracer(\u0027oslo_middleware.tracing\u0027)"},{"line_number":345,"context_line":"        self._propagator \u003d otel_propagate.get_global_textmap()"},{"line_number":346,"context_line":"        self._tracing_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c2b2b29_38bf4a79","line":343,"updated":"2026-10-06 10:10:54.000000000","message":"You\u0027ll need to drop `ty.` due to I29818b965efaca4e2d87d817c47091dc202d7a20. However, I think it would be better to just add a check here:\n\n```suggestion\n        provider \u003d _TRACER_PROVIDER\n        # init_tracing() always sets the provider when tracing is enabled\n        if provider is None:\n            raise RuntimeError(\u0027provider not initialized\u0027)\n```\n\nThat will narrow types *and* ensure we correctly die if someone screws up","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"e5803b9f6f5bd158a47ac40d4f4ae6a47f9a7043","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        init_tracing(self.oslo_conf)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        # init_tracing() always sets the provider when tracing is enabled."},{"line_number":343,"context_line":"        provider \u003d ty.cast(\u0027otel_sdk_trace.TracerProvider\u0027, _TRACER_PROVIDER)"},{"line_number":344,"context_line":"        self._tracer \u003d provider.get_tracer(\u0027oslo_middleware.tracing\u0027)"},{"line_number":345,"context_line":"        self._propagator \u003d otel_propagate.get_global_textmap()"},{"line_number":346,"context_line":"        self._tracing_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"e68155f2_5166ae9a","line":343,"in_reply_to":"4c2b2b29_38bf4a79","updated":"2026-10-06 12:36:05.000000000","message":"Oh this was brand new, thanks for highlighting.","commit_id":"67faf0fabb83a83270a66f0fcd49c4eda55940ac"}],"releasenotes/notes/fix-tracing-service-name-provider-ownership.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bf8e55ef5e3c0873568482391425ab1c567973f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API spans created by TracingMiddleware now use the configured"},{"line_number":5,"context_line":"    ``[oslo_middleware_tracing] service_name``, exporter, and sampling rate"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4814ae76_861a45dc","line":2,"updated":"2026-10-05 15:09:24.000000000","message":"If you\u0027re using `fixes`, you probably want a bug report since we are presumably going to backport this.","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"56876c6767b9918a40fcb29e2adc9f9974cda8fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API spans created by TracingMiddleware now use the configured"},{"line_number":5,"context_line":"    ``[oslo_middleware_tracing] service_name``, exporter, and sampling rate"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1b5e29eb_d72a8563","line":2,"in_reply_to":"4814ae76_861a45dc","updated":"2026-10-06 09:05:11.000000000","message":"Added a bug report: https://bugs.launchpad.net/oslo.middleware/+bug/2169684. Also added a \"Closes-Bug\" to the commit message","commit_id":"6a30ad304ba3994982e48fe5efbcf1473e277413"}]}
