)]}'
{"id":"openstack%2Foslo.middleware~174025","triplet_id":"openstack%2Foslo.middleware~master~I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c","project":"openstack/oslo.middleware","branch":"master","topic":"bug/1444490","hashtags":[],"change_id":"I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c","subject":"Add middleware to support ssl termination proxies","status":"MERGED","created":"2015-04-15 18:50:09.000000000","updated":"2015-06-12 11:34:27.000000000","submitted":"2015-06-11 03:08:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fcf5b3cf6ac8dd725168a9783e8a3582a9ff6c7c","_number":174025,"virtual_id_number":174025,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-06-11 03:08:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"date":"2015-06-11 20:43:27.000000000","post_submit":true,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"date":"2015-06-11 09:04:36.000000000","post_submit":true,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-06-11 02:09:16.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":2,"date":"2015-06-10 22:19:50.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2015-06-11 02:09:16.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-04 18:36:23.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-05-08 14:36:09.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2015-06-03 01:38:16.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2015-06-10 22:19:50.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2015-06-11 02:09:16.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2015-06-11 03:08:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-06-11 09:04:36.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"}],"messages":[{"id":"469980b838abc6f829bfcb3ab387c8226ad9bddb","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-15 18:50:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c94cc6416d79ac4479ee55fcff152b8b1f474457","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 21:47:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/1/check/gate-oslo.middleware-python26/479e40a/ : SUCCESS in 51s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/1/check/gate-oslo.middleware-pep8/0ad4c9b/ : FAILURE in 36s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/1/check/gate-oslo.middleware-docs/6cc0e56//doc/build/html/ : SUCCESS in 35s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/1/check/gate-oslo.middleware-python27/a10cd02/ : SUCCESS in 39s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/1/check/gate-oslo.middleware-python34/bad5a73/ : SUCCESS in 1m 42s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/1/check/gate-oslo.middleware-pypy/41eeb22/ : SUCCESS in 1m 06s\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/1/check/gate-tempest-dsvm-neutron-src-oslo.middleware/f1f5908/ : SUCCESS in 54m 14s","accounts_in_message":[],"_revision_number":1},{"id":"3b7268d8ee4689aba94d28d04d527c15e348c8a0","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-16 07:10:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"58538179554907b2b1007a1e29b59c418fa32e18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-16 08:05:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/2/check/gate-oslo.middleware-python26/533f631/ : SUCCESS in 47s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/2/check/gate-oslo.middleware-pep8/349b8e8/ : SUCCESS in 38s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/2/check/gate-oslo.middleware-docs/8c9f7c0//doc/build/html/ : SUCCESS in 43s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/2/check/gate-oslo.middleware-python27/d353763/ : SUCCESS in 47s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/2/check/gate-oslo.middleware-python34/79d5132/ : SUCCESS in 2m 17s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/2/check/gate-oslo.middleware-pypy/94fe50d/ : SUCCESS in 1m 23s\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/2/check/gate-tempest-dsvm-neutron-src-oslo.middleware/1bcad53/ : SUCCESS in 49m 27s","accounts_in_message":[],"_revision_number":2},{"id":"5aea02e9b7ced25de9ce020c77d8b261d8b0bed3","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2015-05-04 15:34:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(4 comments)\n\nwe need to add an entry here as well:\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/__init__.py","accounts_in_message":[],"_revision_number":2},{"id":"21cc3d73fda8ab6566b547830ec0da075c2ea393","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-04 15:57:28.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cb58aee26d225632ecd28ff31c8fa82f7f02b1ac","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-04 15:57:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8a683338e34bba1f3d75251bbe9b8ebe90423df0","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-04 18:27:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e30fe90515904d718c5d84416469ba0ba5c9cbd4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-04 19:55:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/3/check/gate-oslo.middleware-python26/64c82ea/ : SUCCESS in 42s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/3/check/gate-oslo.middleware-pep8/025bef2/ : SUCCESS in 37s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/3/check/gate-oslo.middleware-docs/e8dfc27//doc/build/html/ : SUCCESS in 44s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/3/check/gate-oslo.middleware-python27/0904b9e/ : SUCCESS in 44s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/3/check/gate-oslo.middleware-python34/19798fc/ : SUCCESS in 2m 17s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/3/check/gate-oslo.middleware-pypy/0acea2e/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/3/check/gate-tempest-dsvm-neutron-src-oslo.middleware/823506b/ : SUCCESS in 1h 08m 11s","accounts_in_message":[],"_revision_number":3},{"id":"159e1a7b56168ab4f162727bd320c7e085491d1b","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2015-05-07 22:06:26.000000000","message":"Patch Set 3: Code-Review-1\n\nminor issue but could you add entry here to be consistent: https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/__init__.py","accounts_in_message":[],"_revision_number":3},{"id":"8f34fb971aeb94ef267c7250f4c3f14e67ec9be1","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-07 22:12:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"30c1be244d1d014b9fec2a84cd9fcfead184e6bf","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-07 22:13:40.000000000","message":"Patch Set 4:\n\n@gordon: done","accounts_in_message":[],"_revision_number":4},{"id":"47d841f9c0ffdd01e77d988be4ab863638b141e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-07 23:10:55.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/4/check/gate-oslo.middleware-python26/12fa06c/ : SUCCESS in 34s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/4/check/gate-oslo.middleware-pep8/0b7d052/ : SUCCESS in 33s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/4/check/gate-oslo.middleware-docs/5925081//doc/build/html/ : SUCCESS in 46s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/4/check/gate-oslo.middleware-python27/cf96f71/ : SUCCESS in 44s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/4/check/gate-oslo.middleware-python34/86e0d49/ : SUCCESS in 56s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/4/check/gate-oslo.middleware-pypy/5e214f1/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/4/check/gate-tempest-dsvm-neutron-src-oslo.middleware/dd90465/ : SUCCESS in 57m 42s","accounts_in_message":[],"_revision_number":4},{"id":"e6686a55df056f47c03d96cd57f2cda8ea3f215a","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2015-05-08 14:36:09.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)\n\nthanks!","accounts_in_message":[],"_revision_number":4},{"id":"839edccb091a22424889e1ca4b268d17fc5865a5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-05-11 12:49:02.000000000","message":"Patch Set 4: Code-Review-1\n\ngordc redirected me here from https://review.openstack.org/#/c/180929/\n\nWhere I said:\n\n-\u003d-\u003d-\nI don\u0027t think this is the best way to solve this problem. It is insufficiently generic, overly complex and quite brittle. Better to have the version url set from config. This way the service can behind a variety of proxies, load balancers, miscellaneous systems of all sorts, and always know it publishes the right URL because it has been made explicit.\n\nSee the glance fix: https://review.openstack.org/#/c/130311/\n-\u003d-\u003d-\n\nGenerally speaking a modern web app needs to know its base_url from configuration because the path by which a request gets to a WSGI can be tortured and involve not just changes in the url scheme but also the host, port and base path. Consider, for example, someone who wants to front all the various service endpoints under a single host and port and use path redirection to land at the right wsgi app?\n\nIt\u0027s easier to just declare that the tool which is going to cook a visible, external, fully-qualified URL looks up the base in config (and that config receives a reasonable default).","accounts_in_message":[],"_revision_number":4},{"id":"d5dfbad2d19d52ae560681d768e3bbcbf8d9ce29","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-05-11 19:32:08.000000000","message":"Patch Set 4:\n\n@Chris: host and port? They are provided by clients in Host header[1] and is mandatory in http/1.1:\n\n  curl http://localhost:8000 -v\n * Rebuilt URL to: http://localhost:8000/\n * Connected to localhost (127.0.0.1) port 8000 (#0)\n \u003e GET / HTTP/1.1\n \u003e User-Agent: curl/7.35.0\n \u003e Host: localhost:8000\n \u003e Accept: */*\n\nCommon proxies can forward client provided Host header.\n\nwebob supportsHost header and supports base-url in Host header through the pattern: \n\n  $host[:$port][/$base-url]\n\n\n[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html","accounts_in_message":[],"_revision_number":4},{"id":"5b6d97404f6010db11910c6e6b6df94fe4d36aa1","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-03 01:38:16.000000000","message":"Patch Set 4:\n\n@Cedric, some folk still issue HTTP/0.9 requests: yes 1.0,1.1 and 2 all added more things, but unless we state \u0027will only work with X\u0027, we can\u0027t guarantee they are there. \n\nSecondly, and more importantly, I agree with Chris - this really is something that should be set in the application, because any absolute URLs generated by the app (like Ironic does) need to be correct - and we don\u0027t want the middleware to have to sniff-and-rewrite the body of the response.\n\nThat said, if this is already in use elsewhere, I am fine with it being added, but it should come with warnings and explanations on what better approaches exist.","accounts_in_message":[],"_revision_number":4},{"id":"5d96dd999397bc8fdebcabd5fc9147686e1e53af","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-03 01:44:07.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nThere\u0027s one actual code issue today, see inline.\n\nA further note on the basic approach though - while a config setting does preclude running one instance on many locations at once, this is actually very rare, and entirely unneeded for stateless services : you can just run another instance of the stateless server configured for the Nth location you want it visible at.\n\nThere is a hypothetical case where the number of locations is high and the load per-location low, but AFAIK none of the OpenStack services match this scenario today, nor are any planned that would.","accounts_in_message":[],"_revision_number":4},{"id":"720d364e3ff49ae9fc92ffc960d78581b6476c32","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-06-09 11:49:43.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5963dbd72677e9c3af40d51d97b51800525ac8a8","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-06-09 11:49:54.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nSorry for the late response","accounts_in_message":[],"_revision_number":4},{"id":"01f2cd91949628cab2b08d76395ba4bd3c32eb61","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-09 12:52:57.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/5/check/gate-oslo.middleware-python26/42684e6/ : SUCCESS in 40s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/5/check/gate-oslo.middleware-pep8/f57f295/ : SUCCESS in 36s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/5/check/gate-oslo.middleware-docs/0a3b285//doc/build/html/ : SUCCESS in 46s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/5/check/gate-oslo.middleware-python27/1781552/ : SUCCESS in 57s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/5/check/gate-oslo.middleware-python34/9449b93/ : SUCCESS in 52s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/5/check/gate-oslo.middleware-pypy/5772efa/ : SUCCESS in 1m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/5/check/gate-tempest-dsvm-neutron-src-oslo.middleware/ac6b62e/ : SUCCESS in 54m 59s","accounts_in_message":[],"_revision_number":5},{"id":"381d0dc41e9e17397a8f45edddef0484fc360bf2","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2015-06-10 22:19:50.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"03c3d8068c8ef92752d9e3e048c41334e454789f","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2015-06-11 02:09:16.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"fdd335fade899bc3e9115a601785a07126142296","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 02:09:22.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"fd5122ae6611465bed13c7122548dfd72c11cfe4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 03:08:38.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-oslo.middleware-python26 http://logs.openstack.org/25/174025/5/gate/gate-oslo.middleware-python26/efb6071/ : SUCCESS in 47s\n- gate-oslo.middleware-docs http://docs-draft.openstack.org/25/174025/5/gate/gate-oslo.middleware-docs/cf834e1//doc/build/html/ : SUCCESS in 42s\n- gate-oslo.middleware-pep8 http://logs.openstack.org/25/174025/5/gate/gate-oslo.middleware-pep8/60301b2/ : SUCCESS in 38s\n- gate-oslo.middleware-python27 http://logs.openstack.org/25/174025/5/gate/gate-oslo.middleware-python27/f4f41e5/ : SUCCESS in 44s\n- gate-oslo.middleware-python34 http://logs.openstack.org/25/174025/5/gate/gate-oslo.middleware-python34/4f35cd0/ : SUCCESS in 1m 03s\n- gate-oslo.middleware-pypy http://logs.openstack.org/25/174025/5/gate/gate-oslo.middleware-pypy/680ab87/ : SUCCESS in 1m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-oslo.middleware http://logs.openstack.org/25/174025/5/gate/gate-tempest-dsvm-neutron-src-oslo.middleware/eb61b45/ : SUCCESS in 58m 06s","accounts_in_message":[],"_revision_number":5},{"id":"aabb56af1200da6cac3926032851ed28282d14a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 03:08:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5},{"id":"2588e43c265decca2c1e941d73e15139e79c3815","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-06-11 09:04:36.000000000","message":"Patch Set 5:\n\nIs there going to be documentation/guidance on when it is appropriate to use this?\n\nBecause without that I think it can easily screw people up if they are doing interesting proxying and/or application hosting.","accounts_in_message":[],"_revision_number":5},{"id":"98aaefab2e16fb90e6eabe450f5ab20a27600070","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-06-11 20:43:27.000000000","message":"Patch Set 5:\n\n@Chris: Do you have something special in mind?","accounts_in_message":[],"_revision_number":5},{"id":"658236038d636634a0e770baa4bbf1cf7c0c04b4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-06-12 11:34:27.000000000","message":"Patch Set 5:\n\n\u003e Do you have something special in mind?\n\nNothing in particular, just that any feature like this seems like it ought to document when and where it should be used and any caveats that people should be aware of. Both lifeless and I have expressed some concerns in the comments about corner cases.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"6b4e821e14af7ed2362b02f2b42e9a8a5bc49672","revisions":{"4a1a094397ac73532a29b4c369f4bf1352471395":{"kind":"REWORK","_number":1,"created":"2015-04-15 18:50:09.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/25/174025/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.middleware","ref":"refs/changes/25/174025/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/1"}}},"commit":{"parents":[{"commit":"027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7","subject":"Add CORS Middleware for Oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:44:32.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:50:06.000000000","tz":120},"subject":"Add middleware to support ssl termination proxies","message":"Add middleware to support ssl termination proxies\n\nThis change defines SSLMiddleware middleware which enables OpenStack\nservices behind SSL termination proxies to return urls with original\nprotocol scheme.\n\nSSLMiddleware is based on heat SSLMiddleware class.\n\nChange-Id: I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c\nCloses-Bug: #1444490\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/4a1a094397ac73532a29b4c369f4bf1352471395"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/4a1a094397ac73532a29b4c369f4bf1352471395"}]},"branch":"refs/heads/master"},"8fbd1a8cd2eb2b915653a74011603ca515fadc1d":{"kind":"REWORK","_number":2,"created":"2015-04-16 07:10:50.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/25/174025/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.middleware","ref":"refs/changes/25/174025/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/2"}}},"commit":{"parents":[{"commit":"027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7","subject":"Add CORS Middleware for Oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:44:32.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-16 07:10:38.000000000","tz":120},"subject":"Add middleware to support ssl termination proxies","message":"Add middleware to support ssl termination proxies\n\nThis change defines SSLMiddleware middleware which enables OpenStack\nservices behind SSL termination proxies to return urls with original\nprotocol scheme.\n\nSSLMiddleware is based on heat SSLMiddleware class.\n\nChange-Id: I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c\nCloses-Bug: #1444490\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/8fbd1a8cd2eb2b915653a74011603ca515fadc1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/8fbd1a8cd2eb2b915653a74011603ca515fadc1d"}]},"branch":"refs/heads/master"},"ebde851a7b4ce97a61652e8b817f1dc1d48cdde7":{"kind":"REWORK","_number":3,"created":"2015-05-04 18:27:52.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/25/174025/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.middleware","ref":"refs/changes/25/174025/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/3"}}},"commit":{"parents":[{"commit":"027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7","subject":"Add CORS Middleware for Oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:44:32.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-05-04 18:27:48.000000000","tz":120},"subject":"Add middleware to support ssl termination proxies","message":"Add middleware to support ssl termination proxies\n\nThis change defines SSLMiddleware middleware which enables OpenStack\nservices behind SSL termination proxies to return urls with original\nprotocol scheme.\n\nSSLMiddleware is based on heat SSLMiddleware class.\n\nChange-Id: I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c\nCloses-Bug: #1444490\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/ebde851a7b4ce97a61652e8b817f1dc1d48cdde7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/ebde851a7b4ce97a61652e8b817f1dc1d48cdde7"}]},"branch":"refs/heads/master"},"f1b5c8f15e9d5996b52fded5b795f32ad5d7bb5a":{"kind":"REWORK","_number":4,"created":"2015-05-07 22:12:58.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/25/174025/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.middleware","ref":"refs/changes/25/174025/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/4"}}},"commit":{"parents":[{"commit":"027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7","subject":"Add CORS Middleware for Oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:44:32.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-05-07 22:12:45.000000000","tz":120},"subject":"Add middleware to support ssl termination proxies","message":"Add middleware to support ssl termination proxies\n\nThis change defines SSLMiddleware middleware which enables OpenStack\nservices behind SSL termination proxies to return urls with original\nprotocol scheme.\n\nSSLMiddleware is based on heat SSLMiddleware class.\n\nChange-Id: I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c\nCloses-Bug: #1444490\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/f1b5c8f15e9d5996b52fded5b795f32ad5d7bb5a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/f1b5c8f15e9d5996b52fded5b795f32ad5d7bb5a"}]},"branch":"refs/heads/master"},"6b4e821e14af7ed2362b02f2b42e9a8a5bc49672":{"kind":"REWORK","_number":5,"created":"2015-06-09 11:49:43.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/25/174025/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.middleware","ref":"refs/changes/25/174025/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.middleware refs/changes/25/174025/5"}}},"commit":{"parents":[{"commit":"027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7","subject":"Add CORS Middleware for Oslo.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/027dd345f3ae6c2bd4fcda5d664e5eb71131bcd7"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 18:44:32.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-06-09 11:49:41.000000000","tz":120},"subject":"Add middleware to support ssl termination proxies","message":"Add middleware to support ssl termination proxies\n\nThis change defines SSLMiddleware middleware which enables OpenStack\nservices behind SSL termination proxies to return urls with original\nprotocol scheme.\n\nSSLMiddleware is based on heat SSLMiddleware class.\n\nChange-Id: I72f8da160ced6ac80fdac743c00ea3f7ffb1f57c\nCloses-Bug: #1444490\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/6b4e821e14af7ed2362b02f2b42e9a8a5bc49672"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.middleware/commit/6b4e821e14af7ed2362b02f2b42e9a8a5bc49672"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}