)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"It can be expanded in the future to provide more information as"},{"line_number":18,"context_line":"desired (possibly showing more useful application level info when"},{"line_number":19,"context_line":"in detailed mode)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c6dae848985d950c3cf6798695c7669eb245ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_1208827f","line":19,"updated":"2015-09-10 23:11:24.000000000","message":"open a bug for the change","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"}],"oslo_middleware/healthcheck/__init__.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    NAMESPACE \u003d \"oslo.middleware.healthcheck\""},{"line_number":85,"context_line":"    SIMPLE_RESPONSE_TEMPLATE \u003d \"\"\""},{"line_number":86,"context_line":"{% for reason in reasons -%}"},{"line_number":87,"context_line":"{% if reason -%}"},{"line_number":88,"context_line":"{{reason}}"},{"line_number":89,"context_line":"{%- endif %}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d2a3ea9c","line":86,"updated":"2015-09-10 23:11:24.000000000","message":"what is  \"-\" for in \"-%}\"? can\u0027t seem to find reference in jinja docs","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e738059d9f0dc314185dce1183a544f4fc361b52","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    NAMESPACE \u003d \"oslo.middleware.healthcheck\""},{"line_number":85,"context_line":"    SIMPLE_RESPONSE_TEMPLATE \u003d \"\"\""},{"line_number":86,"context_line":"{% for reason in reasons -%}"},{"line_number":87,"context_line":"{% if reason -%}"},{"line_number":88,"context_line":"{{reason}}"},{"line_number":89,"context_line":"{%- endif %}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d868e9bc","line":86,"in_reply_to":"da20952f_582619bb","updated":"2015-09-11 00:10:07.000000000","message":"cool :)","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b8e98af64b84190964e0aa6844190a6005db1fb4","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    NAMESPACE \u003d \"oslo.middleware.healthcheck\""},{"line_number":85,"context_line":"    SIMPLE_RESPONSE_TEMPLATE \u003d \"\"\""},{"line_number":86,"context_line":"{% for reason in reasons -%}"},{"line_number":87,"context_line":"{% if reason -%}"},{"line_number":88,"context_line":"{{reason}}"},{"line_number":89,"context_line":"{%- endif %}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_582619bb","line":86,"in_reply_to":"da20952f_d2a3ea9c","updated":"2015-09-11 00:07:23.000000000","message":"http://jinja.pocoo.org/docs/dev/templates/#whitespace-control","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def __init__(self, application, conf):"},{"line_number":119,"context_line":"        super(Healthcheck, self).__init__(application)"},{"line_number":120,"context_line":"        self._path \u003d conf.get(\u0027path\u0027, \u0027/healthcheck\u0027)"},{"line_number":121,"context_line":"        self._show_details \u003d strutils.bool_from_string(conf.get(\"detailed\"))"},{"line_number":122,"context_line":"        self._backend_names \u003d []"},{"line_number":123,"context_line":"        backends \u003d conf.get(\u0027backends\u0027)"},{"line_number":124,"context_line":"        if backends:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_32b106e1","line":121,"updated":"2015-09-10 23:11:24.000000000","message":"nit: use single quote consistently","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _make_simple_response(self, results):"},{"line_number":139,"context_line":"        healthy \u003d self._are_results_healthy(results)"},{"line_number":140,"context_line":"        if not healthy:"},{"line_number":141,"context_line":"            status \u003d webob.exc.HTTPServiceUnavailable.code"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            status \u003d webob.exc.HTTPOk.code"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f2ce2e59","line":140,"updated":"2015-09-10 23:11:24.000000000","message":"suggestion: positive check are easier for readability","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            \u0027results\u0027: translated_results,"},{"line_number":168,"context_line":"        }"},{"line_number":169,"context_line":"        body \u003d _expand_template(self.DETAILED_RESPONSE_TEMPLATE, params)"},{"line_number":170,"context_line":"        if not healthy:"},{"line_number":171,"context_line":"            status \u003d webob.exc.HTTPServiceUnavailable.code"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            status \u003d webob.exc.HTTPOk.code"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_92eed2b3","line":170,"updated":"2015-09-10 23:11:24.000000000","message":"suggestion: use positive check for readbility","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b11ca5e40467a247ee585918654b6be8a5c3a25","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        if req.path !\u003d self._path:"},{"line_number":179,"context_line":"            return None"},{"line_number":180,"context_line":"        results \u003d [ext.obj.healthcheck() for ext in self._backends]"},{"line_number":181,"context_line":"        if not self._show_details:"},{"line_number":182,"context_line":"            status, body, content_type \u003d self._make_simple_response(results)"},{"line_number":183,"context_line":"        else:"},{"line_number":184,"context_line":"            status, body, content_type \u003d self._make_detailed_response(results)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_12316259","line":181,"updated":"2015-09-10 23:11:24.000000000","message":"same comment for positive check","commit_id":"6b4a71bfba0ce94f1f40002d55748b0b368845b3"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f95fb571b2311cde86c0e87d96a5bb267a26b47b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        body \u003d _expand_template(self.SIMPLE_RESPONSE_TEMPLATE, params)"},{"line_number":146,"context_line":"        return (status, body.strip(), \u0027text/plain\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _make_detailed_response(self, results):"},{"line_number":149,"context_line":"        healthy \u003d self._are_results_healthy(results)"},{"line_number":150,"context_line":"        hostname \u003d None"},{"line_number":151,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_26521668","line":148,"updated":"2015-09-11 10:36:05.000000000","message":"I disagree with this here.\n\nThe fact that the result is detailed has no thing to do with the content-type that is returned.\n\nYou should be able to return the details in text/html if the Accept header says so, otherwise it\u0027d be great to be able to return e.g. text/plain or JSON by default.","commit_id":"e7b70301fdadaf6e96f3716b269c74a52eabf194"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f95fb571b2311cde86c0e87d96a5bb267a26b47b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        try:"},{"line_number":152,"context_line":"            hostname \u003d socket.gethostname()"},{"line_number":153,"context_line":"        except socket.error:"},{"line_number":154,"context_line":"            pass"},{"line_number":155,"context_line":"        translated_results \u003d []"},{"line_number":156,"context_line":"        for result in results:"},{"line_number":157,"context_line":"            translated_results.append({"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_86c76211","line":154,"updated":"2015-09-11 10:36:05.000000000","message":"hostname \u003d None\n\nand remove line 150 :)","commit_id":"e7b70301fdadaf6e96f3716b269c74a52eabf194"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6d721aad24981297c803806c5adb0dd7ca61e027","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    from collections import OrderedDict  # noqa"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    # TODO(harlowja): remove this when py2.6 support is dropped..."},{"line_number":23,"context_line":"    from ordereddict import OrderedDict  # noqa"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import jinja2"},{"line_number":26,"context_line":"from oslo_utils import reflection"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_f5a83d22","line":23,"updated":"2015-09-16 21:39:41.000000000","message":"is this targeting Mitaka? were we not dropping py26 support then?","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"691ffe3abcc48ff2560785376e3622e1cdf0349a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    from collections import OrderedDict  # noqa"},{"line_number":21,"context_line":"except ImportError:"},{"line_number":22,"context_line":"    # TODO(harlowja): remove this when py2.6 support is dropped..."},{"line_number":23,"context_line":"    from ordereddict import OrderedDict  # noqa"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import jinja2"},{"line_number":26,"context_line":"from oslo_utils import reflection"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_4b3ce2c7","line":23,"in_reply_to":"ba15a1d1_f5a83d22","updated":"2015-09-17 04:09:55.000000000","message":"Oh, perhaps; this is just going on what currently exists:\n\nhttps://github.com/openstack/oslo.middleware/blob/master/setup.cfg#L9 listed it, so therefore I did this..","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8ae3f83cb547699315dd2863a0b63e70ab2cbb05","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from oslo_middleware import base"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _pretty_json_dumps(contents):"},{"line_number":38,"context_line":"    return json.dumps(contents, indent\u003d4, sort_keys\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_726858bb","line":37,"updated":"2015-09-17 09:36:17.000000000","message":"Would actually be better to have this function as static method as it makes them overridable if someone wants to inherits and write its own middleware.","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5a0d0eabef18197d17416e84f0303ed18d4e8c05","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from oslo_middleware import base"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _pretty_json_dumps(contents):"},{"line_number":38,"context_line":"    return json.dumps(contents, indent\u003d4, sort_keys\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_bcb83712","line":37,"in_reply_to":"ba15a1d1_726858bb","updated":"2015-09-17 21:35:39.000000000","message":"Ok, fair enough, my pretty might not be your pretty.","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6d721aad24981297c803806c5adb0dd7ca61e027","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _make_text_response(self, results):"},{"line_number":174,"context_line":"        healthy \u003d self._are_results_healthy(results)"},{"line_number":175,"context_line":"        status \u003d self.HEALTHY_TO_STATUS_CODES[healthy]"},{"line_number":176,"context_line":"        params \u003d {"},{"line_number":177,"context_line":"            \u0027reasons\u0027: [result.reason for result in results],"},{"line_number":178,"context_line":"            \u0027detailed\u0027: self._show_details,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_ebf06093","line":175,"updated":"2015-09-16 21:39:41.000000000","message":"should we just calculate this in process_request since it\u0027s common to everything and not used in these methods specifically?","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"691ffe3abcc48ff2560785376e3622e1cdf0349a","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _make_text_response(self, results):"},{"line_number":174,"context_line":"        healthy \u003d self._are_results_healthy(results)"},{"line_number":175,"context_line":"        status \u003d self.HEALTHY_TO_STATUS_CODES[healthy]"},{"line_number":176,"context_line":"        params \u003d {"},{"line_number":177,"context_line":"            \u0027reasons\u0027: [result.reason for result in results],"},{"line_number":178,"context_line":"            \u0027detailed\u0027: self._show_details,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_0b326af2","line":175,"in_reply_to":"ba15a1d1_ebf06093","updated":"2015-09-17 04:09:55.000000000","message":"Probably.","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6d721aad24981297c803806c5adb0dd7ca61e027","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                                   fully_qualified\u003dFalse),"},{"line_number":217,"context_line":"            })"},{"line_number":218,"context_line":"        params \u003d {"},{"line_number":219,"context_line":"            \u0027healthy\u0027: self._are_results_healthy(results),"},{"line_number":220,"context_line":"            \u0027hostname\u0027: hostname,"},{"line_number":221,"context_line":"            \u0027results\u0027: translated_results,"},{"line_number":222,"context_line":"            \u0027detailed\u0027: self._show_details,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_4ba38c9d","line":219,"updated":"2015-09-16 21:39:41.000000000","message":"reuse healthy var from above","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f9edcd7b36d89ba7139d011d10ac7ee24bd7a588","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                                   fully_qualified\u003dFalse),"},{"line_number":217,"context_line":"            })"},{"line_number":218,"context_line":"        params \u003d {"},{"line_number":219,"context_line":"            \u0027healthy\u0027: self._are_results_healthy(results),"},{"line_number":220,"context_line":"            \u0027hostname\u0027: hostname,"},{"line_number":221,"context_line":"            \u0027results\u0027: translated_results,"},{"line_number":222,"context_line":"            \u0027detailed\u0027: self._show_details,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_0b490a60","line":219,"in_reply_to":"ba15a1d1_4ba38c9d","updated":"2015-09-17 04:10:32.000000000","message":"Done","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6d721aad24981297c803806c5adb0dd7ca61e027","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        results \u003d [ext.obj.healthcheck() for ext in self._backends]"},{"line_number":233,"context_line":"        accept_type \u003d req.accept.best_match(self._accept_order)"},{"line_number":234,"context_line":"        if not accept_type:"},{"line_number":235,"context_line":"            accept_type \u003d self._default_accept"},{"line_number":236,"context_line":"        functor \u003d self._accept_to_functor[accept_type]"},{"line_number":237,"context_line":"        status, body, content_type \u003d functor(results)"},{"line_number":238,"context_line":"        return webob.response.Response(status\u003dstatus, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_6b80d0f7","line":235,"updated":"2015-09-16 21:39:41.000000000","message":"accept_type \u003d req.accept.best_match(self._accept_order) or self._default_accept","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"691ffe3abcc48ff2560785376e3622e1cdf0349a","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        results \u003d [ext.obj.healthcheck() for ext in self._backends]"},{"line_number":233,"context_line":"        accept_type \u003d req.accept.best_match(self._accept_order)"},{"line_number":234,"context_line":"        if not accept_type:"},{"line_number":235,"context_line":"            accept_type \u003d self._default_accept"},{"line_number":236,"context_line":"        functor \u003d self._accept_to_functor[accept_type]"},{"line_number":237,"context_line":"        status, body, content_type \u003d functor(results)"},{"line_number":238,"context_line":"        return webob.response.Response(status\u003dstatus, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_cb4eb26e","line":235,"in_reply_to":"ba15a1d1_6b80d0f7","updated":"2015-09-17 04:09:55.000000000","message":"Done","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b82b0e4114373b781eb225037a02da6e011b2c79","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        results \u003d [ext.obj.healthcheck() for ext in self._backends]"},{"line_number":233,"context_line":"        accept_type \u003d req.accept.best_match(self._accept_order)"},{"line_number":234,"context_line":"        if not accept_type:"},{"line_number":235,"context_line":"            accept_type \u003d self._default_accept"},{"line_number":236,"context_line":"        functor \u003d self._accept_to_functor[accept_type]"},{"line_number":237,"context_line":"        status, body, content_type \u003d functor(results)"},{"line_number":238,"context_line":"        return webob.response.Response(status\u003dstatus, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_9cf0d3ca","line":235,"in_reply_to":"ba15a1d1_6b80d0f7","updated":"2015-09-17 21:41:52.000000000","message":"Hmmm, that makes the line to long, just sticking with this.","commit_id":"ab4d050069fa6da7fd2d88a0796a6b8d4080a3f7"}],"oslo_middleware/tests/test_healthcheck.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bc557f79563af3f711ed054adca1157f731da5e4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        conf \u003d {\u0027backends\u0027: \u0027disable_by_file\u0027,"},{"line_number":78,"context_line":"                \u0027disable_by_file_path\u0027: \u0027/foobar\u0027, \u0027detailed\u0027: True}"},{"line_number":79,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":80,"context_line":"        self.assertIn(\u0027Result of 1 checks:\u0027, res.body)"},{"line_number":81,"context_line":"        self.assertIn(\u0027\u003cTD\u003eOK\u003c/TD\u003e\u0027, res.body)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_disablefile_disabled(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_c6c0032e","line":80,"updated":"2015-09-11 05:55:56.000000000","message":"maybe use the template from __init__.py to generate the expected response.body in this test?","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"52ecde42dd0856c4df911cbbe2ce1ada1e15f2cb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        conf \u003d {\u0027backends\u0027: \u0027disable_by_file\u0027,"},{"line_number":78,"context_line":"                \u0027disable_by_file_path\u0027: \u0027/foobar\u0027, \u0027detailed\u0027: True}"},{"line_number":79,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":80,"context_line":"        self.assertIn(\u0027Result of 1 checks:\u0027, res.body)"},{"line_number":81,"context_line":"        self.assertIn(\u0027\u003cTD\u003eOK\u003c/TD\u003e\u0027, res.body)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_disablefile_disabled(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_66a01743","line":80,"in_reply_to":"da20952f_c6c0032e","updated":"2015-09-11 06:07:53.000000000","message":"hmmmm, idk, that to me is starting to get really deep into replicating the code the healthcheck object is doing, which seems to be sorta weird i think..","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bc557f79563af3f711ed054adca1157f731da5e4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                \u0027disable_by_file_path\u0027: \u0027/foobar\u0027, \u0027detailed\u0027: True}"},{"line_number":79,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":80,"context_line":"        self.assertIn(\u0027Result of 1 checks:\u0027, res.body)"},{"line_number":81,"context_line":"        self.assertIn(\u0027\u003cTD\u003eOK\u003c/TD\u003e\u0027, res.body)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_disablefile_disabled(self):"},{"line_number":84,"context_line":"        filename \u003d self.create_tempfiles([(\u0027test\u0027, \u0027foobar\u0027)])[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_66e817b4","line":81,"updated":"2015-09-11 05:55:56.000000000","message":"check the status codes too?","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"52ecde42dd0856c4df911cbbe2ce1ada1e15f2cb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                \u0027disable_by_file_path\u0027: \u0027/foobar\u0027, \u0027detailed\u0027: True}"},{"line_number":79,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":80,"context_line":"        self.assertIn(\u0027Result of 1 checks:\u0027, res.body)"},{"line_number":81,"context_line":"        self.assertIn(\u0027\u003cTD\u003eOK\u003c/TD\u003e\u0027, res.body)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_disablefile_disabled(self):"},{"line_number":84,"context_line":"        filename \u003d self.create_tempfiles([(\u0027test\u0027, \u0027foobar\u0027)])[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_26877fb6","line":81,"in_reply_to":"da20952f_66e817b4","updated":"2015-09-11 06:07:53.000000000","message":"sure","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bc557f79563af3f711ed054adca1157f731da5e4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        filename \u003d self.create_tempfiles([(\u0027test\u0027, \u0027foobar\u0027)])[0]"},{"line_number":94,"context_line":"        conf \u003d {\u0027backends\u0027: \u0027disable_by_file\u0027,"},{"line_number":95,"context_line":"                \u0027disable_by_file_path\u0027: filename, \u0027detailed\u0027: True}"},{"line_number":96,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":97,"context_line":"        self.assertIn(\u0027\u003cTD\u003eDISABLED BY FILE\u003c/TD\u003e\u0027, res.body)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_two_backends(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_46fab378","line":96,"updated":"2015-09-11 05:55:56.000000000","message":"same comments as above","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bc557f79563af3f711ed054adca1157f731da5e4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \u0027disable_by_file_path\u0027: filename, \u0027detailed\u0027: True}"},{"line_number":96,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":97,"context_line":"        self.assertIn(\u0027\u003cTD\u003eDISABLED BY FILE\u003c/TD\u003e\u0027, res.body)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_two_backends(self):"},{"line_number":100,"context_line":"        filename \u003d self.create_tempfiles([(\u0027test\u0027, \u0027foobar\u0027)])[0]"},{"line_number":101,"context_line":"        conf \u003d {\u0027backends\u0027: \u0027disable_by_file,disable_by_file\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6636d752","line":98,"updated":"2015-09-11 05:55:56.000000000","message":"Add test for simple response too?","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"52ecde42dd0856c4df911cbbe2ce1ada1e15f2cb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \u0027disable_by_file_path\u0027: filename, \u0027detailed\u0027: True}"},{"line_number":96,"context_line":"        res \u003d self._do_test_request(conf)"},{"line_number":97,"context_line":"        self.assertIn(\u0027\u003cTD\u003eDISABLED BY FILE\u003c/TD\u003e\u0027, res.body)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_two_backends(self):"},{"line_number":100,"context_line":"        filename \u003d self.create_tempfiles([(\u0027test\u0027, \u0027foobar\u0027)])[0]"},{"line_number":101,"context_line":"        conf \u003d {\u0027backends\u0027: \u0027disable_by_file,disable_by_file\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_c68fa3cb","line":98,"in_reply_to":"da20952f_6636d752","updated":"2015-09-11 06:07:53.000000000","message":"all the existing tests are the simple response tests ;)","commit_id":"e493ce61ca7e15ec9798fb4eb60e6fd7004bb316"}]}