)]}'
{"oslo_middleware/http_proxy_to_wsgi.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"5fd936b28750ce2012d8df4ea3576198872b78e6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            entry \u003d {}"},{"line_number":36,"context_line":"            for d in proxy.split(\";\"):"},{"line_number":37,"context_line":"                try:"},{"line_number":38,"context_line":"                    key, value \u003d d.split(\"\u003d\")"},{"line_number":39,"context_line":"                except ValueError:"},{"line_number":40,"context_line":"                    # Invalid header, ignore"},{"line_number":41,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_e90f4a86","line":38,"updated":"2015-09-28 08:31:58.000000000","message":"d.partition(\u0027\u003d\u0027) is safer, typically if value can contain \u0027\u003d\u0027","commit_id":"6ca4872d8a844dedb291d2266b33961bf3dfbc7e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c6f044a708494dfb363d85800b12306c69a49dd0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            entry \u003d {}"},{"line_number":36,"context_line":"            for d in proxy.split(\";\"):"},{"line_number":37,"context_line":"                try:"},{"line_number":38,"context_line":"                    key, value \u003d d.split(\"\u003d\")"},{"line_number":39,"context_line":"                except ValueError:"},{"line_number":40,"context_line":"                    # Invalid header, ignore"},{"line_number":41,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_84279511","line":38,"in_reply_to":"9a1a9d01_e90f4a86","updated":"2015-09-28 08:57:16.000000000","message":"Done","commit_id":"6ca4872d8a844dedb291d2266b33961bf3dfbc7e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"548d14a80544145f3c7b3c7cb9272815107a5184","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        result \u003d []"},{"line_number":34,"context_line":"        for proxy in header.split(\",\"):"},{"line_number":35,"context_line":"            entry \u003d {}"},{"line_number":36,"context_line":"            for d in proxy.split(\";\"):"},{"line_number":37,"context_line":"                key, _, value \u003d d.partition(\"\u003d\")"},{"line_number":38,"context_line":"                entry[key.lower()] \u003d value"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_7e9a0965","line":35,"updated":"2015-09-28 09:55:51.000000000","message":"We only need to parse the first \"entry\"","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"84a3f9d4b485e9894df168b288f554708a560e52","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        result \u003d []"},{"line_number":34,"context_line":"        for proxy in header.split(\",\"):"},{"line_number":35,"context_line":"            entry \u003d {}"},{"line_number":36,"context_line":"            for d in proxy.split(\";\"):"},{"line_number":37,"context_line":"                key, _, value \u003d d.partition(\"\u003d\")"},{"line_number":38,"context_line":"                entry[key.lower()] \u003d value"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_5e5b8554","line":35,"in_reply_to":"9a1a9d01_7e9a0965","updated":"2015-09-28 10:03:04.000000000","message":"Agreed but I\u0027m not sure it\u0027s worth changing that.","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"548d14a80544145f3c7b3c7cb9272815107a5184","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            # World before RFC7239"},{"line_number":60,"context_line":"            forwarded_proto \u003d req.environ.get(\"HTTP_X_FORWARDED_PROTO\")"},{"line_number":61,"context_line":"            if forwarded_proto:"},{"line_number":62,"context_line":"                req.environ[\u0027wsgi.url_scheme\u0027] \u003d forwarded_proto"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_9e86fd11","line":60,"updated":"2015-09-28 09:55:51.000000000","message":"iirc, it was requested in SSLMiddleware to allow setting a custom header as some uses X-Forwarded-Protocol","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"74f12dc27d88274b96580f115ee50c99fe7c18df","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            # World before RFC7239"},{"line_number":60,"context_line":"            forwarded_proto \u003d req.environ.get(\"HTTP_X_FORWARDED_PROTO\")"},{"line_number":61,"context_line":"            if forwarded_proto:"},{"line_number":62,"context_line":"                req.environ[\u0027wsgi.url_scheme\u0027] \u003d forwarded_proto"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_8f8489d4","line":60,"in_reply_to":"9a1a9d01_0ff399d7","updated":"2015-09-28 11:04:49.000000000","message":"Fine for me","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"419346e16705d6d0068179864682d31365a18341","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            # World before RFC7239"},{"line_number":60,"context_line":"            forwarded_proto \u003d req.environ.get(\"HTTP_X_FORWARDED_PROTO\")"},{"line_number":61,"context_line":"            if forwarded_proto:"},{"line_number":62,"context_line":"                req.environ[\u0027wsgi.url_scheme\u0027] \u003d forwarded_proto"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_0ff399d7","line":60,"in_reply_to":"9a1a9d01_1e7e6dae","updated":"2015-09-28 10:59:29.000000000","message":"Right, I am strongly opposed to making the header name configurable, that just makes things more divergent. We should support the common convention on, and the standards based one, and be done with it.","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"84a3f9d4b485e9894df168b288f554708a560e52","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            # World before RFC7239"},{"line_number":60,"context_line":"            forwarded_proto \u003d req.environ.get(\"HTTP_X_FORWARDED_PROTO\")"},{"line_number":61,"context_line":"            if forwarded_proto:"},{"line_number":62,"context_line":"                req.environ[\u0027wsgi.url_scheme\u0027] \u003d forwarded_proto"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_1e7e6dae","line":60,"in_reply_to":"9a1a9d01_9e86fd11","updated":"2015-09-28 10:03:04.000000000","message":"Really? I\u0027d be surprised to see anyone using some fancy header.\n\nAdding yet more options is not a good idea IMHO :/","commit_id":"89b11a1c731bea4c74498c46a5e4272eef55f2f6"}]}
